Received-SPF: pass (google.com: domain of linux-kernel+bounces-87240-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 29 Feb 2024 18:08:54 +0000
From: Conor Dooley <conor@kernel.org>
To: Frank Li <Frank.li@nxp.com>
Cc: Rob Herring <robh@kernel.org>, imx@lists.linux.dev,
	krzysztof.kozlowski+dt@linaro.org, kw@linux.com,
	linux-kernel@vger.kernel.org, conor+dt@kernel.org,
	linux-pci@vger.kernel.org, lpieralisi@kernel.org,
	helgaas@kernel.org, bhelgaas@google.com, devicetree@vger.kernel.org
Subject: Re: [PATCH v5 1/5] dt-bindings: pci: layerscape-pci: Convert to yaml
 format
Message-ID: <20240229-strategic-premises-967eae1f6d9f@spud>
References: <20240228190321.580846-1-Frank.Li@nxp.com>
 <20240228190321.580846-2-Frank.Li@nxp.com>
 <170915420970.759733.12998246565079147606.robh@kernel.org>
 <ZeDCQezI2zj8bWBP@lizhi-Precision-Tower-5810>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="Re0jwgYgtPOeuZKC"
Content-Disposition: inline
In-Reply-To: <ZeDCQezI2zj8bWBP@lizhi-Precision-Tower-5810>


--Re0jwgYgtPOeuZKC
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 12:43:29PM -0500, Frank Li wrote:
> On Wed, Feb 28, 2024 at 03:03:31PM -0600, Rob Herring wrote:
> >=20
> > On Wed, 28 Feb 2024 14:03:17 -0500, Frank Li wrote:
> > > Split layerscape-pci.txt into two yaml files: fsl,layerscape-pcie-ep.=
yaml
> > > and fsl,layerscape-pcie.yaml.
> > > yaml files contain the same content as the original txt file.
> > >=20
> > > The subsequent commit will fix DTB_CHECK failure.
> > >=20
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  .../bindings/pci/fsl,layerscape-pcie-ep.yaml  |  89 +++++++++++++
> > >  .../bindings/pci/fsl,layerscape-pcie.yaml     | 123 ++++++++++++++++=
++
> > >  .../bindings/pci/layerscape-pci.txt           |  79 -----------
> > >  3 files changed, 212 insertions(+), 79 deletions(-)
> > >  create mode 100644 Documentation/devicetree/bindings/pci/fsl,layersc=
ape-pcie-ep.yaml
> > >  create mode 100644 Documentation/devicetree/bindings/pci/fsl,layersc=
ape-pcie.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/pci/layerscape-=
pci.txt
> > >=20
> >=20
> > My bot found errors running 'make DT_CHECKER_FLAGS=3D-m dt_binding_chec=
k'
> > on your patch (DT_CHECKER_FLAGS is new in v5.13):
>=20
> Please omit these errors. Bjorn require create a identical version as
> old txt file.
>=20
> Origial txt will cause DTB_CHECK error. The problem will be fixed at next
> patches.

One of these is a real error - caused by a typo. "dma-coherence" should
be "dma-coherent".

>=20
> >=20
> > yamllint warnings/errors:
> >=20
> > dtschema/dtc warnings/errors:
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings=
/pci/fsl,layerscape-pcie.example.dtb: pcie@3400000: Unevaluated properties =
are not allowed ('#address-cells', '#interrupt-cells', '#size-cells', 'bus-=
range', 'device_type', 'interrupt-map', 'interrupt-map-mask', 'iommu-map', =
'msi-parent', 'ranges', 'reg-names' were unexpected)
> > 	from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie=
=2Eyaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings=
/pci/fsl,layerscape-pcie.example.dtb: pcie@3400000: 'fsl,pcie-scfg' is a re=
quired property
> > 	from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie=
=2Eyaml#
> > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings=
/pci/fsl,layerscape-pcie.example.dtb: pcie@3400000: 'dma-coherence' is a re=
quired property
> > 	from schema $id: http://devicetree.org/schemas/pci/fsl,layerscape-pcie=
=2Eyaml#
> >=20
> > doc reference errors (make refcheckdocs):
> >=20
> > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/2024=
0228190321.580846-2-Frank.Li@nxp.com
> >=20
> > The base for the series is generally the latest rc1. A different depend=
ency
> > should be noted in *this* patch.
> >=20
> > If you already ran 'make dt_binding_check' and didn't see the above
> > error(s), then make sure 'yamllint' is installed and dt-schema is up to
> > date:
> >=20
> > pip3 install dtschema --upgrade
> >=20
> > Please check and re-submit after running the above command yourself. No=
te
> > that DT_SCHEMA_FILES can be set to your schema file to speed up checking
> > your schema. However, it must be unset to test all examples with your s=
chema.
> >=20

--Re0jwgYgtPOeuZKC
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZeDINQAKCRB4tDGHoIJi
0lRyAP9fEXfWNs46QnjOnUvH2S38xwB64vicfxsWzjSwnN6DzAD/Z/FNBFX2hAZ4
3gNGGsWbqATFWZOMzrQPjVBaQcNQKAw=
=Bh1c
-----END PGP SIGNATURE-----

--Re0jwgYgtPOeuZKC--