Received-SPF: pass (google.com: domain of linux-kernel+bounces-87282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Thu, 29 Feb 2024 20:25:07 +0200
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Arturas Moskvinas <arturas.moskvinas@gmail.com>
Cc: Bartosz Golaszewski <brgl@bgdev.pl>, linus.walleij@linaro.org,
	u.kleine-koenig@pengutronix.de, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] gpio: 74x164: Enable output pins after registers are
 reset
Message-ID: <ZeDMA373a7pieSOO@smile.fi.intel.com>
References: <20240229084555.43701-2-arturas.moskvinas@gmail.com>
 <CAMRc=MfTo7MnfMhRQsjeFsLv3yjEtP0C3ytqACN+nuGw0Sr-Bg@mail.gmail.com>
 <15e6e45f-7398-4703-8154-35e769bac94a@gmail.com>
 <CAMRc=Mf__-sbAV0xuC2hsxm_-kQWqgxSLRYLKqt9-ce+8_Kf_w@mail.gmail.com>
 <f9e90eb2-60e5-4ae8-9f3f-92922294e981@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <f9e90eb2-60e5-4ae8-9f3f-92922294e981@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Feb 29, 2024 at 07:24:09PM +0200, Arturas Moskvinas wrote:
> On 2/29/24 15:25, Bartosz Golaszewski wrote:
> > On Thu, Feb 29, 2024 at 1:23 PM Arturas Moskvinas
> > <arturas.moskvinas@gmail.com>  wrote:
> > > Chip outputs are enabled[1] before actual reset is performed[2] which might
> > > cause pin output value to flip flop if previous pin value was set to 1
> > > in chip.
> > > Fix that behavior by making sure chip is fully reset before all outputs are
> > > enabled.
> > > 
> > > Bartosz, does this look better?
> > ... if previous pin value was set to 1 period
> Andriy, Bartosz, is commit message ok?

LGTM! Please, send a v3 with it.

-- 
With Best Regards,
Andy Shevchenko