Date: Thu, 3 Jan 2008 15:05:49 +0100
From: Ingo Molnar <mingo@elte.hu>
To: =?iso-8859-1?Q?J=F6rn?= Engel <joern@logfs.org>
Cc: Cyrill Gorcunov <gorcunov@gmail.com>, LKML <linux-kernel@vger.kernel.org>,
       David Woodhouse <dwmw2@infradead.org>
Subject: Re: [x86] kernel/audit.c cleanup according to checkpatch.pl
Message-ID: <20080103140549.GA19363@elte.hu>
References: <20080103111925.GC8046@cvg> <20080103112957.GA14693@lazybastard.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20080103112957.GA14693@lazybastard.org>
User-Agent: Mutt/1.5.17 (2007-11-01)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1132
Lines: 31


* J?rn Engel <joern@logfs.org> wrote:

> > -		       "audit: audit_lost=%d audit_rate_limit=%d audit_backlog_limit=%d\n",
> > +		       "audit: audit_lost=%d audit_rate_limit=%d "
> > +		       "audit_backlog_limit=%d\n",
> >  		       atomic_read(&audit_lost),
> >  		       audit_rate_limit,
> >  		       audit_backlog_limit);
> 
> This hunk is a bit questionable.  It can easily deceive a reader to 
> assume two seperate lines printed out and sometimes defeats grepping 
> for printk output to find the code generating the message.

not to make a big issue out of this, but when was the last time you 
tried to grep this way:

  grep -E "audit_rate_limit=[0-9]+ audit_backlog" */*.c

?

That's pretty much the only grep pattern that would break. People 
usually grep on the constant portion of the string, so breaking up a 
line along a variable boundary is perfectly okay.

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/