Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp79925lqc; Thu, 29 Feb 2024 10:50:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCV100dZyRBkI5c/5WkfcurH7BqLDw/UPRfdlRlqRLnHqzPHWH/yHyjWh0qGL8ig7V+22Wihuo2F2P0fnchO0aOlWNfAsMdZzL7bSTQCmg== X-Google-Smtp-Source: AGHT+IGRLzvtdknfkcM7ud//ie7J2qQF4a51+etj99i2Nj3GvTegKqS185KXc5pHElop14JZgLXZ X-Received: by 2002:a92:d347:0:b0:365:147e:f813 with SMTP id a7-20020a92d347000000b00365147ef813mr3576216ilh.23.1709232628044; Thu, 29 Feb 2024 10:50:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709232628; cv=pass; d=google.com; s=arc-20160816; b=xqEh/V3lveM075znLyT0yxPV5+dXaRzqCwojZRp2cjWtuLIppN8OxMQbFvzuxHjZtr lZo1GS6W3JHITDzeXOXAx1IRWm8CC9Y3Vd92ETnrUpTyMhUwH8+4lKFiuBDUeq1FL2k1 5IkfFNaw8d9npWoHogsgXQjGa2YpWclEFCOhTabh9EaGlrG77vbL4/HCFdbf2g4/d9du GgEXZPhgJ/dHLVgGe7eFYtUnEQxn4xo8npZ3EEybSo3zP9VThONkSBpD72WsqPkG5ugo nJEaOnhvcgflj/8jEoUlwBOQtd8+6lL/cqbHupNY0nR5gAbsHQdsK0H5k0IBTJLrOQnH C3ZQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=aYbYLgN//LB6IKshdj2UFvVMq+97XOWcZTiyLMqD288=; fh=WQ9+t+vfsHAQAcZT6YELarNK8PagKZCThpRX8IUC4kI=; b=qyn3SMlRFs/NlT4ykoWhN3z0n4qpjSyOQVnNoffSN65A8waRoqeteimjeXiCh1yUrM HxgqsCDO3pw+oWMvaiFgYippgmtYjXa2eBQKQWHTR3vAeF14HPwO7+RFCLnSAHK55dj9 jFw1uId9zCA3GmnqCfAX3o9fX5VHj7Bk4v5dJlaC8BS7gSOpjDAniprIqeQ3WOdGYLcM HUNUb5AD9RyDbQWYPo4EeGW7xTJ5OGsK0Vab0fFlk32kE2v8ogx3WkPjJd8feETGa3pr AmTaZrDRoJx0wWodxlL5IL0iO1pIV4OAYvftq08N7jAgmNmfZepYcYl19qygZlNsKMs6 NTvw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iM5mHmPo; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-87296-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87296-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id u4-20020a656704000000b005dc484eaff9si1867675pgf.483.2024.02.29.10.50.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 10:50:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87296-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=iM5mHmPo; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-87296-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87296-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 8A22FB227A7 for ; Thu, 29 Feb 2024 18:30:47 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 776DB134411; Thu, 29 Feb 2024 18:30:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="iM5mHmPo" Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8BAF1134401 for ; Thu, 29 Feb 2024 18:30:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709231425; cv=none; b=fw3X6YD/tW/1awRl4NdFPEGI6AgJjMbNC0IIvsIVrYkd1y6SwLDD2tcOa4E5G2Z4aWigAApZtek2X6Nh4MC74+W/N+sWAafc4rgSLEr4Z2MXEB2lHYivOXBfBNbtQGQ7pWZf2OE7gP9FOVC4XLSURGwxoHQY8tRctFwTTzBAWms= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709231425; c=relaxed/simple; bh=8yy/4GV1yFJzF9sv2B95/iwZJPmwic5KkIWGzHyFdDA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=gXajQnDeRQN8/UN5G1MotFMlIP2STEsELcpCxBP6QoGtp/MTV9RQRrQJILiv+ip6BuCM5imUGYXfsxNYNig/QffqRZklCl30gg3t2ejYc7tsmQPj1jwGSvaJyyyHSjcev1e0KoFjkf5wvxcfRu+LuopizdTHqaBvgXCuvsydfcY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=iM5mHmPo; arc=none smtp.client-ip=209.85.214.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-1dcd6a3da83so9115175ad.3 for ; Thu, 29 Feb 2024 10:30:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709231422; x=1709836222; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aYbYLgN//LB6IKshdj2UFvVMq+97XOWcZTiyLMqD288=; b=iM5mHmPoziyBmXNKdfjG1EYs9RZkxqajHY0iJTm8qPwQw7XSYOaQmmExCBBqcpxL4k S1mlEu61ub7ABvinLlFMWO0Aet7chIuR4vUqHYZM4CGZESNe1dTYwittwTDQi0ewrRY1 HPmeUJKQL/2H6rQa4zKQVPc1Z1ERlwwVXNLV8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709231422; x=1709836222; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aYbYLgN//LB6IKshdj2UFvVMq+97XOWcZTiyLMqD288=; b=CfLJzcrxx/EvlPNupdOKw5lAWr54JceoMr2TmeCzHO6vNaB72imkewesXfN7bls/ZC uz2BpQbyTKTWOm7Z090gMfwqtsGClSrpo9ufRStw+WtMKzWD1u9WzZK81MXIQexrhj8a EpYJZ6jwHZrhGcWCb3cD/4VDccpbVhzQ/omRd/S5fmmKUAPKhi4RCl9PP7848+W4KjXa S4nXuZ4l6FamdCQpTkUqBPw1svy3XFL4As8p7RIGhwHVW3xFx4xtJ3QbobvoqBq0NwNi f2m725F3ST4Kk9WB/AlibvyN5aWgPZ0jfjSF3UJ7u5WkmfhE3U69KSVlt60yxH2hVZ/y bbug== X-Forwarded-Encrypted: i=1; AJvYcCVprSuB6yKE5KyHdNgh96XiJ8mrltzvTbBBt84jzYwZ3Rfq9rpfawniAwjF8FSTv/1xHQRQhfKtejGbXJwisY3da1mpbh/+Ugo3Wscj X-Gm-Message-State: AOJu0Yyc5jwpubNVaRifqci1gUHvm4qYFjciLlzxek2tXLsALdU2l8X0 q7nolY24Jlc5QTEUjLXU9Vg/2AvJxrZRt/M9T1js8NLi7zuRScOMOhUVyz9NHQ== X-Received: by 2002:a17:902:d4c4:b0:1db:ea23:9ee6 with SMTP id o4-20020a170902d4c400b001dbea239ee6mr3615434plg.12.1709231421915; Thu, 29 Feb 2024 10:30:21 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id 21-20020a170902c15500b001d93a85ae13sm1803519plj.309.2024.02.29.10.30.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 10:30:21 -0800 (PST) From: Kees Cook To: Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Andy Shevchenko Cc: Kees Cook , Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: (subset) [PATCH v4 1/8] overflow: Use POD in check_shl_overflow() Date: Thu, 29 Feb 2024 10:30:14 -0800 Message-Id: <170923141241.775345.14051727895770192324.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-2-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Wed, 28 Feb 2024 22:41:31 +0200, Andy Shevchenko wrote: > The check_shl_overflow() uses u64 type that is defined in types.h. > Instead of including that header, just switch to use POD type > directly. > > Applied to for-next/hardening, thanks! [1/8] overflow: Use POD in check_shl_overflow() https://git.kernel.org/kees/c/4e55a75495b7 Take care, -- Kees Cook