Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754008AbYACOOS (ORCPT ); Thu, 3 Jan 2008 09:14:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751813AbYACOOJ (ORCPT ); Thu, 3 Jan 2008 09:14:09 -0500 Received: from zeniv.linux.org.uk ([195.92.253.2]:47554 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751501AbYACOOI (ORCPT ); Thu, 3 Jan 2008 09:14:08 -0500 Date: Thu, 3 Jan 2008 14:14:05 +0000 From: Al Viro To: Ingo Molnar Cc: Pekka J Enberg , Jiri Slaby , Linux Kernel Mailing List Subject: Re: isofs oops - d_splice_alias+0x1f (2.6.24-rc5-mm1) Message-ID: <20080103141405.GV27894@ZenIV.linux.org.uk> References: <477CE1E0.4010504@gmail.com> <20080103141120.GC19363@elte.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080103141120.GC19363@elte.hu> User-Agent: Mutt/1.4.2.3i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 605 Lines: 12 On Thu, Jan 03, 2008 at 03:11:20PM +0100, Ingo Molnar wrote: > and there are about 5 other callsites as well that only check for a NULL > return. ... except that this is *not* getting NULL or make_bad_inode(); that's getting ERR_PTR(), which can't happen in mainline. So that looks like an -mm patch changing calling conventions and not updating callers... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/