Received-SPF: pass (google.com: domain of linux-kernel+bounces-87355-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Thu, 29 Feb 2024 14:31:20 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <ZeDbiLR8vLtVfgGX@lizhi-Precision-Tower-5810>
References: <20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com>
 <20240227-asrc_8qxp-v2-3-521bcc7eb1c0@nxp.com>
 <20240229-husband-penalty-8c1ab0f57f55@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240229-husband-penalty-8c1ab0f57f55@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?yO4X9BN4xtCWc/gngle1kskE5Wq0R7CfCmwpiAtm0emMeSCA1BB/eE7BLubl?=
 =?us-ascii?Q?XlcNDv7hWWb8nwVXTzs2GQ+Ll90pzQUnAusInWLdUaQuewmwaoBJkkgGa9dG?=
 =?us-ascii?Q?E9pbk1/sm6w5ZSEGkEUo0RukxpVR3OcFFQE/t8eM9cClBuZevxTqKB4IP10t?=
 =?us-ascii?Q?16mHHblMAqNYqz2UJYquFXc+DUKI0JBT3+XpcRt/XiDj88/TEopyhKrHtCx+?=
 =?us-ascii?Q?34ZF833oR2x3kDyuc6pOuWEblBPTuIojS1EREwGlKYrGZXlFby+vG/14xZYg?=
 =?us-ascii?Q?CYAGlri9iSbhViKNe0KB2rmB5CCTlncbJGCEMwjge77v1q159Ql+bQE3TScx?=
 =?us-ascii?Q?QPZWH8ymIv7o3GskUhVICNVrCrnioeDY3TzX5aCelIztmZ9O7NEdpofztL67?=
 =?us-ascii?Q?JzVcXB5/5IKgNykILu5HGDRpa8ABlD5Bx/URjZOP8BbaLYzAvhgBLECglD9Q?=
 =?us-ascii?Q?QGCQuYLY/uqi2Vdb3BKytFe9C7he56m/6XF9Hht5/u8ImdvfpxmSdc2K/Ja+?=
 =?us-ascii?Q?tiH8pVYBYOmJgpZGSfi469oVrUz9ODKYXL2CJ052KWDk3Lijd8uk1U2ts/+y?=
 =?us-ascii?Q?YkoaTDt4iCak0SY6InWMxdhjz1+0LuUw2uTGELri0rRiHrNgDnOjUH5n3bSB?=
 =?us-ascii?Q?SsW13JHvqvwNrMJC7Nm7TWbmXlcJrZ9q6EZZpDTthQcwpK1uvb+d7mzTKbmj?=
 =?us-ascii?Q?bG748EKFFWzq+gBaNIOyw2GtVxcUwMzx3yUABfL32A4bgOnxhw3Al2kBbewL?=
 =?us-ascii?Q?RjLS4VYumIUSE+cMI1KrgOdmVgPdyYTtD7SWL5jZ/sB8GemTSR19mHU84vjw?=
 =?us-ascii?Q?T8x6smJ9Zfwxs4RUQ1IdxJ+7rFRcXb7NwV6JSqcwMVGAeHGAzsu8eXGsOyd8?=
 =?us-ascii?Q?u/7WJbLBFEnSevnKVxp7Y/Moib8kG4aLvvEXsqN88mIVdpuJXPc7kobvGg/M?=
 =?us-ascii?Q?gjEREzZHvaOeu1IeBqQeCBtzZO8Npsq9xv4c3sEI6bl/XzeYcrGhI2jDeVMC?=
 =?us-ascii?Q?jTYo3rZHZyiYpBV5T35x3gNVgxO5JPlqW2qYXviwCfvHOXQp5iiDkOHVeUoj?=
 =?us-ascii?Q?+2MD5VnKn8VHQ0jyTSGohx0M8TgVCSnwOqqSCBIkfqm+/98qEytz9+o7gCOy?=
 =?us-ascii?Q?A09rWd+C1b9ISm+gbxmsYOyOT0lFbmanxlWQAiYkk1PdtUOTRvBk4lbqwC0Z?=
 =?us-ascii?Q?keNGkoIvBWJvyLGNuIDKyegHzkSTFSSsaOhnn6bKL0FdVlJDo1EI8ZSvOMDz?=
 =?us-ascii?Q?qz6lq6QbLQ8LfcfFcu0ceC+DqNt57i5SoSdHNAXX8bIXwPcfhw4/DXaGJa7i?=
 =?us-ascii?Q?HFfbommbQfZ292ggjxl82n/Ax9TMM/Nd/EinGrX9jrtBBlvH5N1bu2oN0qws?=
 =?us-ascii?Q?A0MwdsNqxPrI+XsvnGaUmXjrq2TdtRr8+TGHTbB1mYvN5ghpkIh6gDtckXBG?=
 =?us-ascii?Q?XZd+BqM29MuU+F95S8utey2GwzLoHLwFta1n6hbBMMRkbihk06NBXyS60+xh?=
 =?us-ascii?Q?JKNdrVP1Nh5rn1CHT+84XTSW5KogwYYqbQEWje9sfpZH6pfSxjT7Iq+03wKz?=
 =?us-ascii?Q?qLxSCJ5sqqkjKD7VKM6d6rrRUyIvZsICEgT394HD?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 85c7c9c7-a044-49ec-67cc-08dc395d06de
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 19:31:29.0641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /w43dZGDtjx3van6ys9xXqj4Tn7xdnVIzrQjfR1YYap7ZoZ7ZYMXX7dtlSPT7lwu8zByUwolhiX0zrfiPZyy4A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB10194

On Thu, Feb 29, 2024 at 06:55:58PM +0000, Conor Dooley wrote:
> On Tue, Feb 27, 2024 at 03:54:11PM -0500, Frank Li wrote:
> > Some sai only connect one direction. So allow only "rx" or "tx" for
> > dma-names.
> 
> Which sai? Can you restrict this per compatible please, so that someone
> cannot add 2 dmas for ones where only the tx is supported.

SAI is exact the same. Only external connect one dma channel.

> 
> |  dmas:
> |    minItems: 1
> |    items:
> |      - description: DMA controller phandle and request line for RX
> |      - description: DMA controller phandle and request line for TX
> 
> The binding already allows only one, but it documents that the first dma
> is always the RX dma, and that doesn't change with this patch..

Does below logic work? 

anyOf
  - enum
      - description: ---rx
      - description: ---tx

> 
> Cheers,
> Conor.
> 
> > 
> > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > ---
> >  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > index 2456d958adeef..0302752d58a2b 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > @@ -86,10 +86,14 @@ properties:
> >        - description: DMA controller phandle and request line for TX
> >  
> >    dma-names:
> > -    minItems: 1
> > -    items:
> > -      - const: rx
> > -      - const: tx
> > +    oneOf:
> > +      - items:
> > +          - const: rx
> > +          - const: tx
> > +      - items:
> > +          - enum:
> > +              - rx
> > +              - tx
> >  
> >    interrupts:
> >      items:
> > 
> > -- 
> > 2.34.1
> >