Received-SPF: pass (google.com: domain of linux-kernel+bounces-87362-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 29 Feb 2024 14:38:24 -0500
From: Frank Li <Frank.li@nxp.com>
To: Conor Dooley <conor@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	Shengjiu Wang <shengjiu.wang@nxp.com>, linux-sound@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/4] ASoC: dt-bindings: fsl-sai: allow only one
 dma-names
Message-ID: <ZeDdMJlxBL4SGkws@lizhi-Precision-Tower-5810>
References: <20240227-asrc_8qxp-v2-0-521bcc7eb1c0@nxp.com>
 <20240227-asrc_8qxp-v2-3-521bcc7eb1c0@nxp.com>
 <20240229-husband-penalty-8c1ab0f57f55@spud>
 <20240229-rundown-isotope-954ba9ea4c57@spud>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240229-rundown-isotope-954ba9ea4c57@spud>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?FqDVGuMyPb5Nmus7BNsbyfNYy1yaMxRGna1NovDdCjgucheZQ5gaIL+1sebK?=
 =?us-ascii?Q?9mrvC4bNMzbDdLSJ+MxMQWm4gYs/VK2tqrXwPYuUZuBUQDe58eSrWxwkHmfT?=
 =?us-ascii?Q?kv63m+8MM0hRtBsOXCrCpT4haXXKz/mWZRsEJ8bwZNUHyqXfR4zqMDp/bl6A?=
 =?us-ascii?Q?3kc23eQW5a12pyxyIKHp+q3OTN2wwi6KJUweslil2IZBNVYY+qQu7oQx4PNc?=
 =?us-ascii?Q?CYicN4+l+ud5NUGtM+4ltdslqZotzGWOVYxAmeASLWRwP6yDlE3VI3wDaY6u?=
 =?us-ascii?Q?Y0ZCWwc4GBpiu8CfGhfp4/33yX4gL8JSyVxfz/GXzgefGiQOkWtxPM932PO9?=
 =?us-ascii?Q?q0ANSmgDm4elPcNJ0dJen27k15Xkx6LbgILf3PbTCLQa0SkERdcrldai9qni?=
 =?us-ascii?Q?/MRyU6IW0ywE1lXZAuxg2jyA2+m7JlAw2126S3VsEMJLV9xrm2nlQGizXw2j?=
 =?us-ascii?Q?i/GPEYep4ryWOgRHC6HtRRI9OmEo0OHiNoo4uWOEAc3IF7m+KOKAOLCLvP8I?=
 =?us-ascii?Q?K2ZZd+Tih7jVDqAVCWYIxrR9VrQpwhRciTcZvudfw2nSjTsbiOb3TRGBc7or?=
 =?us-ascii?Q?Q08jL0h4EVB1gNVPyDZFBcxNMkMo0570CJwmeac5g+WYEzuhG0nYq1OJMhdm?=
 =?us-ascii?Q?/vMMdTTSCEYbzMvy6N/Ri2PSl6ulPwy4xyYaTf1COndwTd/e6Uw21gbUUtbE?=
 =?us-ascii?Q?YvV/Ohq7XjY1Z/xyMFbKYJvrzplfbs8MViy33OdZ9W+D+AnWsEa6KiU5Opfd?=
 =?us-ascii?Q?qwKX08AMZUWZCe/NZGAigEmFuSoZiOtByPwO3Abp2LAuuWGHAL6ITr+H2wpF?=
 =?us-ascii?Q?b4485+mFaExc9iQWUG+uf3BqhHRAPVUjc8JI0Gin1x0bXnqYnyaYxgCfnoL7?=
 =?us-ascii?Q?w5FWJWHHseCsxM2Dg9w9sFOJWjg4aTZWTnqymwt/QgPSeHHKPykGFpTbhCSO?=
 =?us-ascii?Q?2jrC7/uKFtJRm+Ww5omHZBnYGNu5OTCpujfcZu8UoHm4BymBD8yPVpXUAVoW?=
 =?us-ascii?Q?VTL5uwcq0SU3VI1EL2JUqAy7jOvdPm6Xm+EZ7A8i/yzJaFNYUG0mK1jHDoqj?=
 =?us-ascii?Q?CViGGDgN8badj4ZPx/Ck97MEnv4pbXhTJOSQx5vz0vrNtRAzkddFJr3oKZnb?=
 =?us-ascii?Q?SiiCDRHUDKuBIRtIp/BfSTClKbhpVHxGYHVO665Bl0fTQDkeu/jGtytvPSS0?=
 =?us-ascii?Q?P3B/O4ZRTVQWNbSj7o7tEljcLaQR17iV5nvcStUNNRbbayad6O813olnIGC/?=
 =?us-ascii?Q?4bNTIqOecFGNTRovWZoHb0tUUHsBC6IjuB++ZMssplvIXjYcIy/Mc0W05zen?=
 =?us-ascii?Q?00n/L2zsK92ISRaCppOlMD1Ml7VOWejOHGWsykZv5Dr7aiVIewoN1Z6qYJbf?=
 =?us-ascii?Q?WBL7zj7CCu3INbziITJeRqm7Xc7HPGNsVe1zHP7vkSafiQEPb6Ho4F0I0tML?=
 =?us-ascii?Q?cVqQwYsn2WVjAPmfG+m17fdEY2G9iZ19OB/r1uF+mXRl6elbcRRfnzi9pxH+?=
 =?us-ascii?Q?6YzZzxmk0z11NC4mFEZnTYDi8TOjkhYIKd0CpIUM23yC7MXl0IkX/dGjIYse?=
 =?us-ascii?Q?9R2SNtQB1X5dQTOT4KFrJbpH4aPDILqmeZCVBW3u?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 943608f0-8070-4032-2a0d-08dc395e03b7
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 19:38:33.2848
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: iTORuBSiU+4kJ8YmQVj97sHE/y24kCNLy38nmMzQtJx8qhejtEwybJBhHVPKKwmJVzWewQ6g2bal7CM7Mm27FQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB6833

On Thu, Feb 29, 2024 at 06:57:29PM +0000, Conor Dooley wrote:
> On Thu, Feb 29, 2024 at 06:55:58PM +0000, Conor Dooley wrote:
> > On Tue, Feb 27, 2024 at 03:54:11PM -0500, Frank Li wrote:
> > > Some sai only connect one direction. So allow only "rx" or "tx" for
> > > dma-names.
> > 
> > Which sai? Can you restrict this per compatible please, so that someone
> > cannot add 2 dmas for ones where only the tx is supported.
> > 
> > |  dmas:
> > |    minItems: 1
> > |    items:
> > |      - description: DMA controller phandle and request line for RX
> > |      - description: DMA controller phandle and request line for TX
> > 
> > The binding already allows only one, but it documents that the first dma
> > is always the RX dma, and that doesn't change with this patch..
> 
> I said "doesn't change" - but I don't think you can change this
> trivially, as something could rely on the first dma being the rx one.
> You'd have to check that there is nothing using these using indices
> rather than names before making any changes here.

Linux driver and dts with tx only work well. Only issue is dtb_check will
report error. I want to eliminate these DTB_CHECK warning.

And it also reasonable, only rx or tx for a special SAI.

Can we remove 'description'? dmas should already descripted at common place
and 'RX' and 'TX' are listed at 'dma-names'

Frank

> 
> > 
> > Cheers,
> > Conor.
> > 
> > > 
> > > Signed-off-by: Frank Li <Frank.Li@nxp.com>
> > > ---
> > >  Documentation/devicetree/bindings/sound/fsl,sai.yaml | 12 ++++++++----
> > >  1 file changed, 8 insertions(+), 4 deletions(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/sound/fsl,sai.yaml b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > index 2456d958adeef..0302752d58a2b 100644
> > > --- a/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > +++ b/Documentation/devicetree/bindings/sound/fsl,sai.yaml
> > > @@ -86,10 +86,14 @@ properties:
> > >        - description: DMA controller phandle and request line for TX
> > >  
> > >    dma-names:
> > > -    minItems: 1
> > > -    items:
> > > -      - const: rx
> > > -      - const: tx
> > > +    oneOf:
> > > +      - items:
> > > +          - const: rx
> > > +          - const: tx
> > > +      - items:
> > > +          - enum:
> > > +              - rx
> > > +              - tx
> > >  
> > >    interrupts:
> > >      items:
> > > 
> > > -- 
> > > 2.34.1
> > > 
> 
>