Received-SPF: pass (google.com: domain of linux-kernel+bounces-87407-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <ac88ea82-d541-4016-95ce-58388b1f86e7@kernel.org>
Date: Thu, 29 Feb 2024 22:17:23 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 1/7] dt-bindings: iommu: Add Qualcomm TBU bindings
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Georgi Djakov <quic_c_gdjako@quicinc.com>, robh+dt@kernel.org,
 krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, will@kernel.org,
 robin.murphy@arm.com, joro@8bytes.org, iommu@lists.linux.dev
Cc: devicetree@vger.kernel.org, andersson@kernel.org,
 konrad.dybcio@linaro.org, robdclark@gmail.com,
 linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
 linux-arm-msm@vger.kernel.org, quic_cgoldswo@quicinc.com,
 quic_sukadev@quicinc.com, quic_pdaly@quicinc.com, quic_sudaraja@quicinc.com
References: <20240226172218.69486-1-quic_c_gdjako@quicinc.com>
 <20240226172218.69486-2-quic_c_gdjako@quicinc.com>
 <1239b980-da57-4cb1-bde0-47550dcf1065@linaro.org>
From: Georgi Djakov <djakov@kernel.org>
In-Reply-To: <1239b980-da57-4cb1-bde0-47550dcf1065@linaro.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

Hi Krzysztof,

On 29.02.24 19:59, Krzysztof Kozlowski wrote:
> On 26/02/2024 18:22, Georgi Djakov wrote:
>> The "apps_smmu" on the Qualcomm sdm845 platform is an implementation
>> of the SMMU-500, that consists of a single TCU (Translation Control
>> Unit) and multiple TBUs (Translation Buffer Units). These TBUs have
>> hardware debugging features that are specific and only present on
>> Qualcomm hardware. Represent them as independent DT nodes. List all
>> the resources that are needed to operate them (such as registers,
>> clocks, power domains and interconnects).
>>
>> Signed-off-by: Georgi Djakov <quic_c_gdjako@quicinc.com>
>> ---
>>   .../devicetree/bindings/iommu/qcom,tbu.yaml   | 65 +++++++++++++++++++
>>   1 file changed, 65 insertions(+)
>>   create mode 100644 Documentation/devicetree/bindings/iommu/qcom,tbu.yaml
> 
> Heh, I wonder how did you solve Robin's comments. I don't see you
> responding to Robin. Just v5 sent...

Yeah, i didn't respond because his response was clear to me. He responded
to the fundamental question whether to model the TBUs as child DT nodes of
the SMMU or as standalone nodes. So in the first versions of this patchset
we tried to explore the path with "child" nodes and search if there are any
other implementation than the Qualcomm one and try to find some common
binding... and Robin's objection was exactly to that. It seems that adding
more functionalities in TBUs (which requires resource management) is only
a Qualcomm thing and common binding does not make sense, so now we are
going with standalone DT nodes as he suggested.

Thanks,
Georgi