Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp153986lqc; Thu, 29 Feb 2024 13:08:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXLR+lD3xlcrJqYO7No28PqCMKdgTLoRWuUBrYIgMljZPitpP0kE7JxsPblnTBysEFqn5Q8V8LQPgjjpG39jfZMoWyjn6rrAk1oX4WARw== X-Google-Smtp-Source: AGHT+IG2+vbgvFcdPYV9ri/SfQzmykvPfgVJ+FEapL0o3VbT0oBv+6H4K2+rGosZmxwYEkouUt4q X-Received: by 2002:a05:6a00:1486:b0:6e4:8c89:3bf9 with SMTP id v6-20020a056a00148600b006e48c893bf9mr93134pfu.3.1709240893367; Thu, 29 Feb 2024 13:08:13 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709240893; cv=pass; d=google.com; s=arc-20160816; b=CBc+rj1v+FOvFB0IbJfAWDdlpVhJl/HFnMGsJSqwms55om53sWGSyV38kfo5tsbLwJ vx/aRVwfrhkIF48gkB8lYNx2wtO589C5u6caPDL7wKGhAdSk/6XeFjY7DQ45VaodhFjj pzGs6/WHn9Jy8KNvGPjnHoFi/vAdvrm2L/ZtJa8O0937KgExveXK+g3BvJQA6LQU34L8 K9zdEwsrEORo95XktaAeD0QXjcCwzcAOmz72Pp8X/YNPOagGRi1RZUbs3PLqXB60rvkB vTNKvvyA3f8Y7JoLJYdKbC9PW4dQHKBHy4CuGsWm8/K+LYeaRuf2uoaDpf67RnCEP+UH 8UgQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=lUk1CB2ycxiIbNTL38BPxZhcsmMcWqCD849+2CTOVuM=; fh=pNRtvYz4mH/ZJlnoka0Kb+FtwjLZSO/rVGm2boXyy6s=; b=SM3Lym52/tgciMh/qEimgPFeMnby5qaiGSU2t0nem+YEXdLfEmFSGKJ4Yj/QAfRnZG RJ2uymr/w4qTM9o5GyrGpu1TaBMAMLm29MOdzVrcchq5R2cLellM8HfTEFmol2QeAr7i 3M41VZByKqUWtymRCtpzhQu7AasUHKA1UzMBR4k16uGgOO6cfXPh3hPiFSB5XXTjJcZi nUboo4OcaScQoXAMpnFPpGEJzywQnfkWgHvnHuXBnegBw9ZRGggDlwZET0PA4W6CZKny FqLlfG54BRCaYKERSXsvW6eDFQHJVKkLy8N+hyyfsAgNAhL80JpUBm/vbG7t3HsjdQPs WIDA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMmcl2kE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-87497-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87497-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id fa28-20020a056a002d1c00b006e5736e9e47si2122587pfb.149.2024.02.29.13.08.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:08:13 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87497-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=IMmcl2kE; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-87497-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87497-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id E4A91B24B64 for ; Thu, 29 Feb 2024 20:56:35 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 47FDB16536A; Thu, 29 Feb 2024 20:41:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="IMmcl2kE" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6B25115176D; Thu, 29 Feb 2024 20:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709239272; cv=none; b=boB6vbDu/to3CMeRGe0P0TNMoZdyjSYsupufq/VdvFD8Jb1Tdk701TyFCXeikc9NyErQac45XqksJCIMg37GYDsQscuW/59Sz7mRUQD5hosyv3gGyMO/vC1uMl+fZxSiHdo7K0RMNZeWshDZOdXffO3E0wIvi5tjghvkDYSwmJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709239272; c=relaxed/simple; bh=8VVwG/bIdg9aEww7zqF3oialBxlZZB4yvhDB3Q+do1g=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=F56FG3WrDNxllyK4KKk9IXCEui03ymgOKxgU/DKELQwCpSCtb6qCqy4ljeSiCLDiLe+guBXlA4EIwA5qtOBmQH0OjPeZYU7sYstGMtgHGAC1Dg93XF3fUz3J7ASIZ2Tt/fr4FW7G6V9WlfWIoFSsEMDIQKAGjLhanBT+Vi35ee0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=IMmcl2kE; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id CEECBC43390; Thu, 29 Feb 2024 20:41:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709239269; bh=8VVwG/bIdg9aEww7zqF3oialBxlZZB4yvhDB3Q+do1g=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IMmcl2kE3YMKibPSHj3M4Jo5R8MezvDg611J8v9+6nP7kukokUQ72fn6QeoCYoJRA 3mEl2kmnN/vRyH4eD75lVoh0i1TPPl9PH+NWUhYgMvC3TMHpNiF+cKPH90HNRyGX0J uxWHwujCoHUt7xLFcDwF/LhlBl/AgjQ7i70AUXwf1zFNmUTpOLgF9DbchSAzaizqnt jO6dXn2V6B7IDVGSLrtcN7LHF5Z+opfcflytLAQYqRfd3Qy2/4XysKmcZQQ1gAeNvD 00xo4Y/XeKQb2lhe4HwTPvW/IlcJD//Tcv2elsNTR8CePAaocIIqzAVIchFPkyWx9F +mWMxxLcbrMUQ== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Yishai Hadas , Tamar Mashiah , Michael Guralnik , Leon Romanovsky , Sasha Levin , linux-rdma@vger.kernel.org Subject: [PATCH AUTOSEL 5.15 2/9] RDMA/mlx5: Relax DEVX access upon modify commands Date: Thu, 29 Feb 2024 15:40:58 -0500 Message-ID: <20240229204107.2861780-2-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229204107.2861780-1-sashal@kernel.org> References: <20240229204107.2861780-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 5.15.149 Content-Transfer-Encoding: 8bit From: Yishai Hadas [ Upstream commit be551ee1574280ef8afbf7c271212ac3e38933ef ] Relax DEVX access upon modify commands to be UVERBS_ACCESS_READ. The kernel doesn't need to protect what firmware protects, or what causes no damage to anyone but the user. As firmware needs to protect itself from parallel access to the same object, don't block parallel modify/query commands on the same object in the kernel side. This change will allow user space application to run parallel updates to different entries in the same bulk object. Tested-by: Tamar Mashiah Signed-off-by: Yishai Hadas Reviewed-by: Michael Guralnik Link: https://lore.kernel.org/r/7407d5ed35dc427c1097699e12b49c01e1073406.1706433934.git.leon@kernel.org Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/hw/mlx5/devx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/devx.c b/drivers/infiniband/hw/mlx5/devx.c index 104e5cbba066b..ef3585af40263 100644 --- a/drivers/infiniband/hw/mlx5/devx.c +++ b/drivers/infiniband/hw/mlx5/devx.c @@ -2922,7 +2922,7 @@ DECLARE_UVERBS_NAMED_METHOD( MLX5_IB_METHOD_DEVX_OBJ_MODIFY, UVERBS_ATTR_IDR(MLX5_IB_ATTR_DEVX_OBJ_MODIFY_HANDLE, UVERBS_IDR_ANY_OBJECT, - UVERBS_ACCESS_WRITE, + UVERBS_ACCESS_READ, UA_MANDATORY), UVERBS_ATTR_PTR_IN( MLX5_IB_ATTR_DEVX_OBJ_MODIFY_CMD_IN, -- 2.43.0