Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp165383lqc; Thu, 29 Feb 2024 13:31:58 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXxu8rPR5R3cm4N7AE86EC9zsSQn/vQW8ebYI2Li3MS0HabqXUs25xLRc4xls4WJy0pntkWoGqumiE+DAOYS/WzxKIh6qrEj0XMd0OXZQ== X-Google-Smtp-Source: AGHT+IHRqZgN/Abs28Lbrlg+OQ6rmk/g2iArEIDhDLSb8gV73W8nAIB3haI85WqCKy85UqGvHt99 X-Received: by 2002:a92:ca4d:0:b0:365:2732:8bb6 with SMTP id q13-20020a92ca4d000000b0036527328bb6mr341669ilo.11.1709242318439; Thu, 29 Feb 2024 13:31:58 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709242318; cv=pass; d=google.com; s=arc-20160816; b=kM+4Xo6hS31/ndySEv1AGInk2txLnguCYMp7eXwcXnIKEPZvK0M85KL0i5FWKSFtX8 S4xcRoSL8txQLF2BbPRm0yCDaenB2ARHIBzIsc3LOkLYNkewAChl3oABYHo2Xr6iV4Re AkshHcBiW7KbGUppvpC3z+6HU29RwF6yptJYPKlolNM9lLroabOFJR+V8CnCezYEv/sN wNzB8pis0ed0DQKp8dbcTK+L2R5xve0EemYvFtvm+udsp6+E+KUMGmFUMp6L4y3ZwP3R 7JD7Aj5RirPTVznFpeFRzUMQ/Znr8iYD4JTj7a2KwAWTBKVgcMF5siW9+fnKZ5peJwfn Pycg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; fh=JIm5PCctoAZ3CN71LBDWnidDj7FwzXUv6K8CvF2HSGs=; b=ZZ/w8Mv5RoUblTao/3CRxWthOlKj4+S1SEDCbyKAAzQHJDM7fWiY57WHLhesIXxmNU zMdbDkmV3TXIJVw08JH6nDdixk/BnskBXlI+EuMMO7723e9sASQCwthmTd/W2C9jIQ4x 9cq+NduhxCG/bSfoDI56LvDcUoA8ryDzIa2vY0hzTXzXmwNxm3cEqMzI3DQ1Of15pS2X 2IK8g4uqaA8QODY5sSzmNYDpiUEptSx5MTQ8vDVSwxbVVs+78vw2NgTsCV+ndtsPiOTz JtcpNAhNdxEw5JzBnUEAFVShnfpIcVyfHiUCJDcsSk2ReVYsiJLJZmweMc25vhb0Ra87 nJMQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Otdgupdr; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-87588-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id y6-20020a056a001c8600b006e47d95408asi2085992pfw.145.2024.02.29.13.31.58 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:31:58 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87588-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Otdgupdr; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-87588-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87588-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1A5B02843B2 for ; Thu, 29 Feb 2024 21:31:58 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A17226D51C; Thu, 29 Feb 2024 21:31:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Otdgupdr" Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7054916FF43 for ; Thu, 29 Feb 2024 21:31:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709242306; cv=none; b=cj4cLng/KmiFvY4LqJtW7EIXXtBIjZRnTo983GYpohLf2CVPzZjkNHBua3FmtIwcWlnb5SBr5gohy5XAsXBIWOe/p29iVA7+9/awXwVQbSKqCfjfVGtUJL4+8N3nvgDSyBH0+vzMcTyF/jEj59DnPMLz8oaPMA3Ko8BsnivEARU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709242306; c=relaxed/simple; bh=QzZTm6RzwKOCXz1s1DDgA6t36vWxFMgXU9qMOsdvjRM=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hLVAldLQEn6ZYYkcKIGxhvrJyQlVSwDqYCtI0OLRSpW00UlNvUqb42YEK3gO9vmAmjYJ2Cx44qApyvslKt9Tt8QLyc2dDfb1ZHebSYKd9ocFnjrJY1TGQiMQ2o8UwMuxV0byDdOQBMh37WUavSlDfFTre+rKyL6efw4mzGywJ2k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=Otdgupdr; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-1dc0e5b223eso13742465ad.1 for ; Thu, 29 Feb 2024 13:31:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709242305; x=1709847105; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; b=OtdgupdrMqUU6v6YG5ItdSUVYWtggtW7CLi08MPwU/tGTaozH8afksz/j9WnraUdkZ gQO7+saJw0TruPFKJJShHIMwzH14EPnGlOS+T/kEWAOEPVR4l6UaIrHpoabCCEf3XPtP BuKQeG2cQ0ZPa/TIhRpwB3WIcITiVw6Bv0O6A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709242305; x=1709847105; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=fi9gJh0JIT3rydMe7Re3YRcK5pxmffs/i/bQwJvpoAc=; b=gOTEw+Uk8OYMIGEmTy/7+lZ8EGhH+PP52MhoHIhUkXLcj57ihEo23GVOcBxEg/rJ33 7qo63aIrOS0tDUOrOU3MvDVP0H14EMDCZXq+J1iTV3QUUO/UErfwynO0AQAnFvwADMLI veVd4BjVzvslKedt6Fk4vr2cvbTebWYS0QEhvdeMsDa8Djs7b0r1ym1MDHZxrBKoojHi v6/r2nIL4MEx0CRuAfqL5zNk9kwj9n3X3tOaIbac+C/IsB2xU8LsoHPlgz8m0BNh1tIp Z7OCA5/dSDN95T+xnLmKoE8AbvAw+llDHL2NNXqc/wQaTdY1p1oXUviJtj8H+OPHjl6w p8ow== X-Forwarded-Encrypted: i=1; AJvYcCUduAWpyP9kJKUwIRoruGiXhKnQErdsMbfS48TTy3LyBmO/4aXrOgn0DjNKGnNGZrbhR1U16eQeLx9qo0jm9sJD7XQV71zIRroKZrG1 X-Gm-Message-State: AOJu0YwH1ODkGGxoGfvrZhLaS+uxxn4ODf+TpztGVSiwf3HnLc85Qcqa HFsFYnJjPKGOw5GQmLF4CHe3WeiftnAfmFtkbXu4CqSwqmVzzBBL3mQuQIT2ng== X-Received: by 2002:a17:902:654a:b0:1dc:ca72:8318 with SMTP id d10-20020a170902654a00b001dcca728318mr2807886pln.37.1709242304905; Thu, 29 Feb 2024 13:31:44 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id y9-20020a1709027c8900b001db717d2dbbsm1954387pll.210.2024.02.29.13.31.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:31:44 -0800 (PST) Date: Thu, 29 Feb 2024 13:31:43 -0800 From: Kees Cook To: Jakub Kicinski Cc: Andy Shevchenko , Vinod Koul , Linus Walleij , Jonathan Cameron , Mark Brown , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-iio@vger.kernel.org, linux-spi@vger.kernel.org, netdev@vger.kernel.org, linux-hardening@vger.kernel.org, Jonathan Cameron , Lars-Peter Clausen , "David S. Miller" , Eric Dumazet , Paolo Abeni , "Gustavo A. R. Silva" Subject: Re: [PATCH v4 7/8] net-device: Use new helpers from overflow.h in netdevice APIs Message-ID: <202402291330.0510946B67@keescook> References: <20240228204919.3680786-1-andriy.shevchenko@linux.intel.com> <20240228204919.3680786-8-andriy.shevchenko@linux.intel.com> <202402281341.AC67EB6E35@keescook> <20240228144148.5c227487@kernel.org> <202402281554.C1CEEF744@keescook> <20240228165609.06f5254a@kernel.org> <202402291059.491B5E03@keescook> <20240229113706.42c877a1@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240229113706.42c877a1@kernel.org> On Thu, Feb 29, 2024 at 11:37:06AM -0800, Jakub Kicinski wrote: > On Thu, 29 Feb 2024 11:08:58 -0800 Kees Cook wrote: > > > And some seem to be cargo-culted from out-of-tree code and are unused :S > > > > Ah, which can I remove? > > The one in igc.h does not seem to be referenced by anything in the igc > directory. Pretty sure it's unused. I'll double check. After trying to do a few conversions I really hit stuff I didn't like, so I took a slightly different approach in the patch I sent. -- Kees Cook