Received-SPF: pass (google.com: domain of linux-kernel+bounces-87593-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Thu, 29 Feb 2024 22:43:06 +0100
From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: Guenter Roeck <linux@roeck-us.net>, linux-rtc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Antoniu Miclaus <antoniu.miclaus@analog.com>
Subject: Re: [PATCH] rtc: max31335: fix interrupt status reg
Message-ID: <170924288521.1876058.17039410988641228858.b4-ty@bootlin.com>
References: <20240219091616.24480-1-antoniu.miclaus@analog.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240219091616.24480-1-antoniu.miclaus@analog.com>

On Mon, 19 Feb 2024 11:16:15 +0200, Antoniu Miclaus wrote:
> Fix the register value comparison in the `max31335_volatile_reg`
> function for the interrupt status register.
> 
> MAX31335_STATUS1 macro definition corresponds to the actual
> interrupt status register.
> 
> 
> [...]

I hope you realize that this is exactly what Guenter was referring to
when he said:

"It seems to be quite common for automotive chips, though, that they are held
tightly under wrap, making it all but impossible to properly review their drivers.
I have observed several times now that information not available to reviewers
resulted in bad or buggy drivers."


Applied

[1/1] rtc: max31335: fix interrupt status reg
      https://git.kernel.org/abelloni/c/c12e67e076cb

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com