Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp174561lqc; Thu, 29 Feb 2024 13:53:23 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWGjTBTOVPEOdpO9tAG2CMkfPBaQprF2TRgSk7BCb011qAQrAHmNiGkR0an1FXElSqTGGpXIUIkQolYufLodscvovW7kH9q0HV0i5cQAQ== X-Google-Smtp-Source: AGHT+IFtaiVCeTypEFbsSS/jV1bGM33XwRiP6pLvy/lYVfTTKrrkY/iZo8z4+NS3UExsNTujrqwT X-Received: by 2002:a17:90b:4f48:b0:29a:ac9d:a69d with SMTP id pj8-20020a17090b4f4800b0029aac9da69dmr398056pjb.34.1709243603164; Thu, 29 Feb 2024 13:53:23 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709243603; cv=pass; d=google.com; s=arc-20160816; b=Bm1PdGZwsepNd5WYySO53fioNhy/KG89TdmYHb5jDBULdHaG6BMXyVGt3yw3KB+6wk iEOM0SO5XbDnHDD16gAB+3TVfo0uecn49CnfqY3zIw4R2drH6JLGVCYxXuQwI8MKaCNp YljlPtffubCgei41j2XrHjI50xgKqhXtLVn0Luk4MUGbCRbzgWVivs3YzeGbi6dyDTYL t3azCVRoVlGiiHYIYOv9ps33cP+ULdrmlPNcGXDa/PgF+37bM03IuykmnE3Y64oexGfQ 5LPYMLAmEszG15emv3If1UenVX6GSr3pIBafbpwM1s/8j3U2qbP5lyeVCerQ+6R2rIPI pMtQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=VfVmIftr9u8G53CVoGBCv9uMSPlzLWhBX0yxZViPO7o=; fh=efQIERM9gXAtmTvRouD/37pmWOTss3ii7exRCjn+nfs=; b=ZcEL7sEq79Q7CNGuk6SrtT80NtGLRQVaCaA76oDeIoDfHH89vtvy4eC1S75JMVjpty I39u98DwZ7Z+PPgLcdghYy22GcdDcKPrMs/4jT6Z8e1JqOBwANPzUi2pQSMoEELzxxmj BdRPY3dwFsONlJqQwMTb42dREUYvs/ouUGcwlylL3aj/Drcugmax/+9kE4efaS49sU6j aWnxjazEZy+QJRLVIb/DISe0l+OE/X1EYz1KBgtQwoXKt1p4ELxKrOxFoQh3yPBE0Tj4 rzdPTTpTr7u19/kZx8Zgb7soAhFV0JJRy+iUNaX2UAwQKzDA16Xs1Jx8LJrcN5/DFTqL jyQw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CKKg21h0; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-87603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87603-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id oj12-20020a17090b4d8c00b0029a8b12c840si2392979pjb.35.2024.02.29.13.53.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:53:23 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=CKKg21h0; arc=pass (i=1 spf=pass spfdomain=chromium.org dkim=pass dkdomain=chromium.org dmarc=pass fromdomain=chromium.org); spf=pass (google.com: domain of linux-kernel+bounces-87603-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87603-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 57C5AB216FB for ; Thu, 29 Feb 2024 21:53:09 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 2FF886D52B; Thu, 29 Feb 2024 21:53:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="CKKg21h0" Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 15C766D513 for ; Thu, 29 Feb 2024 21:53:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709243583; cv=none; b=Nsl13pCpGPwbeO94lAKgPBFoC1qVNZOKp5aykhfTTY62rmMQpVZNLqaynp5LUxoa2gO3QB0LKOl0TJlGoj+X8/pz3ndNKhDYNFegixxFSLv0n6mUR6YqUHz4Ib6cDjaNF8VcdrTTCGzGPjJlCGexvr2Svu+wcyYCoYmua+RLOSo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709243583; c=relaxed/simple; bh=40LOGwLLO1L0EdJYZW5tRFxEBHq3W8RHKzr/KIs3gAo=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version:Content-Type; b=ZJql0gTMjx9DvL+AbuAZXVvqGviST1o+OrN417Al7wZiPPKqDxYVBxD1SY2CK0oant8uyWnEYPKplfPzc/rlIUhHaRLinYfDo5Okf9+S89DQxwmYo4n5RFMjzOY1PWJpj6q9Hu1rrC5EM9DUoxRkA1749Z2TXT9HQFX8u+Ud3MM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=CKKg21h0; arc=none smtp.client-ip=209.85.214.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-1dc1e7c0e29so1118635ad.1 for ; Thu, 29 Feb 2024 13:53:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1709243581; x=1709848381; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VfVmIftr9u8G53CVoGBCv9uMSPlzLWhBX0yxZViPO7o=; b=CKKg21h0vpw6xzLXV5wJwTLWeJopuFECBiuk8h23l7cNxO0xeZ9RVnFLq2hzHEj5Bj IYFg4tYrIWtWaFohxBvyRb1wZp5uZSQiiXAJQOuuy5af4J7rE6uCZ4gkLDQL2/DJtOuP 1dKLmU6NqIlSrk+eHS0VUSuyhERE2Iyy7aSo0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709243581; x=1709848381; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VfVmIftr9u8G53CVoGBCv9uMSPlzLWhBX0yxZViPO7o=; b=eg3sVF0MEMZMCjFWe0T7xCY3rS3H7n3TexvIESlGj9vvadPJ5loC7/6hliYrTOVAsc PCaPw30UhLyES7ZEMfKO4LVtUqeT3kUtK0FDPLkNS1Ov9hqbbDgBCVXYaxP2VB3PqLWG Rh7QSraBg8l+tgdvOUz45DH4Bpcu/KSd9FZP1xvvnlAvZOfF72vtBHqMRbx0Djg673b8 8BxXGAHNb2nFnWcqbuFCR8g7fl8JItcpzcRWJ+HXVqf91HMCzrvW7acLY911vBlNBX9S Hw2W7eeg9wwUplgkrOCYF8LXJn5IjLao5CDf4vNQxkrmT+DbvHRsuJsYob4HPDfG9DxU wt7A== X-Forwarded-Encrypted: i=1; AJvYcCWGsEdJLlkIO7wrEXkaq3CXwJdzMHcoL94JYKWK51R8L+GhO+x6EyKv7kP9mvaKYdTL4tiRGHnxIEzD1FJoI7CQ28lveXH7w5MyN6/B X-Gm-Message-State: AOJu0YxcNj5kZ5DEd496zoTg6dp/Y6vzKi6zcbWFOnjm87ad5kRHBDiG 4vXhlHGR4bY9Y9zbuDfgVeAnpjXvjgrbTCK6c+AfY0rmJzqkzPg3WZ6pUfw+rQ== X-Received: by 2002:a17:902:f603:b0:1dc:c45c:5d1d with SMTP id n3-20020a170902f60300b001dcc45c5d1dmr4470230plg.24.1709243581294; Thu, 29 Feb 2024 13:53:01 -0800 (PST) Received: from www.outflux.net ([198.0.35.241]) by smtp.gmail.com with ESMTPSA id x11-20020a170902a38b00b001dcdb39613fsm1911625pla.244.2024.02.29.13.53.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 13:53:00 -0800 (PST) From: Kees Cook To: Kent Overstreet , linux-hardening@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko Cc: Kees Cook , Andy Shevchenko , Andrew Morton , Suren Baghdasaryan Subject: Re: [PATCH v1 1/1] lib/string_helpers: Add flags param to string_get_size() Date: Thu, 29 Feb 2024 13:52:34 -0800 Message-Id: <170924355200.1509550.2313379734413200100.b4-ty@chromium.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240229205345.93902-1-andriy.shevchenko@linux.intel.com> References: <20240229205345.93902-1-andriy.shevchenko@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 29 Feb 2024 22:52:30 +0200, Andy Shevchenko wrote: > The new flags parameter allows controlling > - Whether or not the units suffix is separated by a space, for > compatibility with sort -h > - Whether or not to append a B suffix - we're not always printing > bytes. I cleaned up the Co-developed-by/S-o-b and applied to for-next/hardening, thanks! [1/1] lib/string_helpers: Add flags param to string_get_size() https://git.kernel.org/kees/c/ec8815c56558 Take care, -- Kees Cook