Received-SPF: pass (google.com: domain of linux-kernel+bounces-87605-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <04398f4e-6098-4559-9604-b9810753801e@intel.com>
Date: Fri, 1 Mar 2024 10:53:22 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 1/1] KVM: use KVM_HVA_ERR_BAD to check bad hva
Content-Language: en-US
To: Dongli Zhang <dongli.zhang@oracle.com>, <kvm@vger.kernel.org>
CC: <pbonzini@redhat.com>, <linux-kernel@vger.kernel.org>
References: <20240229212522.34515-1-dongli.zhang@oracle.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240229212522.34515-1-dongli.zhang@oracle.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?V1d1SnJaSkNBekxGaW02bTdCNE5hbzFFUGY0cGp6dXg0cFNJK3VXTU94UkRT?=
 =?utf-8?B?VWsvRmFsR2Vnc3lFMC8wRUtLVEMrcmJxZk5xeWJpaWtPY3NlMWFsTll0c2h0?=
 =?utf-8?B?VEVFeWtMRUlPd0VIclY0ZXIwdDZxZVErS3grMFAxNlJVcC9TUG9WMkZLU0hl?=
 =?utf-8?B?MVYxS0VBM0QrS2hGTnFaTFlLMVBFWTdPSDh0MlZ5Q0hNK2lkUzdkQi9uQlJp?=
 =?utf-8?B?MmZ6MTc2dmFvcmp1YVMyeHpuZ2JWMnYwaXJxbHU2aW1ERFFBZTJ1YjgyV3Qw?=
 =?utf-8?B?Uk85Y2Z1aEJzTlpLa1IwRE5yUkJhUGdnN0RrcS83WG5tZnlvdUlkakE4bEh6?=
 =?utf-8?B?Ni9iVnN6eFRWRU9BQW8wUzR4dVRIM2Nna0Jzclc4TE91SzNZT1hnalhjZ0Nk?=
 =?utf-8?B?K25iTDdCU09tcTNNc3Q2RDQ3am5IVmZqRS9XUjhvQlJidVlPRjAwL25YWWtT?=
 =?utf-8?B?ZGszK2wwY2lsSTA1TEF0NWtuSEp6bzI0RTFhTW1DTGVIUVc3Umprdm43d3NO?=
 =?utf-8?B?U1ovMkpQR1JoYnpkbVErQlNvc29tQktkYmJ6MTFpVmNiQTU3anVsc20xV2t5?=
 =?utf-8?B?M0hkSU9ibjJyTzBuNy8xbC9GelZsclJGZ3VGcnUwWTA2UjNNUHBFc2o0UUE1?=
 =?utf-8?B?TTlYUDgweHBSenp4L3ZDY1JqNVFLeE56L1pwTFB1RTQrQzhlWG8xT2NCK2JK?=
 =?utf-8?B?K3JJSmFFL2lxeXlmenZnWmVQbUE2NFc2VUZqZzFpMHZrZDhWbDYyM3ViWnFw?=
 =?utf-8?B?eUw0NHZtT1hOWTdFQ213S05IVkQ3bk9yVE9oYXpUQmJqTm9kNmJKa01hMjR5?=
 =?utf-8?B?aEdDQ0h1Nm14cXgycTlBdjFoYlVUSVVjOGxaYVBjNUlMcHRvL21FVittamtG?=
 =?utf-8?B?aGpFTEd5RWUrNmZNb3RHTHZTSXkzZ1djV2FvZ1dEWGdOTXo1ZHBDTmQxeWdE?=
 =?utf-8?B?ZEkxTkZCaU1hQ09xR2Jualp5RE56MXhlYkJtRjhhenRnREtxeWRhdXh0WDRG?=
 =?utf-8?B?WXJMZ2hDQzFrMUd1eUFTeHMzMmFLVmwyWE02S1J4TmxhTFgrMG81Si9IWVcw?=
 =?utf-8?B?UGtJanRmWE5BNElTWXl6YVpVaVdrZGp6ckxEYitXVUVLNnd5eVhnMnN6ZWxS?=
 =?utf-8?B?RW1qakNWUmlBNGdqTjBJcVNodnQrb0krbXB0VitkV2YwdzFWQ2llZnRQdHh3?=
 =?utf-8?B?ZWlnUWRoZkpqcXhGQXVveWxzbWYxN05JOXpsMGJzakxzaHFjKzBROWZoOGIz?=
 =?utf-8?B?VEwxMDA1YnowSjJFejJIRVM3T0p6ZFJoY0RPQlRyOEd5K0FpUjA4UkMvcUtL?=
 =?utf-8?B?V0s4Vk1yQVhxTkd5ek83VHJ2aHBrQi9JcnJ3TmF4UkhsUUJlek9GbWhIall3?=
 =?utf-8?B?Y04yL1hYeVpLamROV3p4NUFmemV0RGJSWTlyUWdqWXRFWHNwejNxYzBZTnN4?=
 =?utf-8?B?ZWhMSHM5N0Q1clJITHBSRkNJeFJ0MWVtSlhFUVdtamk4Yy9ZTFgzTHkwbEZ5?=
 =?utf-8?B?Z0x0Q0NIRHM0Mm90NEZpYjlhcEZWZkI0TWc4REloaUl2UXRUTEJhZGRnM050?=
 =?utf-8?B?UUpvdFFPVDViekd6MDZxR05HMTZvT0JDS0tncExTd2FGb0d3U3YvN3hDclBK?=
 =?utf-8?B?ZG9pK05nUFBJUzhDaDdnUmQvb04rUXk2VmE4QjlkenZMZjdFSDAzeG85blF4?=
 =?utf-8?B?dWZWdHo4dmtBTkMxbFlDcmd1alUxdnV5aW5yamtqN2VXanJkZnRFREIrYzJj?=
 =?utf-8?B?ZktBVk81MEZjUHBqVDVYczhWUkQ1S0FGc1J1R2FYR0xmK3VFMUZodDJMOEJs?=
 =?utf-8?B?aVRoUWtTeTYxWlJPMlNXTmtNK0NGbFBvYmxMY1FDbkhsTVlHMTU3SG9UWS9H?=
 =?utf-8?B?YTFGNGIvemsyZWVkQkNORmNYNG8weC9kdHVqUGtHTFJ4SlZNSGRFbndzTTVn?=
 =?utf-8?B?WDZMbDF6L1JpT2Q2M2VLbUt5TjNKZG9wemRmazcwWkVGdVdmY0tpU04yTmpB?=
 =?utf-8?B?TGN1RjN1MHBiS3BSTDFUQzdyZ3NtREl6RjF2UFR0R21aMTFYbzExeUM4amlP?=
 =?utf-8?B?TmtCR3lSOXBDYjlYV0Z0SVQrVFhiejk5aXF1aUpGQVFhZGVQVG1HNEg3TVBi?=
 =?utf-8?Q?B6aWCH4kVI0SMHNC/RFVBo4y1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c0c7df90-fe09-4262-8c70-08dc3970dde8
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 21:53:30.3337
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3tRnthajX5vI2XW/HepzhY/s4DZKEbtzb/56FFx+KnsME97c8PmgoGyGQ8dtUqEXaoJmLaPYZqT/g/GR41KOeA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7569
X-OriginatorOrg: intel.com


On 1/03/2024 10:25 am, Dongli Zhang wrote:
> Replace PAGE_OFFSET with KVM_HVA_ERR_BAD, to facilitate the cscope when
> looking for where KVM_HVA_ERR_BAD is used.
> 
> Every time I use cscope to query the functions that are impacted by the
> return value (KVM_HVA_ERR_BAD) of __gfn_to_hva_many(), I may miss
> kvm_is_error_hva().

I am not sure "to facilitate cscope" could be a justification to do some 
code change in the kernel.

> 
> Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
> ---
>   include/linux/kvm_host.h | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/kvm_host.h b/include/linux/kvm_host.h
> index 7e7fd25b09b3..4dc0300e7766 100644
> --- a/include/linux/kvm_host.h
> +++ b/include/linux/kvm_host.h
> @@ -143,7 +143,7 @@ static inline bool is_noslot_pfn(kvm_pfn_t pfn)
>   
>   static inline bool kvm_is_error_hva(unsigned long addr)
>   {
> -	return addr >= PAGE_OFFSET;
> +	return addr >= KVM_HVA_ERR_BAD;
>   }
>   
>   #endif


Also, IIUC the KVM_HVA_ERR_BAD _theoretically_ can be any random value 
that can make kvm_is_error_hva() return false, while kvm_is_error_hva() 
must catch all error HVAs.

E.g., if we ever change KVM_HVA_ERR_BAD to use any other value (although 
I don't see why this could ever happen), then using KVM_HVA_ERR_BAD in 
kvm_is_error_hva() would be broken.

In other words, it seems to me we should just use PAGE_OFFSET in 
kvm_is_error_hva().