Received-SPF: pass (google.com: domain of linux-kernel+bounces-87633-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
References: <20240223192658.45893-1-rrameshbabu@nvidia.com>
 <20240223192658.45893-2-rrameshbabu@nvidia.com>
 <20240228180520.5cea0f8b@kernel.org>
User-agent: mu4e 1.10.8; emacs 28.2
From: Rahul Rameshbabu <rrameshbabu@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Saeed Mahameed <saeed@kernel.org>, Leon Romanovsky <leon@kernel.org>,
 "David S. Miller" <davem@davemloft.net>, Eric Dumazet
 <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Jonathan Corbet
 <corbet@lwn.net>, Richard Cochran <richardcochran@gmail.com>, Tariq Toukan
 <tariqt@nvidia.com>, Gal Pressman <gal@nvidia.com>, Vadim Fedorenko
 <vadim.fedorenko@linux.dev>, Andrew Lunn <andrew@lunn.ch>, Heiner Kallweit
 <hkallweit1@gmail.com>, Przemek Kitszel <przemyslaw.kitszel@intel.com>,
 Ahmed Zaki <ahmed.zaki@intel.com>, Alexander Lobakin
 <aleksander.lobakin@intel.com>, Hangbin Liu <liuhangbin@gmail.com>, Paul
  Greenwalt <paul.greenwalt@intel.com>, Justin Stitt
 <justinstitt@google.com>, Randy Dunlap <rdunlap@infradead.org>, Maxime
  Chevallier <maxime.chevallier@bootlin.com>, Kory Maincent
 <kory.maincent@bootlin.com>, Wojciech Drewek <wojciech.drewek@intel.com>,
 Vladimir Oltean <vladimir.oltean@nxp.com>, Jiri Pirko <jiri@resnulli.us>,
 Jacob Keller <jacob.e.keller@intel.com>, Alexandre Torgue
 <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, Dragos
  Tatulea <dtatulea@nvidia.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org
Subject: Re: [PATCH RFC net-next v1 1/6] ethtool: add interface to read Tx
 hardware timestamping statistics
Date: Thu, 29 Feb 2024 14:20:12 -0800
In-reply-to: <20240228180520.5cea0f8b@kernel.org>
Message-ID: <87ttlqx67z.fsf@nvidia.com>
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?Gm+H22eaIN0oqYEg/9qa6Ia1WsHk9gGqv3kegjj2RE3DzxcmphoLQ63bJSRJ?=
 =?us-ascii?Q?RL91+jL8TlBpUTgA8wLEZwproqin633L236qN+RGPdG66xVCsTHfRWvwMjqW?=
 =?us-ascii?Q?psgXNKT4RT+0IrqR7NA9Nt77cm6Vy3CKZVXctkvMM1A19NIYQdkCFBDZNcYJ?=
 =?us-ascii?Q?IYlDKrVWPAmZWgWPAbVgR47IYsG3wkb7kYeAndDVIVg+crX4kFfaJ51cyaxQ?=
 =?us-ascii?Q?Q04XA/oHiBAHn7p8ko82JtPReIHoRm8xftKzHlfBZOIrs0+rWp2ww2nsS6+z?=
 =?us-ascii?Q?Tga316QVRgziNqHq8RCdSJKc/HsP1oCH2lEJ8vY0kfN1jnhVRuvmstQ+oHof?=
 =?us-ascii?Q?Y44DB5oih2G2scANLGYNKvxLmU34aZISgeV5e4iDGbqfiBRQPV4pd9TZeR4a?=
 =?us-ascii?Q?gqIOQ9D5L3DTYVqnaqmC/951t0VMuIjK8402+JOjGfqO35g7zoXXvHirB1iI?=
 =?us-ascii?Q?9VTWne8M5YeO4J0eeikgsHfDaUQcogSlocouKeh5PPiC56hHSIqoMncQXmLr?=
 =?us-ascii?Q?mwC023P9c8pGobDuhRZMB23Cu9D3xzRaBU889TzShKT8JgjwBUBtMm9SGl76?=
 =?us-ascii?Q?UgcMzXTbLCNYOF11MRJ/ynTNK14BcEhykZ+ZeC6QXUf1KS+M5M7PTUdEIgOt?=
 =?us-ascii?Q?FXBvUUVQBQyGded1USnJAowVBNDD1Y9XJ8SHxGg7gSbvvLoO55xlfEO0oOf7?=
 =?us-ascii?Q?NDeZH4KwYWyeRyw/ME9kk3JSmECQIPS0HXq9UPnhvAcloLCahdxVzWvS1hTS?=
 =?us-ascii?Q?rIeRypxoNbXiaJXUvtJxLxFWHDvNtpPmU207fzlofFNwjqvaZR4yzZ/xNafY?=
 =?us-ascii?Q?wgJGhLipDpOS7/JFEGkWH5iXgDbq39X/OwJWCRnGCCJpLtAwbbOESXyTG0N+?=
 =?us-ascii?Q?++KzIEbRlckm5kBYxCoEX2FAQ8X3wJ5l1AQ2utoOPXvQeOMEETD/dCI9tous?=
 =?us-ascii?Q?8p+Fu1m4tUmT7sQ1v+VvxzpeOzyilahRt3MND6Ldp4D6+Ki7MpSDmnDPWkUK?=
 =?us-ascii?Q?i5NlBHWj/pWiQe12zFWDQYajqbbwgWc97yleZS1wVVHbTH/7hTqs9qPevGdT?=
 =?us-ascii?Q?MFKFferxoQZ0XITPC8m24VAfMU5WEWQWQWdfgZG4kqwRL7lmz37df0QOxR9y?=
 =?us-ascii?Q?O+STWuas/Tfa6FMxUnC5SpZ+acVqadXF7X1cLqVgjhimUkxskbmQHrha8Nkg?=
 =?us-ascii?Q?EjRMRt3kiN6dCb01VSNqNxWo35GYnonBhGnRSWOmKhdhZ78vL4F5+CNGIXvU?=
 =?us-ascii?Q?NT/49v68pDyPRPj9vUFgVth+9Sov62d9luiIiogDMMePj2oPUf00a5JoiwQA?=
 =?us-ascii?Q?Q9ZSl8uxW8GLm4CGSsnAS2S2KcKTKGJddWafuXOZeFdh0km+nXgwgrxUjw1x?=
 =?us-ascii?Q?gkbHxZIzGoxMlEBpAU+K8U77YE16pS60dcUFSaKSUN5VidR+d50c0aS/0V75?=
 =?us-ascii?Q?2cCUbmgnmFuMSA8oED2btgeU7cC6+3xcwc34IrV4tB2Q/ioJisSFrg7XAqZ0?=
 =?us-ascii?Q?fiCavyeAVHFmELba/V6r+HJmron236qiy447ZHmKItKbzxS0obdtDBDGngjb?=
 =?us-ascii?Q?Ku6EgHXgf+1ZnbwBf5QAWoatV2yn4a3gpfgg78vPrCyz480cAEOLK1mA5vLU?=
 =?us-ascii?Q?kQ=3D=3D?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 05eb0a8c-1659-448e-c475-08dc3974afcd
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB2743.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 22:20:50.9580
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: b26g+M2FYsNCr3rgrkTDE22oDrvRQJWgpImOxQsBPjA/YTk/R8438DDX1FjiZJRjmXKvPQKqorDbzFmgKnB9tg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6543


On Wed, 28 Feb, 2024 18:05:20 -0800 Jakub Kicinski <kuba@kernel.org> wrote:
> On Fri, 23 Feb 2024 11:24:45 -0800 Rahul Rameshbabu wrote:
>> +/**
>> + * struct ethtool_ts_stats - HW timestamping statistics
>> + * @layer: input field denoting whether stats should be queried from the DMA or
>> + *        PHY timestamping layer. Defaults to the active layer for packet
>> + *        timestamping.
>
> I think we're better off attaching this to an existing message in the
> dump (using ETHTOOL_FLAG_STATS / ethtool -I), like we do for pause, 
> fec, etc., rather than having to build a separate hierarchy and copy
> identifiers within ETHTOOL_MSG_STATS_GET.
>
> Sorry if I mis-directed you this way.

No worries. I can do that in my v2.