Received-SPF: pass (google.com: domain of linux-kernel+bounces-87640-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <2237d6b1-1c90-4acd-99e9-f051556dd6ac@intel.com>
Date: Fri, 1 Mar 2024 11:26:00 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 08/16] KVM: x86/mmu: WARN and skip MMIO cache on private,
 reserved page faults
Content-Language: en-US
To: Sean Christopherson <seanjc@google.com>, Paolo Bonzini
	<pbonzini@redhat.com>
CC: <kvm@vger.kernel.org>, <linux-kernel@vger.kernel.org>, Yan Zhao
	<yan.y.zhao@intel.com>, Isaku Yamahata <isaku.yamahata@intel.com>, "Michael
 Roth" <michael.roth@amd.com>, Yu Zhang <yu.c.zhang@linux.intel.com>, "Chao
 Peng" <chao.p.peng@linux.intel.com>, Fuad Tabba <tabba@google.com>, "David
 Matlack" <dmatlack@google.com>
References: <20240228024147.41573-1-seanjc@google.com>
 <20240228024147.41573-9-seanjc@google.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240228024147.41573-9-seanjc@google.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?M2xIby8xTWdxbFBodkxIbHYxS1g4MXpOTm03emhSZ2ZuN0ZOQmU2R1R3MGxN?=
 =?utf-8?B?azZ2MCtqa0V5WDVIVDdJUjRrTDIxZFZHVEVqZzFNcDhGWUZCUFZZdVpIbE05?=
 =?utf-8?B?R0JSSTBLY1UyY1VmVG5OL042bFBkMnpMMm5ySk53amkvOHJJWnQzL3Y1eEl2?=
 =?utf-8?B?ZnBoSWlyaTVkcGxUem5GNzZ5QisrTlYwL2N1MjJOQzQyUWY0YVRYWkM3Z3M5?=
 =?utf-8?B?cnVUcTVhbHNuN0MwWVZGMmRleGpkbmdXSjcvRi9hdk1LSy9ha0FxVmk1Tllj?=
 =?utf-8?B?cHMvVWRkaUZMMzBLM3pibExNK0dCYXlvemlGano1MG9GeEVmTDMrQjNOL2tR?=
 =?utf-8?B?K0JoM3gzOERKTyt5WGgrL3VXT1pUb08xVEdBcGJBSjV0ZlJ0UjlkWi93c3hn?=
 =?utf-8?B?L2xEa1p4dVk3aVBkMnoybU1aRGZxWG9SVTBOQUpoQTFVdUZabURPS3FVNXRt?=
 =?utf-8?B?RHZzQlE2MkMzRGNtRStrM0pKOHM1KzJvOGtWdW1rZGQyaFFDU25NMW5OK1I2?=
 =?utf-8?B?TGh2S1hrOFc2Q1ZOZmZkMFhYeXZYMjRmSTVpQVNrVUxJbTBOcGRJS21aRFUw?=
 =?utf-8?B?d0swY01LR3NLT21pK2cxQ245Y01ET1VCaWZFSE1TUGI4c3JUeFRXR0creW1Q?=
 =?utf-8?B?K0MrRjQ2SDJjZWdCcnBxQnhDeDUyVi85ZmNUbTJmdU1seS84R25OaXBZK1VP?=
 =?utf-8?B?UUIyeXRHenFjNExyUjRmaVpycHQzdjhaRmpjT3VjZGJCcmozbnRQUjQyNC84?=
 =?utf-8?B?TXZ5ajVVdTdldHFJV05jck5IdGh5bFplWGpvOUtqdXpLcURKRldqbDM4QS9W?=
 =?utf-8?B?cjIza0RQL1RpQlE4Z3dXTjErdUp5Y2cwMVkvSXlJNGVUVTBvVVhMSlFrYlE2?=
 =?utf-8?B?Vjc2N05DWVRsK0gwMWRLcHMvOUhVZlhRQTRVSUk5LzdORGcvUy8zT3FLWEd1?=
 =?utf-8?B?a3YyN29FeWlTa1lkcm5HVElxQmpqY1BjcFUvdnRSZWJRSnUwZ3VaOVd6b0Vo?=
 =?utf-8?B?TTRjcCtBQjUwNlpWMGpoVTRjdksyZTF1aCt3a05XQi9FU0FsaDlVcGhZUGFD?=
 =?utf-8?B?NUZlcXNCOWxwRkYzOC9zQy9HZ2g4VmtlcGhIMUY1eWF2dG9YYmZXNm9hMFhU?=
 =?utf-8?B?Mk9ma1VUbWIzTlBSRzhwSitaSUVBbmNTVnIxYTlGZkhwOU00alNuRkZ2bXFI?=
 =?utf-8?B?c01vMDVrRzgzdndzVThHMXpac2MybXMrYWl0eWt1bDlyZDRqZmhNeXdzbzdV?=
 =?utf-8?B?ekk3N2s1aEx6M0ZCL1NKOHIvOTYwSmlVVXZvMld4Zy9mdEFSMjgvdyt2dVVL?=
 =?utf-8?B?Sll0bC9hVnpJai9tM1c5VTk3UHVmL0tuOGx6V0pway82ditZZ2hkRW9FYzBU?=
 =?utf-8?B?RDVLUis1UG5vNGJ3aS96QlZIdHlZRE9zL2NKZTRmd3hheGJ4a3h1dDQwMDRv?=
 =?utf-8?B?SFhoc3I5NG5lZXlqd1JQSHJETUxQaU1QeGdFN0lLaHJnYXZHSFZXVGY5Ynhi?=
 =?utf-8?B?bXM3Nlk0WlY1YjVOS1BPK29rL3J3bWJ5UzRYeFF2WmhvN2VhRURxaWFhMkMz?=
 =?utf-8?B?dG96V0xlWUVINko0S1B3ZDZPL0MyQkkxeVFWWWQzNjNpTitkdU5VVTluOFNW?=
 =?utf-8?B?WHY4R0VzNUhUb3VGbWt3OUJtSk9KZ2F5WHRJTitNZkpwRFpGMXdQaEZSK0NW?=
 =?utf-8?B?QjF0K241d2pBTDdvQ0gzc1RsQ1EzazRaaFl2S3UvbEJzMlViajYvcVVVRkFs?=
 =?utf-8?B?OWdiV2FOcTNRNHNDNHNDZm5CRW52Y1RQai9qTVNJRWJkWW9LQ2pQdFBQOUZS?=
 =?utf-8?B?ZUkyNjI3TVZ1cEdwRUozSlNaSTkzdm1uRTBSSTduYXhsMjRYdVFBNGJ2S01o?=
 =?utf-8?B?NzFZK0tHcUFaVTNyTC80L1paaklJVHQvT2lCUG1UbTRIR0I5eDd5WVN5a1Zl?=
 =?utf-8?B?K0NKazE2VUlPd0twbys5MnhROTJSSHhHNUR2bjN4dXgrSGtmempnLzhLNUVu?=
 =?utf-8?B?b2x3NWZuaktaaEluTHVNa0FadzR5MUhOenB3Ry9kRmVRSjVOWWwvb05mUGNu?=
 =?utf-8?B?bDhscXNtbngxLzcwd2l5OFZrYW5vNC93OEJMMkhrMDhURkVQL1p4NTJoRWZK?=
 =?utf-8?Q?bekbC3ftgqwRRuB9tWU7EXS8K?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 341050b0-1fb0-4aa8-70d8-08dc39756e0b
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 22:26:10.1393
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Fg7TBSR6NFuXU9fcbMQJNhNM0FILNJeLiirG+qJIFHz6vcMRvuikQVwpP8fOVKUv/KsICWciUFs9TpwDmibMuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR11MB6967
X-OriginatorOrg: intel.com


On 28/02/2024 3:41 pm, Sean Christopherson wrote:
> WARN and skip the emulated MMIO fastpath if a private, reserved page fault
> is encountered, as private+reserved should be an impossible combination
> (KVM should never create an MMIO SPTE for a private access).
> 
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
>   arch/x86/kvm/mmu/mmu.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c
> index bd342ebd0809..9206cfa58feb 100644
> --- a/arch/x86/kvm/mmu/mmu.c
> +++ b/arch/x86/kvm/mmu/mmu.c
> @@ -5866,7 +5866,8 @@ int noinline kvm_mmu_page_fault(struct kvm_vcpu *vcpu, gpa_t cr2_or_gpa, u64 err
>   		error_code |= PFERR_PRIVATE_ACCESS;
>   
>   	r = RET_PF_INVALID;
> -	if (unlikely(error_code & PFERR_RSVD_MASK)) {
> +	if (unlikely((error_code & PFERR_RSVD_MASK) &&
> +		     !WARN_ON_ONCE(error_code & PFERR_PRIVATE_ACCESS))) {
>   		r = handle_mmio_page_fault(vcpu, cr2_or_gpa, direct);
>   		if (r == RET_PF_EMULATE)
>   			goto emulate;

It seems this will make KVM continue to call kvm_mmu_do_page_fault() 
when such private+reserve error code actually happens (e.g., due to 
bug), because @r is still RET_PF_INVALID in such case.

Is it better to just return error, e.g., -EINVAL, and give up?