Received-SPF: pass (google.com: domain of linux-kernel+bounces-87659-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 29 Feb 2024 15:56:30 -0700
From: Greg Edwards <gedwards@ddn.com>
To: Tony Battersby <tonyb@cybernetics.com>
Cc: Jens Axboe <axboe@kernel.dk>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
	Hugh Dickins <hughd@google.com>, Hannes Reinecke <hare@suse.de>,
	Keith Busch <kbusch@kernel.org>, linux-mm <linux-mm@kvack.org>,
	linux-block@vger.kernel.org,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] block: Fix page refcounts for unaligned buffers in
 __bio_release_pages()
Message-ID: <20240229225630.GA460680@bobdog.home.arpa>
References: <86e592a9-98d4-4cff-a646-0c0084328356@cybernetics.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <86e592a9-98d4-4cff-a646-0c0084328356@cybernetics.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?X+jDuXpn8OEwuR4wCceIefpngnHDn57XtcSP9rgEH096CWXJCyYaSS/y+Pl+?=
 =?us-ascii?Q?ktX3WZQuIFqmM0wZeoZm5Q+DeNSu8+5sw8qqPa4DmH+5q/xxdvXXYLLOc/hT?=
 =?us-ascii?Q?a5anzYYQj0JreGOARNquW3XK5F2Ok43LrZEF4N8jZmxp2jOEpEUpU6gMRF/d?=
 =?us-ascii?Q?Y14iiFC1/Q/GC8iCnG8i38qXLGfyKGtiCSnGIIECj4sf/SEIuD8OtI053jgO?=
 =?us-ascii?Q?9LMNarnqNwh+SNlgo++gnAVTV+94DLJSS82v+9prusUyPT9h/wgSKbskXvvA?=
 =?us-ascii?Q?P+nbVlePStCD1lZFTF1zPmi2QMKv8LBv7GTxxIi2VBYiG6JdFyxyQ0mezhKG?=
 =?us-ascii?Q?XlXWNSeDkp7r8/PuS1Xfa3d8xDr9gk9tv67r55EnXW+xYlFxIOqCBvxbJLZT?=
 =?us-ascii?Q?ATtzimQttgttuXebXPgqHRR1bqt5hoIPeFQlMBkRn41hdWrmCc9aQ7DBhdsp?=
 =?us-ascii?Q?PH0z9Juf0vcnbfefbhzJvXSSj5g5PsZK9sjwBYhc9pZSGl7WiKiM38EqJoHB?=
 =?us-ascii?Q?g80BgvmidiHRgcEMn+gnqCnldkbFBv7wyDyvU61Ya2NFLV2WJvkQCe32xhS+?=
 =?us-ascii?Q?NS1nZCIvV4BnUctGsUab3JThWvmvPjym49jg3EMqJlATAylrWrgBi3hZrBeC?=
 =?us-ascii?Q?EDwrYu4IHvDF7j4Va1ikCKSclv4ZMNTR2XNDzdB6rUGQehE3ZziYvy2pp/i1?=
 =?us-ascii?Q?PSMuAb2irFNdeoFqsSkvLOm5f3eW9HB1z9RrcwPbPEAgnjGTCW4MdDpUl5g/?=
 =?us-ascii?Q?u0COkY3hkV507uH+hhrVBnvIfDCsvkjHn0uT9NnkUZ7LtVsTW4nzADO3BUh8?=
 =?us-ascii?Q?Nqg8jkd4+HmL7mTW6il5HQ2EmuwI2XwTdavxv8ylTFMAYq56ObhOIpGgVpF+?=
 =?us-ascii?Q?AqLFvh9nC5DUXybBeaOgo3cqnc5yzuuiVg6JuMnRMi/zYnxPkYTO9aLuIii7?=
 =?us-ascii?Q?poz9tXerrZF7RF+zULRehWM4MpVtULaeWEdTBoV8A/XAUWfoidsEPnCFoPac?=
 =?us-ascii?Q?ucnyN67eiCmmKwLOcWQAjiTsdCQTfLAfoVOB0J7FRWDN00fLSyPSWPN8+5Rx?=
 =?us-ascii?Q?P+U/+uZBVUyD9Sw/1vytHky3M7PjXEyTNL6KKq401IX03y1fc7AmdKhNlj2m?=
 =?us-ascii?Q?eccvwKPtZwE9w/nFjr89FWE2WR9oT13MFa+8lleQNj+qgj+BHO3zcSj5Hdtd?=
 =?us-ascii?Q?YwDsB99G8iQm88YVEox8mHP2uLguDKHIfy0RUp8kue+x1EPDwmi+9gZQdgmO?=
 =?us-ascii?Q?ijdP7dxD9t3e3+NF3WMMvez4LrQpvr8THxQuJ2v8oNjfExFCoWUpH/CFigQc?=
 =?us-ascii?Q?Fy790J8/6xfwl1wYhUdXuPLVWN1p4NNSsQ8HFKCDkcVnJwkFmqyNlHLmUqzk?=
 =?us-ascii?Q?qP4bzkGtWLza8Mp3W+ee659bdMyGNVlayx5/+Q/XQ1DJvkZfJehtv92GAEyi?=
 =?us-ascii?Q?Uj4W3tyi1OSkBshii9Denmy1hN+kchWQ3M+M1gosvY8HaJ1jlAzaoIwQzx+e?=
 =?us-ascii?Q?dxnS1u4oJWkEwbxrctY21VSNIHIkk1IhZXT0Sexc96aStskkTZipE2fJYLva?=
 =?us-ascii?Q?u1BbKG3udbDq/imVZfat3jrSH865lGK4CSo6BhHo3BrzxolBI2/NmEteUQoL?=
 =?us-ascii?Q?Lg=3D=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	KS3zk2lQm4+KKSWN7jl5Re8wZt1KZKR5/yv7I4VH+mgZWZoeKkpwvk6HAMFVs6lRDhrwIiQd9Rsyo+E/sq1hGCxxMdb7gWl4apa0tZ2FuPy6KiUwhKOWAMvKDitWFfzkrHKltTs1Fmt3a/J9SrP41Pf4+Q/BMmsxt9mbiG2qWiXevdRHIPIsYFpuMPru+fWAfZYLdN8UYaERa0LrhtFQHeACGJUMPV++lbqsf1rgzrWjU4Cna9y9PmbGNxTUrXQYrq0UTvjGbfgRoLWSiNMEfzJoqFp3jUgvAxbTs158vW87EikGaoKqhhp+lMbn8yuzYB/4Zdyi0n9NXZi5K2LJ9NobsqKVxRNqFFCrZpQCoBN7oznLgUSQbuABN9qUZbBuEd+cqgxj7vE5U5ExEY7dHBl82c4zZ/oDr2/xRWVwYpk6rPPEezxNoqTfQ+gRj5l7WtBKgfdi4/IAS6D889jckWnxUB/CcIGHgxFwtaoKOo0rYD14aziW48NZxmQ0n3AWiWC2Iaz35RhC8lBNW3StpgQo82Jcjk7uiq+7JLG9eUIhSaSBXY2RzDX0Ljvh4BOIZ66SGdoH/MyqqYpDV0fZka3K/kB4BlbR954sLHft78SJ8nhyjrO5+kwwrlPidHox/Py1bgbkuqFg7Sk6qqrB0A==
X-OriginatorOrg: ddn.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 94cddc09-0e81-44cd-cd4d-08dc3979ad73
X-MS-Exchange-CrossTenant-AuthSource: PH7PR19MB8187.namprd19.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 22:56:34.5402
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 753b6e26-6fd3-43e6-8248-3f1735d59bb4
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: a7C85DpNcfUnWb7yXU6rIkR6vAzlD+KzTxTsMizwj6nmfnkdW8wzNZvfNSdb82kgVc9MiOGTSVhvqMs7kqwiEA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR19MB5704
X-BESS-ID: 1709247399-111735-7444-3003-1
X-BESS-VER: 2019.1_20240229.2154
X-BESS-Apparent-Source-IP: 104.47.58.101
X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVmZGpkBGBlDMzNTSyCLJ1DA1zc
	DQ0DjJyMTM1MLc0DjNwtDYKNnC0lKpNhYACwxRaEAAAAA=
X-BESS-Outbound-Spam-Score: 0.00
X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.254560 [from 
	cloudscan19-59.us-east-2b.ess.aws.cudaops.com]
	Rule breakdown below
	 pts rule name              description
	---- ---------------------- --------------------------------
	0.00 BSF_BESS_OUTBOUND      META: BESS Outbound 
X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS124931 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND
X-BESS-BRTS-Status:1

On Thu, Feb 29, 2024 at 01:08:09PM -0500, Tony Battersby wrote:
> Fix an incorrect number of pages being released for buffers that do not
> start at the beginning of a page.
>
> Fixes: 1b151e2435fc ("block: Remove special-casing of compound pages")
> Cc: stable@vger.kernel.org
> Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
> ---

This resolves the QEMU hugetlb issue I noted earlier today here [1].
I tested it on 6.1.79, 6.8-rc6 and linux-next-20240229.  Thank you!

Feel free to add a:

Tested-by: Greg Edwards <gedwards@ddn.com>

[1] https://lore.kernel.org/linux-block/20240229182513.GA17355@bobdog.home.arpa/