Received-SPF: pass (google.com: domain of linux-kernel+bounces-87668-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <a43feb58-5fa2-4b39-8aa1-04085cd5a8d6@quicinc.com>
Date: Thu, 29 Feb 2024 15:15:04 -0800
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v2] net: Modify mono_delivery_time with
 clockid_delivery_time
Content-Language: en-US
To: Paolo Abeni <pabeni@redhat.com>, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
        <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
        Andrew Halaney
	<ahalaney@redhat.com>,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>,
        Martin KaFai Lau <martin.lau@kernel.org>,
        Martin KaFai Lau
	<martin.lau@linux.dev>
CC: <kernel@quicinc.com>
References: <20240228011219.1119105-1-quic_abchauha@quicinc.com>
 <2fc6a4f7ea0308626cfd06d95564486d187b16e0.camel@redhat.com>
From: "Abhishek Chauhan (ABC)" <quic_abchauha@quicinc.com>
In-Reply-To: <2fc6a4f7ea0308626cfd06d95564486d187b16e0.camel@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit


On 2/29/2024 1:30 AM, Paolo Abeni wrote:
> On Tue, 2024-02-27 at 17:12 -0800, Abhishek Chauhan wrote:
>> Bridge driver today has no support to forward the userspace timestamp
>> packets and ends up resetting the timestamp. ETF qdisc checks the
>> packet coming from userspace and encounters to be 0 thereby dropping
>> time sensitive packets. These changes will allow userspace timestamps
>> packets to be forwarded from the bridge to NIC drivers.
>>
>> Existing functionality of mono_delivery_time is not altered here
>> instead just extended with userspace tstamp support for bridge
>> forwarding path.
>>
>> Signed-off-by: Abhishek Chauhan <quic_abchauha@quicinc.com>
> 
> Since this is touching a quite sensitive code path, I think v3 would
> deserve some paired self-tests.
> 

I did verify the existing so_txtime selftest for the same which does FQ 
and ETF tests which sends/recieve packets with both mono and tai clocks. 

OK. All tests passed (so_txtime.sh) 
Sometimes i saw resource temporarily unavailable in RX which i believe is a 
known issue 
https://www.mail-archive.com/linux-kselftest@vger.kernel.org/msg06792.html

Along with this i also did mqprio + etf offload testing on internal platform. 
1. iperf3 best effort testing UDP/TCP 
2. Sent ETF packets from userspace application just like so_txtime.c but 
with SO_PRIORITY and added dumpstack to check the flow of packets. I saw no
issues on internal platform.  
3. I will mention all the testing in Tx/Rx path done for v3 patch. 

> Thanks!
> 
> Paolo
>