Received-SPF: pass (google.com: domain of linux-kernel+bounces-87695-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Fri, 1 Mar 2024 07:01:58 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Linus Walleij <linus.walleij@linaro.org>
CC: <arnd@arndb.de>, <guoren@kernel.org>, <bcain@quicinc.com>,
	<jonas@southpole.se>, <stefan.kristiansson@saunalahti.fi>,
	<shorne@gmail.com>, <linux-arch@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-csky@vger.kernel.org>,
	<linux-hexagon@vger.kernel.org>, <linux-openrisc@vger.kernel.org>
Subject: Re: [PATCH 1/4] asm-generic/page.h: apply page shift to PFN instead
 of VA in pfn_to_virt
Message-ID: <ZeEM5gBd/eigWreZ@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20240131055159.2506-1-yan.y.zhao@intel.com>
 <20240131055740.2579-1-yan.y.zhao@intel.com>
 <CACRpkdZ_XUmW__y=8R3aJkci+h-pHRh8-xH7ZmfRyQ=jjCbajw@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CACRpkdZ_XUmW__y=8R3aJkci+h-pHRh8-xH7ZmfRyQ=jjCbajw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?MFBvWm1rTWlRUUZnd01DVVNQRUZKMTJnVTBxdHFjOGloOCtGMytSem5leFo2?=
 =?utf-8?B?OUFJcmlLN1NIZUhKQWZWdkNjRXBxWmw3YUNDSFBUam5mSUtRRmFSZVZudDQ1?=
 =?utf-8?B?blhTSTgvV3B0dEVzaXBLZExucFZyZDFZZ0twdG0yOGdrRXFRd0M2dFI3Mmts?=
 =?utf-8?B?NVB1VUpMWmRpanhpZzQ5Mms5M0Z2ZE1kb05XRGZTU0c5c3llV1E1YWNNbDlB?=
 =?utf-8?B?cWRSd2s3cEtRTWRJTHNZQnAvb1NHZzI2RFdwcVN1ZGo4aWFtSDRscXgzNkdh?=
 =?utf-8?B?NC9kUDRsT0I0Y2JMWU9aUCtpYVNtMHQ4WkJlRmU3dHplMXVCTzY4WVgyY3V6?=
 =?utf-8?B?K2hUT2cxbXRSWWdJUHZjRmtDYWJDY3l6VXpQMTdPajcwMmprR0xGUXBraWxX?=
 =?utf-8?B?Nll2VGpyR1FQUzQ2RDBCSHVhV0t5Z29jQ1lFcnBIUzlWeVJoQlNBZHJPeHZC?=
 =?utf-8?B?RDFtKzY4NUVXREh3S3huZUhKdmhMbi85Y09mbUlPQXM2Ky9WSnk1SmNteUJi?=
 =?utf-8?B?aTFIVXZuc2d2aTVVa2FOYndjQmRWY1JQd3RnK1VmNjJPeURlMTlOTnBJTnFh?=
 =?utf-8?B?cGJGTTM2bDM2WDlJY2hxUEgzMCs0OG41YmNvci9vL2g0UU1EdDJXQzM1cmF2?=
 =?utf-8?B?SEZYdGhtbk9zbDdqZmJ4TEdVd1RlbFpLTUFoQ3ZmRWwxRGZ1a0N5K1ozSmtO?=
 =?utf-8?B?Smc5V1ozQXJGamtFVnJYUVZVSlNqS3FmV1VWV2IxQUNnY1ZJZTFwVDJLTy90?=
 =?utf-8?B?WEdoMUs4MUtPWGtTSENqS2lCZHhDaXlrc0YrNVRJS1VjbzVxNGJUNk16SUhi?=
 =?utf-8?B?Vk16SzdQRDMrTEtjWEdXUTdUOE9HbVRoaTVIdUJ4OHRLRjJqT2FmOEkreWhK?=
 =?utf-8?B?RzM5eHlPR3dkWjBEMUJFYVBRWWUxaWlVOCt6TWNOdEVNa1Q3S1IzRVRzcDMx?=
 =?utf-8?B?VUFxcmw5ZlRsVytGbndyT09tS3hyMXU2RUVMT25DbDdDN1dGbDRUaUdVWWt6?=
 =?utf-8?B?U1JtZTdIQnhVSkhrZWN1NnNhVCtvVm9SSURLbzJTTTY4L2FNSmtTUWZqalBF?=
 =?utf-8?B?YUNEWkRTZURDSHF0YVBWeTFZNVN3ejlQYlRIMWFOa3V6R0MvMWE5c2pTVGhp?=
 =?utf-8?B?U1BQdXU4Q2Z3UVBBVy80c3ViRTJZNG1kWURCcjVYZ3k1QytoaVU5aTJiZUxC?=
 =?utf-8?B?ZGx4STBPYlhhQkhwTDNGQTBwYlVXZW5ZK1h2NFVSVkhhdmpVRGxEL1RXQ05a?=
 =?utf-8?B?bUlBYlE0TmFMMTJxek03QnNOSGJHOWpkMFlSMzFORURkaGFKQklVMEFwaWdM?=
 =?utf-8?B?c3dLay9DTGNWQVNBTWt0TVY1VXA4ZnEwbFpWN1Jlck5WQTBBaTA3OUpPVXFD?=
 =?utf-8?B?OHBSeFdldTFLTWRpVzBrNE5MRTNSOVhaMWR0ZlNSZmNhdGs4WHBUYjh0Mzhw?=
 =?utf-8?B?ODF0Q08zVEFmY0lZaHo2L0oveEpJc2RoZTN2S0ZFZUlYSzhsb1RFd0puUzBk?=
 =?utf-8?B?VzlJOS9TMkxOcVdJT1czdnNkUlpiRy9Sa255ZWx6bERxS2tidlJMNVJvd3p2?=
 =?utf-8?B?ZmtkOVRVaVR1dlE2aUFzQzZZRmZNbEdHMVRmL3RrZXdaWUQwM1lieUljTith?=
 =?utf-8?B?clVQZ2ZQMTczaGwzaXVsMkJRWUhGc0FvWFlML3c5bVhXR3YvVVBIb2hyMkR2?=
 =?utf-8?B?V3JnL1h2WHM5Mnk3R0lybzJ1WkE5clM2UVV1MkdkL1lPMWR0MGFZei9GOUFJ?=
 =?utf-8?B?UG9NV2RDN1p6NGVLV3RRbVlsMnhrS1dhcEF5VEFFTFNuOE1Ic3ROSHJUS3Zp?=
 =?utf-8?B?V3E0KzIwR1I4OEMvSVBjSDRxcWt4dGVVaFBBYlNPcnVrbkVqdnhIS0hldjBZ?=
 =?utf-8?B?YkFyZDF1b1dlNkVxbG41WWs3aXZHWStiSEV0VHdwRHZYU1JtaWZUaHpqcFNZ?=
 =?utf-8?B?QTNHOGw4YnZGd0IvM2VoU1htRmNlZFRXZHVtZ0hkdWlJb05EbDdJUzgzR3la?=
 =?utf-8?B?VW5EaUc2K0JnbjFURkVBUkxFZk1uL0RhSUF2bzJOUVBNdTR5WFU1eDVWRzEy?=
 =?utf-8?B?SnM3VzNTaStmb1hpSjRhNjRnR0YwV1BYRDEwbUpoUERnZmMwSmhCVkk5dEwz?=
 =?utf-8?Q?jmXN8LexyCf9nRv1l+Wjwxed1?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 70ff02d2-5b55-4bd7-3733-08dc397e97b5
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 23:31:45.4845
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 17konkrdqvmeX5mB4bcmerl8LiuQnWDeA1ohf9cDdWW3ExhQambPTILQx8xrLsNlevk7rEnuO4uts6uYqWs71A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR11MB8152
X-OriginatorOrg: intel.com

On Thu, Feb 29, 2024 at 02:34:35PM +0100, Linus Walleij wrote:
> On Wed, Jan 31, 2024 at 7:27 AM Yan Zhao <yan.y.zhao@intel.com> wrote:
> 
> > Apply the page shift to PFN to get physical address for final VA.
> > The macro __va should take physical address instead of PFN as input.
> >
> > Fixes: 2d78057f0dd4 ("asm-generic/page.h: Make pfn accessors static inlines")
> > Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
> 
> My bug, obviously. :(
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
> 
> I thought this was already applied with the other fixes, but maybe it
> was missed?
>
Hi Linus,
The other 3 in csky/hexagon/openrisc should have been applied in
https://lore.kernel.org/all/20240202140550.9886-1-yan.y.zhao@intel.com/.

This one in asm-generic is not, because Arnd said he is going to remove
the header as a whole soon. 

I explained it in the change log :)
"The pfn_to_virt() in asm-generic/page.h is not touched in this patch as
it's referenced by page_to_virt() in that header while the whole header is
going to be removed as a whole due to no one including it."

Thanks
Yan