Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp220306lqc; Thu, 29 Feb 2024 15:38:28 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXTjou9iwyI/23BgHkjHLu5KFTeSOVyH/8PGGA/GFUaU5ycOCGKVBn/Mf1kr2nexmG2mN8l/Jz0xlpvfE1U2vI0plyJZUYYM5FMY6bAbA== X-Google-Smtp-Source: AGHT+IGf6Hb34249UWNveHUkUcFZkV/7Hgu6uauP0IiG169BGRKUpj/4tJxh99Wk5DoGuKhRImsk X-Received: by 2002:a92:c569:0:b0:365:c6ae:c40e with SMTP id b9-20020a92c569000000b00365c6aec40emr223704ilj.0.1709249908073; Thu, 29 Feb 2024 15:38:28 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709249908; cv=pass; d=google.com; s=arc-20160816; b=BMdAG4uheS2BfTPIjvZJw24E808axGs7m+dIF7lArpBwvFsHZFOSQoUTP5MlGKXq1e jkyoHMMM/mD2AzuBdLdEiIGqFVFUr4G0y4toaMe51YjNOMw4LOWydG0yjB25OJ9UPEoC edba8rFTTYrupPt/NvAuNxLRPeLqWNHBGLFy5J+a4PQedlfxuRofTL15CgKMO35Xt4sy Aas3jlC8p/ntAziPP+WNkrL83F2YCaqG9lEXRzPAbqesNGFFh1/N/P0+zFJn2al0dRjS CklBXtHPjfB1oP6PfRGC56PGXeAt1SwQds61QFnKPNE6xt1o0hO62OXgBv5TsItNkG5w 6ovg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date; bh=Qk61xVLxzXqoboOWffa8awqdz1v/v/4rgvWM5tnE/dg=; fh=ta7HX2H218sANQBNTnTGD11KRcq3Cd2gLKTdqexirrc=; b=pXkQSSp2wlcNX/Fb4bYjcu1gEJ1TDkWdJzcaAF6eqyNcTtTyU/agFhAl14kmL+NFRY OXi82glbE5dtpRwQ9UDGc/2bsM3Tbp20X8Y4PpHr/D4WZ/nijpkB2HUMW7hekR3ZvzAx S7pxob04Ks1x7+pPEKxApytRasdffxl6/FgV7BIX8cY6NtWzDOOKSpaSdco9z5ljWWbf ne6SWEF2nmYH2XdbSgX+QNma52/jtRpcLqFoW7O2qyNGrdCLeOhdA8Rf7FfxeewVn60S +k/nwY+ZrPanX5p5fCYx9peHhwQtLz4NcH+jBjniU1tumYBkVb8HqJHgOaXsqFRP530O 60xQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-87702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87702-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id l187-20020a633ec4000000b005dc88260f76si2359626pga.330.2024.02.29.15.38.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:38:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-87702-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87702-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id BC460281E9B for ; Thu, 29 Feb 2024 23:38:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D0B2C7C095; Thu, 29 Feb 2024 23:38:22 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD1B17545 for ; Thu, 29 Feb 2024 23:38:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709249902; cv=none; b=L/yJQvyjaIKBvzbGc822HMZaoTnS63ewu+z/tKVtVeZWYsEpLmoYdJ9dvkPNF0NsgxvFKiH7+66/SBaZKaaUofr85aXXERWt5S7udhODhuJ0zWRuCmxNQpZVPhCiolAmF0/mti3pWa/A6sVXZAaRLzy6FO72UbXv60sCaHiMN94= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709249902; c=relaxed/simple; bh=JxabirRy9sp8zBzir1sOeWwkxxHBQdkLBmgQvc4b6/s=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kbss4kwDC7MEMZn9yHXWp43WED5wvk3yZn6wspk0i82H+6ODV/uihYFUiZB4OXB1BUxi/Q2RMg6lgtfGiJFBjVG7Em+6lE8/kENfShRn9wXnFHHOUJuWXHxdDSHEvIOlVaf6cb0yEtL4orepqcckRfoCxxfKrd8W20kBpkbVDP0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8CBD4C433F1; Thu, 29 Feb 2024 23:38:20 +0000 (UTC) Date: Thu, 29 Feb 2024 18:40:27 -0500 From: Steven Rostedt To: Josh Poimboeuf Cc: Josh Poimboeuf , x86@kernel.org, linux-kernel@vger.kernel.org, Peter Zijlstra , Vince Weaver , Dave Jones , Jann Horn , Miroslav Benes , Andy Lutomirski , Thomas Gleixner , Masami Hiramatsu , Nilay Vaish Subject: Re: [PATCH v2 06/11] x86/unwind/orc: Convert global variables to static Message-ID: <20240229184027.45609c0f@gandalf.local.home> In-Reply-To: <20240229004252.awmammhp63f5udyy@treble> References: <43ae310bf7822b9862e571f36ae3474cfde8f301.1587808742.git.jpoimboe@redhat.com> <20240228183507.78c5f130@gandalf.local.home> <20240229000309.ibtuk7gr27d7cbxz@treble> <20240228191406.21e894b0@gandalf.local.home> <20240229004252.awmammhp63f5udyy@treble> X-Mailer: Claws Mail 3.19.1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 28 Feb 2024 16:42:52 -0800 Josh Poimboeuf wrote: > DWARF isn't needed for that. Even the symbol table has it (as does > System.map). For both globals and statics. Interesting enough, it is reported that if lookup_num_blocks is global, crash returns the proper value. If it is static, it just returns "1", which is incorrect (the correct value is around 60K). -- Steve