Received-SPF: pass (google.com: domain of linux-kernel+bounces-87712-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <3be03f9e-53cc-4b40-9933-5bf59db84477@intel.com>
Date: Thu, 29 Feb 2024 15:56:36 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] x86/mce: Dynamically size space for machine check records
To: Tony Luck <tony.luck@intel.com>
CC: Borislav Petkov <bp@alien8.de>, "Naik, Avadhut" <avadnaik@amd.com>,
	"x86@kernel.org" <x86@kernel.org>, "linux-edac@vger.kernel.org"
	<linux-edac@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "yazen.ghannam@amd.com"
	<yazen.ghannam@amd.com>, Avadhut Naik <avadhut.naik@amd.com>
References: <20240212175408.GIZcpbQHVjEtwRKLS-@fat_crate.local>
 <SJ1PR11MB60830AF35FA89C7869B8C11EFC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <20240212191401.GLZcpt-XHFqPg3cDw-@fat_crate.local>
 <SJ1PR11MB6083C60D7584B02E9CAF19D5FC482@SJ1PR11MB6083.namprd11.prod.outlook.com>
 <ZcqPhVO_DtD2x5N7@agluck-desk3>
 <20240212220833.GQZcqW4WxKH34i-oBR@fat_crate.local>
 <20240212221913.GRZcqZYRd6EPTTnN97@fat_crate.local>
 <20240212224220.GSZcqezMhPojxvIcvO@fat_crate.local>
 <Zd--PJp-NbXGrb39@agluck-desk3>
 <015bf75e-bbe7-44ea-a176-9f1257f56b81@intel.com>
 <ZeC8_jzdFnkpPVPf@agluck-desk3>
Content-Language: en-US
From: Sohil Mehta <sohil.mehta@intel.com>
In-Reply-To: <ZeC8_jzdFnkpPVPf@agluck-desk3>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bHJRS011N2M1SmNXUlYyVmR6SW9TTzZCTHdiN0tyYVEvRTFRMUF6bG9QczFV?=
 =?utf-8?B?Nmh5TEpRZVVpa2l4SUZoRUJ6YUxlS3VvOHNTbEZ5WndEUDk2TVlPRXJ5cTlo?=
 =?utf-8?B?RDFQcmJpSVFlOVRPUWhKb0VyU0xHZlhXZzlNSmQ4d2RJZmMzeVpiSGRGQmJD?=
 =?utf-8?B?YWJ6L1B4NVhUd2RwVFZRdVpRTzJBRVU2SzJ0aTdnOGI5eGxPalVtUnpHYlZS?=
 =?utf-8?B?c2VyOWluTDk2MXdGblI1UmNOV09qbEM2bEdUcGhPUmN6MmFLYU9mRW1jMklQ?=
 =?utf-8?B?YTVZalJ1a0ZZNk5GZWZxTEZQbThMcDAyWjRhTFRnSDlqWFlFdkZmakY4eDVh?=
 =?utf-8?B?bXgvYXE5V3BjYTcvT3BlclJtbVVIa3ZMaEVKei94SGtXbWthWWk2RkZpRnJP?=
 =?utf-8?B?eFhDcXB5c2tiMktRNjkwb1I4M1RHdW02WlR2Qk1xcFJUTm10V1VBV3hPK1NT?=
 =?utf-8?B?M0VvMHVzMytNRloyY1BxMXQrbG80Kzlnak1YVkM1WU4yZGxEQVl5WEFNSWl5?=
 =?utf-8?B?ejh2eVZGc2ZXN01QbUZrblUwQ3lhSFRDWTBqTklqR3lOZ0E0K080UjE4RFZp?=
 =?utf-8?B?azF6TTAydVhwclVxMFloL0ltSHM4dUpSS2NuQ0hnajE0L0JFZjVkYTc2QVJo?=
 =?utf-8?B?ZEdlU240TXd5WCtXOG9hc1RKRktZa05nd2tYcEFhNmZjL25UTTBmN1Y2N2Nh?=
 =?utf-8?B?N1krR21hbG1wZzg0TzhqOXZFNlE3cW85cTNXK3d3T1dJSHpNM29GbVBjdFRM?=
 =?utf-8?B?V3psUXNFNUJIQWk1bnZvMVBTcWpIZFAwd04vRVQwTWptOHphRWl5T3o4b0Y5?=
 =?utf-8?B?UEZiZnZjVXJxSmNkVklwbXFKUUtrdDNDRXlnVHVuR0V5bTBKbEhzTkx2UFlF?=
 =?utf-8?B?VHMwbFVyVGV1b05nMnZjYXlaL1h1TDYza29POXdvamlDMVRUdnNLRlFXZjgy?=
 =?utf-8?B?V3VSU084dHA1NVlQQW4rSzhWeFI5b2VtbEFYSlpBcFo5YmJ3RHl1S1hwUkNS?=
 =?utf-8?B?MGxwVFRRT0dXT1FXcTg1M29NbVRPYzcrZXNid0ovTDV0aFljSDdlVURpazRh?=
 =?utf-8?B?QStYWHNTT1AybUVnK0xmOEw5WDBwQVVXNWdZYmNCSGc1VVN0Ly80ZmJteUQ5?=
 =?utf-8?B?aDdGV3BTNFUwc21ocFdpWTRYaGxrWStFNldjVXhwR0ZyOE9OYWlzMTJQV2lW?=
 =?utf-8?B?R1dKUy9ycGYxVm02NkxJV0g3Ny9XYjlvc1FjdTlUZUQ3YVR5RDlMRDBKbWhi?=
 =?utf-8?B?Q0xITnlZR29TL09sd09vOWVSUHVXWFhuOEVxemhveVpMSDRMWncxVXRkR1FL?=
 =?utf-8?B?Nnc2Uzg0b0IyT1FXZlhjaGNOUUFUUS9pZFBUS09yWFYwdk5nNzMvcTF5ZVAx?=
 =?utf-8?B?c0FBQWtQZzB3T1p4WXFEME1NQTl2Qjk1RER5Q3U2SGtORW1uSzNxSTZUc2JG?=
 =?utf-8?B?dEM4dkYwYTVWUXJXd2NwTEEwUTBHSmtEaDU5bjAvM2ZlMmx3aXQzT1pkWUFP?=
 =?utf-8?B?dkRKQ1lGcEhSN2I1c2Q1cGUwYis3QTNIWHdBLy8vVkN4S1d4aXpjaW9idmpH?=
 =?utf-8?B?Vk1WaSswa245R1lwTDNVRjVRTjRyYnlwOVJYWWFuNkRUR251NnNjdG9vVGs4?=
 =?utf-8?B?SmRIZFk0bzRnMkVKZkt6R2JPTXRDOTYrc1Urdit3aTF4eTJtQXkyaHU2cjVx?=
 =?utf-8?B?Ymg3MWluZjNpMkQvU0cwSkZvdDVXRnJzaHMxVm5QMUtGUlhHRnEwMTNFZ3NV?=
 =?utf-8?B?d2hOMjQzMlZHRjlkdjJhbStzbVJYSkJCUG5yVmRPRXZkWkZmU3ZFQXVJUjN2?=
 =?utf-8?B?cTR3S3ZqTWpBZkZIREpUNGc2TmpIQ1NSMDRoS0Nhb3RsLzZVbkI2dnBPZ1ZG?=
 =?utf-8?B?TUkzZVJ6ZVErbDZqQlVYS2kycnhMMWZWbmM2QzV6cmNLN21CdVo2c3dtUUNJ?=
 =?utf-8?B?aTA4QWR1Ti9RSTIzZTlVcHU2Q1NSa283bzdmS01lUWlIZXNCY2VYYStxZ05B?=
 =?utf-8?B?Z3ZmNnYxMDMvcUNvN0tTRE94d1lrbzlCckVEeWpPOWUvaW96VFRVekwzd3FZ?=
 =?utf-8?B?SG03SEorcmFmK0RMMWg1dXVaNGhWYVJ1ajlMLzVMMVUzclVFU1dHcHV4V01U?=
 =?utf-8?Q?pzdng1SAKNNAzkNz6cq60iMtt?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0d8e4753-b803-442e-f6d1-08dc3982118a
X-MS-Exchange-CrossTenant-AuthSource: BYAPR11MB3320.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 23:56:38.3699
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ERQgPVEelLTM8kI2X9J65rgUihT3kU7UQ54lb/KS+pybITwj/ReZwoez7U/mhOItSDnlM/jts4HBW0l++puIWQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5250
X-OriginatorOrg: intel.com

On 2/29/2024 9:21 AM, Tony Luck wrote:

> Looking at this specific case, sizeof(struct mce_evt_llist) is 136. So
> the original version of this code picks order 7 to allocate in 128 byte
> units. But this means that every allocation of a mce_evt_llist will take
> two 128-byte blocks.
> 
> Net result is that the comment at the top of arch/x86/kernel/cpu/mce/genpool.c
> that two pages are enough for ~80 records was wrong when written. At
> that point struct mce_evt_llist was below 128, so order was 6, and each
> allocation took two blocks. So two pages = 8192 bytes divided by (2 * 64)
> results in 64 possible allocations.
> 

Thanks for the explanation. The part that got me is that I somehow
expected ilog2() to round-up and not round-down.

> But over time Intel and AMD added to the structure. So the current math
> comes out at just 32 allocations before the pool is out of space.
> 
> Yazen provided the right answer for this. Change to use order_base_2()
> 

Yes, I agree. order_base_2() is better than doing ilog2(struct size) +
1. In the rare scenario of the size exactly being a power of 2 we don't
need to add the +1.