Received-SPF: pass (google.com: domain of linux-kernel+bounces-87729-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: Dongli Zhang <dongli.zhang@oracle.com>
To: x86@kernel.org
Cc: tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        dave.hansen@linux.intel.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org, joe.jin@oracle.com
Subject: [PATCH v2 1/1] x86/split_lock: add the source of exception to warning logs
Date: Thu, 29 Feb 2024 16:15:01 -0800
Message-Id: <20240301001501.35592-1-dongli.zhang@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?us-ascii?Q?QtTIrEYEeXETAiowvgWLig6HJqNLdkYkWUApPOq+1FlrlTwzqTXGrBQb2+V0?=
 =?us-ascii?Q?988qVTX9srJDZt3Hm1/Yw+l+35ctAY7PJpfuPMsL+WR8j1mc1459JqWxWVO7?=
 =?us-ascii?Q?tcZWDZOO2Q+WAp2ktu/lqfriebyZdU/JaCoMigswHcTHgqFGLDoqclU59zXb?=
 =?us-ascii?Q?tnMfNorKryiK0UpN1tPYb8uAVJ9O4tbAzveWoWWwwNYpSCiyV+aKqy/bQRCR?=
 =?us-ascii?Q?U5/Yyl2gTHLtPH5jIx7oauFOHGv7FAfHhEVFpdLSX8/OyKz/4kBGDJyLnat2?=
 =?us-ascii?Q?cIDsbzHK94ws0Hhfb2haOQgdzc0eigiqop3/eECbhkQkFqkPQmzM5WxlrFLU?=
 =?us-ascii?Q?azGnfZUlrrp6jaJb4+jb8weR0DWPl9Qm7cFovUtd17Q79Tkfp72m6ctBRefg?=
 =?us-ascii?Q?IoXccgggg08s46EtXPGf3Pn0OWchlAHEzKnbuqHjN4EU1+B6UNRPokCZPmZY?=
 =?us-ascii?Q?g6mAVTS9ReaW1rrw4hGMDb/ZY9kyEJ7RLPMFZg16YuKtEieUl494u/6w7rpO?=
 =?us-ascii?Q?9zLCwYL63i5NpJ4Y9adnE2sbN8XiX7SrdxxGKFBgLOerh1YlaALvnJhrgMN/?=
 =?us-ascii?Q?MnoWZ9l2BA6Yf7vNEksWgjBafhKgD6SMGaZ6v7E9IjR8zUPDxkMiLihR8Rnw?=
 =?us-ascii?Q?w3SD4t1ijNKpippo14M1XMRgEHqa2V0/SeJcrcXpNSJigcZ3uxO+fZa/qEkc?=
 =?us-ascii?Q?h41wXvOd2qrAmOCysj0X9yW8Lzr6UYSTUcJ64QYy4aIlfA8IF/+jh/SL743J?=
 =?us-ascii?Q?cMbiM0zLcMey+E4TU7ejUYIE3fpB8q02qn4VIiKCEhwybqsJyIlf2oJt9cx5?=
 =?us-ascii?Q?OQUUZ7sb/HoVWjQoj+aUHDy2fiYgUDpMXFeKhRDxFdhgzWAayHa+rD9IN6DQ?=
 =?us-ascii?Q?l1I7dXCacSwBYyQRA4T7MnbMlK20s/PzC0rn3BOgfQrRKVQp4QvNLY3/Krz8?=
 =?us-ascii?Q?K/v54Mk81Fzi9yKghjoPLvM9/tvodd0qJFrZrzcFSzdJg1MBHKqOVZAi/KvT?=
 =?us-ascii?Q?JCIF3fdsUAOIByQlIV+iZzbqshjS2tBADBwq2T4pLfdKktcKk1GyBB+PCiS8?=
 =?us-ascii?Q?uyory9jy/6qJrZb/pkaQq7RBGJJpOcKM87hmDHy5otMrC65s5yN8yjEDV2tY?=
 =?us-ascii?Q?AISMoY+V9XmCrtaMnw7AV7M8b9gcGzIGqkigPAIYhBvtqVYnCYHic/JBHsQk?=
 =?us-ascii?Q?SL9De3fs3jZ0JfUwLVfBrZV9GTnwGH2THdpCJsH9z+GFA7kEiGyKV4J35E+t?=
 =?us-ascii?Q?7zsiwynhIYVId3MJsdLlgKLI0kjuGeyCU/XyvVSUWVv3BKyz7kHaqdHrLziw?=
 =?us-ascii?Q?l5MJMOSN+yP0UYpti1jJOV+M92DBz0Oc6VR3GiCZ67+LaK8lWDXQBs/PL3Fy?=
 =?us-ascii?Q?bXJOf9nHyQyTcKQfIbl+BE+ldrMUlewllLkY1QRPPsvHKFeTA0E5+hwSwjDs?=
 =?us-ascii?Q?d+iywb+g6HWAkoTjotg/EZ73ZZV/AGK15htqja+G1I2iD5Z1UknZH2qZ9jdC?=
 =?us-ascii?Q?4aHAEFXcDMPB9BrbAGZa3c3nY88kq3uBUKXVU+X44qEQWpyC/SimCiEAvxxm?=
 =?us-ascii?Q?o+W6g671I3edKZ5GSgl0jGG8k5ShKcblC/CSPScH?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	dctfZafhV+dscLM79fuAcPcm9bVP9954l+ilK9TrwmyCPD2ECfSo/5g3wVTrCRBWjomV/cxN4Se1OEJsPdbFpy6dG56PXUL5zj2fTx0zi6efvQfTre5iDS1wfCHOBWDGb8wTx74+eTkXOtsjJ70Wfeb+GcF5DqHmPGty9UlGqTuV0vmjAagJVDoX3cQq9P+5fm1J3oRVk4K2MIJqtUZmUH+B44NkBLE/JoseFvhUvepCPm9bxTwWedE1awSBdzAyAyF3p2yY0LiIKjgc0uqdbvIH1YtakNB23cOcQj6TMSIcvN/UK5G3CYYGJploGnyHeyDQcplfjiYTQyuGYWza2kxYQM8xm6mMySl89ThhqsHU2x/o6sC2td64lKr/jnYWghaDhYCXItl0uQxXO8NHml51GoJhG4YYx2ko0HJkqkO4Om8jh5BITpEhidgTecd282AemRlLM0taS+OcC9GlVx+TyCnFKJQKOPsvTdZfOMVYzc/Wd6EAvnOfCw71nHavW56Ud84ngpDs3E8gm4IrEl4UOGQoZWSsD72gcqKtyIb476HEy9Rw75hAlO2bSf0PndBmhvpjn7gGm3zcEVtN7b1DRwNj1XaM5vPTfMyfRTo=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 580b40fd-3050-4c3d-6822-08dc3984d9fc
X-MS-Exchange-CrossTenant-AuthSource: BYAPR10MB2663.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 00:16:33.6315
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: JWKyT99c3nhql3mUi/NYXEL0EtRBJCP9FkVRzB/pvdypV0sOrvzIOffYpViE8LrZuVnOTaerZG5s/fTMjanvZg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB4867
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-29_06,2024-02-29_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0 mlxscore=0
 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 mlxlogscore=999
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403010000
X-Proofpoint-GUID: _NjwxSDkmYDSgbFshS5raqs3pgYh-pUZ
X-Proofpoint-ORIG-GUID: _NjwxSDkmYDSgbFshS5raqs3pgYh-pUZ

Currently to trigger split lock exception at the guest side will print the
below to host logs.

"x86/split lock detection: #AC: CPU 1/KVM/65886 took a split_lock trap at
address: 0x401173"

Although it is more likely the split lock exception is from the guest side,
differentiate if it is from the guest side, or the host userspace
VMM (e.g., QEMU).

Signed-off-by: Dongli Zhang <dongli.zhang@oracle.com>
---
Changed since v1:
  - Pass the string rather than bools (suggested by Dave Hansen)

 arch/x86/kernel/cpu/intel.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/x86/kernel/cpu/intel.c b/arch/x86/kernel/cpu/intel.c
index a927a8fc9624..26e45d9a66f2 100644
--- a/arch/x86/kernel/cpu/intel.c
+++ b/arch/x86/kernel/cpu/intel.c
@@ -1155,14 +1155,14 @@ static int splitlock_cpu_offline(unsigned int cpu)
 	return 0;
 }
 
-static void split_lock_warn(unsigned long ip)
+static void split_lock_warn(unsigned long ip, const char *from)
 {
 	struct delayed_work *work;
 	int cpu;
 
 	if (!current->reported_split_lock)
-		pr_warn_ratelimited("#AC: %s/%d took a split_lock trap at address: 0x%lx\n",
-				    current->comm, current->pid, ip);
+		pr_warn_ratelimited("#AC: %s/%d (%s) took a split_lock trap at address: 0x%lx\n",
+				    current->comm, current->pid, from, ip);
 	current->reported_split_lock = 1;
 
 	if (sysctl_sld_mitigate) {
@@ -1194,11 +1194,11 @@ static void split_lock_warn(unsigned long ip)
 bool handle_guest_split_lock(unsigned long ip)
 {
 	if (sld_state == sld_warn) {
-		split_lock_warn(ip);
+		split_lock_warn(ip, "guest");
 		return true;
 	}
 
-	pr_warn_once("#AC: %s/%d %s split_lock trap at address: 0x%lx\n",
+	pr_warn_once("#AC: %s/%d %s (guest) split_lock trap at address: 0x%lx\n",
 		     current->comm, current->pid,
 		     sld_state == sld_fatal ? "fatal" : "bogus", ip);
 
@@ -1237,7 +1237,7 @@ bool handle_user_split_lock(struct pt_regs *regs, long error_code)
 {
 	if ((regs->flags & X86_EFLAGS_AC) || sld_state == sld_fatal)
 		return false;
-	split_lock_warn(regs->ip);
+	split_lock_warn(regs->ip, "user");
 	return true;
 }
 
-- 
2.34.1