Received-SPF: pass (google.com: domain of linux-kernel+bounces-87766-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <6bfce5ec26a26c327c4196dbe57b63d5.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <2b274111-e65a-4b99-8f07-220324f1e214@amd.com>
References: <20240229122250.24786-1-duoming@zju.edu.cn> <2b274111-e65a-4b99-8f07-220324f1e214@amd.com>
Subject: Re: [PATCH v2] clk: zynq: Prevent null pointer dereference caused by kmalloc failure
From: Stephen Boyd <sboyd@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, mturquette@baylibre.com
To: Duoming Zhou <duoming@zju.edu.cn>, Michal Simek <michal.simek@amd.com>, linux-kernel@vger.kernel.org
Date: Thu, 29 Feb 2024 17:21:46 -0800
User-Agent: alot/0.10

Quoting Michal Simek (2024-02-29 04:45:54)
> On 2/29/24 13:22, Duoming Zhou wrote:
> > diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> > index 7bdeaff2bfd..e4c4c9adf79 100644
> > --- a/drivers/clk/zynq/clkc.c
> > +++ b/drivers/clk/zynq/clkc.c
> > @@ -427,7 +427,7 @@ static void __init zynq_clk_setup(struct device_nod=
e *np)
> >                       SLCR_GEM1_CLK_CTRL, 0, 0, &gem1clk_lock);
> >  =20
> >       tmp =3D strlen("mio_clk_00x");
> > -     clk_name =3D kmalloc(tmp, GFP_KERNEL);
> > +     char clk_name[tmp];
>=20
> I know that Stephen asked for it but variable with variable length in the=
 middle=20
> of code doesn't look good or useful.

I didn't ask for it to be in the middle of the function :)