Received-SPF: pass (google.com: domain of linux-kernel+bounces-87776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <cd72dbb31387cd4e2551189d8d10d3a6.sboyd@kernel.org>
Content-Type: text/plain; charset="utf-8"
Precedence: bulk
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <CZHOCV35A23S.14HL07U73EH6X@bootlin.com>
References: <20240227-mbly-clk-v8-0-c57fbda7664a@bootlin.com> <20240227-mbly-clk-v8-3-c57fbda7664a@bootlin.com> <Zd4X3NnBoEl0wu2H@smile.fi.intel.com> <CZGSB2O8P572.28HK6WFT43N6S@bootlin.com> <ZeBnX2upNRN0xXH4@smile.fi.intel.com> <CZHMSNWMH4KJ.2J6ZMWKMSZYH2@bootlin.com> <ZeCbvgWY6x1o17Kq@smile.fi.intel.com> <CZHOCV35A23S.14HL07U73EH6X@bootlin.com>
Subject: Re: [PATCH v8 03/10] clk: eyeq5: add platform driver, and init routine at of_clk_init()
From: Stephen Boyd <sboyd@kernel.org>
Cc: Gregory CLEMENT <gregory.clement@bootlin.com>, Michael Turquette <mturquette@baylibre.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Linus Walleij <linus.walleij@linaro.org>, =?utf-8?q?Rafa=C5=82_Mi=C5=82ecki?= <rafal@milecki.pl>, Philipp Zabel <p.zabel@pengutronix.de>, Vladimir Kondratiev <vladimir.kondratiev@mobileye.com>, linux-mips@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Thomas Petazzoni <thomas.petazzoni@bootlin.com>, Tawfik Bayouk <tawfik.bayouk@mobileye.com>, linux-gpio@vger.kernel.org
To: Andy Shevchenko <andriy.shevchenko@intel.com>, =?utf-8?q?Th=C3=A9o?= Lebrun <theo.lebrun@bootlin.com>
Date: Thu, 29 Feb 2024 17:33:10 -0800
User-Agent: alot/0.10

Quoting Th=C3=A9o Lebrun (2024-02-29 07:40:25)
> Hello,
>=20
> On Thu Feb 29, 2024 at 3:59 PM CET, Andy Shevchenko wrote:
> > On Thu, Feb 29, 2024 at 03:27:01PM +0100, Th=C3=A9o Lebrun wrote:
> > > On Wed, Feb 28, 2024 at 03:33:29PM +0100, Th=C3=A9o Lebrun wrote:
> > > > On Tue Feb 27, 2024 at 6:11 PM CET, Andy Shevchenko wrote:
> > > > > On Tue, Feb 27, 2024 at 03:55:24PM +0100, Th=C3=A9o Lebrun wrote:
>=20
> > 2) Still I see a benefit from using lo_hi_readq() and friends directly.
>=20
> So it is:
>=20
>         u32 r0 =3D readl(base_plls + pll->reg64);
>         u32 r1 =3D readl(base_plls + pll->reg64 + sizeof(r0));
>=20
> vs:
>=20
>         u64 r =3D lo_hi_readq(base_plls + pll->regs64);
>         u32 r0 =3D r;
>         u32 r1 =3D r >> 32;
>=20
> One is straight forward, the other uses an obscure helper that code
> readers must understand and follows that with bit manipulation.
>=20

Just use readq() and include the correct header please. We know what
readq() is in the kernel.