Received-SPF: pass (google.com: domain of linux-kernel+bounces-87838-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <fc6563ac-e705-48ff-9581-ac4154a064ac@gmail.com>
Date: Fri, 1 Mar 2024 11:33:19 +0900
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] docs: drop the version constraints for sphinx and
 dependencies
To: Vegard Nossum <vegard.nossum@oracle.com>,
 Lukas Bulwahn <lukas.bulwahn@gmail.com>, Jonathan Corbet <corbet@lwn.net>
Cc: linux-kernel@vger.kernel.org, Mauro Carvalho Chehab <mchehab@kernel.org>,
 Jani Nikula <jani.nikula@linux.intel.com>,
 Randy Dunlap <rdunlap@infradead.org>, linux-doc@vger.kernel.org,
 Akira Yokosawa <akiyks@gmail.com>
References: <20240227131410.35269-1-lukas.bulwahn@gmail.com>
 <e6441dc1-6821-4514-b285-ebc24114aece@oracle.com>
Content-Language: en-US
From: Akira Yokosawa <akiyks@gmail.com>
In-Reply-To: <e6441dc1-6821-4514-b285-ebc24114aece@oracle.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On Thu, 29 Feb 2024 15:39:31 +0100, Vegard Nossum wrote:
> [...]
> 
> $ scripts/sphinx-pre-install
> Detected OS: Ubuntu 22.04.3 LTS.
> Sphinx version: 4.3.2
> 
> 
> All optional dependencies are met.
> Needed package dependencies are met.
> 
> 
> One remark I have is that it didn't encourage me to upgrade to 7.2.6 in
> the last one (using the system Sphinx 4.3.2) although it did for the
> 2.4.4 virtualenv. Maybe that's expected. I didn't look into it. Anyway,

Yes, it's expected.

Sphinx 3.4.3 provided as distro packages of Debian 11 (bullseye),
RHEL 9, and so on is good enough for kernel documentation.
Suggesting upgrade to a latest release would be noisy.

The version is assigned to $rec_version in sphinx-pre-install.

As a fix to requirements.txt for v6.8, this looks to me like a nice
minimal change.

Lukas, many thanks for doing this.

Reviewed-by: Akira Yokosawa <akiyks@gmail.com>

    Thanks, Akira