Received-SPF: pass (google.com: domain of linux-kernel+bounces-87566-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Content-Type: text/plain;
	charset=us-ascii
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.400.31\))
Subject: Re: [PATCH] nilfs2: Use div64_ul() instead of do_div()
From: Thorsten Blum <thorsten.blum@toblux.com>
In-Reply-To: <BFEA2A31-3147-49EF-A9BE-592C90E783DD@toblux.com>
Date: Thu, 29 Feb 2024 22:14:48 +0100
Cc: linux-nilfs@vger.kernel.org,
 linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <215C3176-D6E5-47CF-BC48-7A75CF75CE3F@toblux.com>
References: <20240229121650.33983-1-thorsten.blum@toblux.com>
 <CAKFNMomtp7ZwB0gmxoemp_ums4rqOSbfF2BMS6kX+LwtKYtvCg@mail.gmail.com>
 <19910196-DFF3-4F94-B6D3-B9BF722DF8B8@toblux.com>
 <BFEA2A31-3147-49EF-A9BE-592C90E783DD@toblux.com>
To: Ryusuke Konishi <konishi.ryusuke@gmail.com>


> On Feb 29, 2024, at 21:40, Thorsten Blum <thorsten.blum@toblux.com> =
wrote:
>=20
>> On Feb 29, 2024, at 20:41, Thorsten Blum <thorsten.blum@toblux.com> =
wrote:
>>=20
>>> On Feb 29, 2024, at 19:45, Ryusuke Konishi =
<konishi.ryusuke@gmail.com> wrote:
>>>=20
>>> All of the fixes in this patch seem to be correct, but this doesn't
>>> cover nilfs_resize_fs(), nilfs_max_segment_count(), and
>>> nilfs_sb2_bad_offset(), which also have do_div() that doesn't use =
the
>>> return value.
>>=20
>> For nilfs_sb2_bad_offset(), where the dividend is u64 and the divisor =
is u32, we
>> would need a dedicated function like div64_u32() that doesn't =
calculate the
>> remainder, which doesn't seem to exist. What do you think?
>=20
> Never mind, there is div_u64(u64, u32). I'll submit a v2 shortly.

I left nilfs_sb2_bad_offset() unchanged in v2 because div_u64() still =
calculates
the remainder.

Thorsten=