Received: by 2002:ab2:3b09:0:b0:1ed:14ea:9113 with SMTP id b9csp12560lqc; Thu, 29 Feb 2024 09:01:45 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWpfustE/rgc5CwNp/9/cfaSu+TsfvEBGmwJzd2/qiG0xwLqEURZkrLJ4L+Apvv1UmAXLvVhxGlWLTYFc5bbFdfm2Tqk/PXS1iIm/fyhw== X-Google-Smtp-Source: AGHT+IG8fl7ZbAFTTLfNvJzS9X+1Gt0A1bQg273aeQyE/qWXgj/F+3Q37f9F+5qUWr3lUa+BqimM X-Received: by 2002:a05:6a20:d70f:b0:1a1:2a63:9986 with SMTP id iz15-20020a056a20d70f00b001a12a639986mr2640199pzb.58.1709226105266; Thu, 29 Feb 2024 09:01:45 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709226105; cv=pass; d=google.com; s=arc-20160816; b=yVUy8lXVaHQOkehHZXQEG3aEWhQxtaRQHCIQXTD+Lv3QGX19ZAVVDLjFO4hOOzvWwV sJGZ05jLzWkCLKGNocpx+jPlmpIlOvi5LX0eXPB9vJ0a9D93ttWWkTr3keCGPAY+HpXh 8TDhKbItmz0bH8PDc4Y0fxWc04o0qfnGj7FsbgapvWRhNLUIqqIUihDpZc02l08nm4Cz qn4U4CAR1flTvlFAzWQ5hOfUNdHXQYIe9El+gn+F63l9Y8+LAzjZPpe7Dd2QpYcJkahM XERrvf8MZxwB55tdkXhh6cKGSG6utCmbSajoyiObytc5ZUUFDIgrp3gR2zjCEm6oLUSj CwRg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:in-reply-to:subject:cc:to:from:date; bh=xZlzZrmAe7T0zCbMh75QRAZanrmpzAa5punRbCmeBV4=; fh=2DelKqwJtuYRq4nciVwfDrOB6nKkBa2HeHFm3UBLLiw=; b=jpZBjQw5lJVPJT4Ex2bRibvbtjAO6PeEfNdy93Hzsg3JN0A1ph+RcA7FMe2FBcwllg VZuogk/I9A2vpDXhiDkZF5MBp8g5YUaahoByHIw8Xy/KN57JqcfMrTwwUdxJiAU28T1U vT0mhNZ19pOXsdomBCoCvtfVxOfAicEnOLaCeLYXYzs/r1b3VYhHg4dNfeLXVxvKmdYO ggqC4h9l7OIDnn2iCLMeEvOu6vE+KuWSwaLvL3NFM56HHS6BKo0slMmuAIxghAn6Bwm/ BqL/1vNp7nIsfGb1A66lM46dPW4DdzHwR1bxf2pMN+Q1fTe9UqKxWQxYNaM5BGWxW21f qUhg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-87129-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87129-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.com Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id r3-20020a63d903000000b005dba8009eb2si1728079pgg.724.2024.02.29.09.01.45 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 09:01:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-87129-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-87129-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-87129-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linux.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 1C34628331C for ; Thu, 29 Feb 2024 17:01:11 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 7B48770AE5; Thu, 29 Feb 2024 16:56:29 +0000 (UTC) Received: from gentwo.org (gentwo.org [62.72.0.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C8483383B0; Thu, 29 Feb 2024 16:56:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=62.72.0.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709225789; cv=none; b=OtpLNzsTta/xkMpFQfo1nk7wB3iKNGNoKk87oHFJI4a1FfgGvPDi++n0v3I7AF0GSZcL+hZQrM4rSmZ6KQ1zMkSdsWaD0IGasE/XUZvzn1Fr/SRJ2p9TFY405uThu3VwDvrpB+sefclUGnOGBo0OytjrBz1wDWOHOX2VbqiQi7g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709225789; c=relaxed/simple; bh=GrJqqBgEDW//Vb6mDW03vv0mmHF3ihM5IqxCUUk5g/s=; h=Date:From:To:cc:Subject:In-Reply-To:Message-ID:References: MIME-Version:Content-Type; b=WTXFVCfl57zcoGkVIDbJ6WvD8yKj8EvMoa0Z/anZapTeRw5pqZv5vZ5LMK3boigYIWs2uRWeB/H89TLvHk8WCQDL1CHDMBjb6hqXftp7YJYM5Ne7iP7+6ttNks2Bm1cN7tov6XJPsggDDYKrPi//ZeZ84SGjk3gHvutphhOWn9g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com; spf=fail smtp.mailfrom=linux.com; arc=none smtp.client-ip=62.72.0.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=linux.com Received: by gentwo.org (Postfix, from userid 1003) id ACB1040AB2; Thu, 29 Feb 2024 08:56:20 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by gentwo.org (Postfix) with ESMTP id ABEA040AAD; Thu, 29 Feb 2024 08:56:20 -0800 (PST) Date: Thu, 29 Feb 2024 08:56:20 -0800 (PST) From: "Christoph Lameter (Ampere)" To: Huang Shijie cc: kuba@kernel.org, patches@amperecomputing.com, davem@davemloft.net, horms@kernel.org, edumazet@google.com, ast@kernel.org, dhowells@redhat.com, linyunsheng@huawei.com, aleksander.lobakin@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, cl@os.amperecomputing.com Subject: Re: [PATCH v2] net: skbuff: set FLAG_SKB_NO_MERGE for skbuff_fclone_cache In-Reply-To: <20240227062833.7404-1-shijie@os.amperecomputing.com> Message-ID: References: <20240227062833.7404-1-shijie@os.amperecomputing.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed On Tue, 27 Feb 2024, Huang Shijie wrote: > Since we do not set FLAG_SKB_NO_MERGE for skbuff_fclone_cache, > the current skbuff_fclone_cache maybe not really allocated, it maybe > used an exist old kmem_cache. In NUMA, the fclone allocated by > alloc_skb_fclone() maybe in remote node. This is not the right approach. If you want to force a local allocation you need to use GFP_THISNODE. Merging has nothing to do with locality.