Received-SPF: pass (google.com: domain of linux-kernel+bounces-86391-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <34157878-c480-44bb-91d6-9024da329998@oracle.com>
Date: Thu, 29 Feb 2024 09:17:44 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] fix linux kernel BTF builds: increase max percpu
 variables by 10x
Content-Language: en-GB
To: John Hubbard <jhubbard@nvidia.com>, Jiri Olsa <olsajiri@gmail.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>,
        Alexei Starovoitov <ast@kernel.org>, bpf@vger.kernel.org,
        LKML <linux-kernel@vger.kernel.org>, dwarves@vger.kernel.org
References: <20240228032142.396719-1-jhubbard@nvidia.com>
 <Zd76zrhA4LAwA_WF@krava> <856564cf-fba4-4473-bfa9-e9b03115abd1@oracle.com>
 <983b98db-79c0-4178-b88f-61f39d147cf7@nvidia.com>
From: Alan Maguire <alan.maguire@oracle.com>
In-Reply-To: <983b98db-79c0-4178-b88f-61f39d147cf7@nvidia.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TUU5YkRreEIzVFF0U3ptTlFDdkY1aDhYR2pYa0NWNm5VSHhybVJ2Slc1V3lI?=
 =?utf-8?B?UEdxRlh2eG4xSFdHRU01bmpOb0hlblRtemNKMUI3WXY3S3Y0MmEzNkpld2Zr?=
 =?utf-8?B?b2l6YXF1bW42M2h6ZS9NME1YWVRDbHlFd1ZMVFZRNmZWYkt3alo3QU1qQmVW?=
 =?utf-8?B?aHpOZVJsQU1lc0R4NDZjMGVTVkI4OVZabmM0cVN2ajl6enQ1LzlHai9Db3FB?=
 =?utf-8?B?dEFJdlF2a1FoSmN5Yjc4K2prN1NWUVpUTXYvOTZTR0dRd0g4RGx4WTZ1Q09D?=
 =?utf-8?B?dlVBZTBodE9RaSt1dDZ4THR1WXhOSURzTExObzFqVkgrMnVPNHdoOEw2MHNW?=
 =?utf-8?B?WlFOZERKS0VXVWRwbUhkckJrMzFZb3hTVmZLZ21sU1R6LzJ0TjQ4K04rR2VH?=
 =?utf-8?B?WlVBZnpBbitYR1daSHhla2l2NHRLUlYwR1dPTkJrS1J6djR3UzFCQnVOWE5E?=
 =?utf-8?B?NENNUXVjamtxeHRzdCtOcURwemlpT1ZicHFOMDMxenlnOXdIR0d2UDdFRmtB?=
 =?utf-8?B?MG41TkJSWXFndEUxbWNsOXQwNklYUm1QTUh2cld5SlVVcHdmN3hkMk9JVkVU?=
 =?utf-8?B?VnVXWjdBSG01Ti9VN0FIUWl3ZTVHdmZEV3RqbFQvT1g0UnVtOHRxTjJmMVNZ?=
 =?utf-8?B?bGg4WGFYVG8xMG9rWFhEN0pkU1c5bitUNWJHTGJYU0VodVdTa1FpOGpUY2VK?=
 =?utf-8?B?OGVreWdYZmliaGpJOXlHYlhrU1UwNUQ0a09TYnFHQTdRb2JwWUlGN2tGbmI1?=
 =?utf-8?B?d2hZRjVKZ09McXkzQzBRR1l0TVNpbFRkYTUwTDhUamxlaVlUWklEV3F5eUlR?=
 =?utf-8?B?OXRpdk5Nc0NtNDJEWDFsVDVFdjNjM052S082b01yNkdac1JKNitNVkgwcTZX?=
 =?utf-8?B?NC9QbEhjYUNaUEJpcGpVUlZ5Ynl5Z3U0dXpYT3h0NjcwN3I1OFp3WElBcm1s?=
 =?utf-8?B?ajJWLyt6d0lFa05hVGxMTDF5U2NIcDN2WGw2NDlxUTlJZ2ovc1FFY0RsTE5X?=
 =?utf-8?B?Nzg3Ym1SVHJkQk9Dem0xRUV2Z28xS2o3a1l5QURWQjNqVEpjbXhVWmFXV3Zv?=
 =?utf-8?B?MFdabS9iaGdIaWVlMDJScTM4ZEl2ckRMa0ViM2ZqKzZyMVBjdXJjNXFQcXNJ?=
 =?utf-8?B?UjAwSE05SEFEdHdSVGc4OXRlbmZ0d1pPWnBuR3pNWUNSalNwTDZaKzBEY2F2?=
 =?utf-8?B?cFM1Zk1MSjF4TnZEYWxVUWVMSnYzcEhkeEN4aGRpQUNzZWdPcG5UMytkTW9r?=
 =?utf-8?B?TEg1SzZLenAzWk10SVcwQTRLRE42Qzk4VTdCa1pwNWxsUXVTbU9WVU5UOEZm?=
 =?utf-8?B?bTRyWXhlc2VwK0dJTzZhL3ZLcFBIVmZESkVMWWZYNmlhbyt6Q243UFNOSkZs?=
 =?utf-8?B?YTdWaDZ0NWdrWm1XVU9kYWFIYWZsa3lmSHR2UmJvZGcvdXdYR0hISldrSFFi?=
 =?utf-8?B?RDdPYVE1UHl5a1dSQ2Jza0NYRWJwOTNMN3N0cEZmK28vYm1Qa2QxalNlbzBK?=
 =?utf-8?B?b28wMnRtdWpxQU4vTVF4VThlcU5rZGVOZGVYUEZXOUtuUmJKWWRUZzNVdzR2?=
 =?utf-8?B?MmZaS0FYaVNHakZXWVpPM2hMN0w2SUdMOVpWV3pLMnk3UHNISU5HOENsVXF5?=
 =?utf-8?B?OEJDU0cyVTRLNUpWQi9GanA4Z2RLWjB4NjZwV3VXS1RVM28wR0VOUnJ2U3Vz?=
 =?utf-8?B?ZEp5YitYcHl0cEZ0NEFBV0FFWW9KN0EzUVRrQ2NRTS9Ralg2ZGdaRWsxRDdr?=
 =?utf-8?B?TnM2bm55elk4bVVzOSt1Myt1VVhOaEVYamhQejBjQmNaTmI3d3c4ck4zQUdl?=
 =?utf-8?B?UGt5NEJxeUphQjZhQm01WnZsKzNjUFJJSENTV3FjNmxMcE4vdXB1aklMRlFN?=
 =?utf-8?B?aG1ibERYdkc1N2NVVzhhdnVkWE54czJBNWFDMStKdmpmV3ZidXVkdFNBUlk4?=
 =?utf-8?B?TmZYVnlIRHlUSUJsdTFLSEZHVVRKN2Uxa0VNdmQrZHZPUGxkTzMyNWFGdHdG?=
 =?utf-8?B?NFVETWlpN2RXUU83N3E0L25ZdHVHVlRNaE1hbkRBKzk3OFc4S3RIQlZYQWNl?=
 =?utf-8?B?VDV3eDllQkg2akQrMU42S01OY29zS2ZtT3h5QXJOTFgxVE14V1JPNytOVzBo?=
 =?utf-8?B?eU9vcGs4TjhiYng1YUZKNWIzSTZwTlNqSG9IUndiNStOQi8xR1gzVm4wcUJ4?=
 =?utf-8?Q?UMPxXOsYjmPbTlC4TiBCdzw=3D?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	2rlFgKf3WrNwVmRu/hSkhNmUffiSR8ephq/xBCRDmOsjztML4wvxw0bPLE1Emekmi0c/mSPXkZgI/POh9NyTEy1Q35nvnfjpwlegr05WU/8JqvzfleMwh3JEMuEd4dcJT5cXnrlepLXLavCpQE7juR/PPzShXya5r3DTWwUEeAJpkwbm+w1SnvD/f1qxT/pnSRRjcRgKzTfl0Y7pAByr51+06Wzt1rtEs/KN0oKvMiH5rI6V1kboaOf0q5bflcFoEmBmIW8rfPO5gGj0w8XtthRB1U/OqdHPYfsAovVck2ucsPqWF98Dy246qTBSIq+/xJs0/4jWjYQYyX2LqwsHgJV5Z7oSAwVU2nHAF/1pZrnz5/ms+VqG3NgXiIZlronKWzNo9ZvgSfLLtHAsbD4TgMM++KO3sBU+mgekYNv6jTRmMLi4XWAygQCzAY3CdrFPnf3suzmWnjsSynbfidRaqGiBqBqibdyowMiFhO4U1knlyh9/mzultWFthD9McvwHqn06Kv3VytqRlwMAwUcR+0R02KIR0oi4ar9IZSrHLIoy20qaEpodel2NwTtaxiNujw5/l49zpDer16KI330PaCyJs6CS7c+z/cCu5kzOU9g=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9796321b-b139-4030-2c33-08dc39074b83
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5267.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Feb 2024 09:17:47.6054
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tsfMBN5gpi7nPrXRec4LwKymul0Jfr5ToLXIi0aJCR47FL7bvsCowQsm4bm16obegcbJqEtMmxNeM+BtYzIRDA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR10MB7244
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-29_01,2024-02-27_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 malwarescore=0 spamscore=0 bulkscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402290071
X-Proofpoint-GUID: 7usWozouejJDCoANSD_-P_QJxZA_tRKA
X-Proofpoint-ORIG-GUID: 7usWozouejJDCoANSD_-P_QJxZA_tRKA

On 28/02/2024 23:21, John Hubbard wrote:
> On 2/28/24 04:04, Alan Maguire wrote:
>> On 28/02/2024 09:20, Jiri Olsa wrote:
>>> On Tue, Feb 27, 2024 at 07:21:42PM -0800, John Hubbard wrote:
> ...
>>> do you have an actual count of percpu variables for your config?
> 
> That's a very reasonable question...
> 
>>> 10x seems a lot to me
> 
> Me too. This was a "make the problem go away now please" type of "fix". :)
> 


Running

bpftool btf dump file vmlinux |grep "] VAR"

..should give us a sense of what's going on. I only see 375 per-cpu
variables when I do this so maybe there's something
kernel-config-specific that might explain why you have so many more?

>>>
>>> this might be a workaround, but we should make encoder->percpu.vars
>>> dynamically allocated like we do for functions
> 
> Yes, that's a much better design imho.
> 
>>>
>>> jirka
>>>
>>
>> Good idea Jiri; John would you mind trying the attached patch? Thanks!
> 
> It works perfectly for me. For that patch, please feel free to add:
> 
> Tested-by: John Hubbard <jhubbard@nvidia.com>
>


that's great, thanks for testing this John!

Alan

> 
> thanks,