Received-SPF: pass (google.com: domain of linux-kernel+bounces-81919-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Mon, 26 Feb 2024 16:37:55 +0000
From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Catalin Popescu <catalin.popescu@leica-geosystems.com>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, davem@davemloft.net,
	edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	bsp-development.geo@leica-geosystems.com, m.felsch@pengutronix.de
Subject: Re: [PATCH net-next v2] net: phy: dp83826: disable WOL at init
Message-ID: <Zdy+Y8Mqs22yRrre@shell.armlinux.org.uk>
References: <20240226162339.696461-1-catalin.popescu@leica-geosystems.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240226162339.696461-1-catalin.popescu@leica-geosystems.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>

On Mon, Feb 26, 2024 at 05:23:39PM +0100, Catalin Popescu wrote:
> Commit d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> introduced a regression in that WOL is not disabled by default for DP83826.
> WOL should normally be enabled through ethtool.
> 
> Fixes: d1d77120bc28 ("net: phy: dp83826: support TX data voltage tuning")
> Signed-off-by: Catalin Popescu <catalin.popescu@leica-geosystems.com>

It seems rather interesting that WoL is disabled in the config_init()
method - because this will be called when the PHY is attached to its
network driver (reasonable I guess) but also at resume time - which
means one can't just set the WoL mode once and that status will be
preserved.

Maybe Andrew can clarify, but I thought once WoL was configured, that
configuration should remain until the system is rebooted.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!