Received-SPF: pass (google.com: domain of linux-kernel+bounces-81414-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 26 Feb 2024 12:53:35 +0000 (GMT)
From: "Maciej W. Rozycki" <macro@orcam.me.uk>
To: =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= <ilpo.jarvinen@linux.intel.com>
cc: Bjorn Helgaas <bhelgaas@google.com>, linux-pci@vger.kernel.org, 
    LKML <linux-kernel@vger.kernel.org>, 
    Mika Westerberg <mika.westerberg@linux.intel.com>
Subject: Re: [PATCH 1/1] PCI: Cleanup link activation wait logic
In-Reply-To: <alpine.DEB.2.21.2402100118350.2376@angie.orcam.me.uk>
Message-ID: <alpine.DEB.2.21.2402261244030.60326@angie.orcam.me.uk>
References: <20240202134108.4096-1-ilpo.jarvinen@linux.intel.com> <alpine.DEB.2.21.2402021359450.15781@angie.orcam.me.uk> <a0e8ae37-cc11-2219-201e-d6740028b735@linux.intel.com> <alpine.DEB.2.21.2402100118350.2376@angie.orcam.me.uk>
User-Agent: Alpine 2.21 (DEB 202 2017-01-01)
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII

On Sat, 10 Feb 2024, Maciej W. Rozycki wrote:

> > >  You change the logic here in that the second conditional isn't run if the 
> > > first has not.  This is wrong, unclamping is not supposed to rely on LBMS. 
> > > It is supposed to be always run and any failure has to be reported too, as 
> > > a retraining error.  I'll send an update according to what I have outlined 
> > > before then, with some testing done first.
> > 
> > Oh I see now, I'm sorry, I didn't read all the way to the last paragraph 
> > of the commit message because the earlier one in the commit message hinted 
> > the restriction is removed afterwards so I thought it was only linked to 
> > the first part of the quirk.
> 
>  No worries.  I have submitted the changes now: 
> <https://lore.kernel.org/r/alpine.DEB.2.21.2402092125070.2376@angie.orcam.me.uk/>.
> 
>  Unfortunately due to a sudden hardware failure I wasn't able to do any
> non-trivial verification, as explained in the cover letter.  I'll try to 
> get back to it as soon as reasonably possible, hopefully next month.

 I have the failure sorted now, simply reseating one of the connections 
made all the option modules work again as previously.  I'm not impressed 
by this lack of reliability, but maybe it was just bad lack, as things 
used to work just fine for over 2 years before I replaced the mainboard.

 I'll see if I can do some verification this week.

  Maciej