Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754828AbYACQgS (ORCPT ); Thu, 3 Jan 2008 11:36:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752205AbYACQgJ (ORCPT ); Thu, 3 Jan 2008 11:36:09 -0500 Received: from tomts10.bellnexxia.net ([209.226.175.54]:48379 "EHLO tomts10-srv.bellnexxia.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751580AbYACQgI (ORCPT ); Thu, 3 Jan 2008 11:36:08 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: Ah4FAL+dfEdMROHU/2dsb2JhbACBV6ha Date: Thu, 3 Jan 2008 11:30:55 -0500 From: Mathieu Desnoyers To: "K. Prasad" Cc: mingo@elte.hu, linux-kernel@vger.kernel.org, linux-rt-users@vger.kernel.org, dipankar@in.ibm.com, ego@in.ibm.com, paulmck@linux.vnet.ibm.com Subject: Re: [PATCH 2/2] Markers Implementation for Preempt RCU Boost Tracing Message-ID: <20080103163055.GB27651@Krystal> References: <20071231060911.GB6461@in.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Content-Disposition: inline In-Reply-To: <20071231060911.GB6461@in.ibm.com> X-Editor: vi X-Info: http://krystal.dyndns.org:8080 X-Operating-System: Linux/2.6.21.3-grsec (i686) X-Uptime: 11:26:58 up 60 days, 21:32, 5 users, load average: 0.00, 0.13, 0.37 User-Agent: Mutt/1.5.16 (2007-06-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2621 Lines: 61 * K. Prasad (prasad@linux.vnet.ibm.com) wrote: > This patch converts the tracing mechanism of Preempt RCU boosting into > markers. The handler functions for these markers are included inside > rcupreempt_trace.c and will be included only when PREEMPT_RCU_BOOST is > chosen. > > Signed-off-by: K.Prasad > --- > include/linux/rcupreempt_trace.h | 46 ++++++++ > kernel/rcupreempt-boost.c | 211 ++++----------------------------------- > kernel/rcupreempt_trace.c | 183 +++++++++++++++++++++++++++++++++ > 3 files changed, 251 insertions(+), 189 deletions(-) > > Index: linux-2.6.24-rc2-rt1.MARKER_PATCHES_NEW/include/linux/rcupreempt_trace.h > =================================================================== > --- linux-2.6.24-rc2-rt1.MARKER_PATCHES_NEW.orig/include/linux/rcupreempt_trace.h > +++ linux-2.6.24-rc2-rt1.MARKER_PATCHES_NEW/include/linux/rcupreempt_trace.h > @@ -102,5 +102,51 @@ extern int rcupreempt_flip_flag(int cpu) > extern int rcupreempt_mb_flag(int cpu); > extern char *rcupreempt_try_flip_state_name(void); > > +#ifdef CONFIG_PREEMPT_RCU_BOOST > +struct preempt_rcu_boost_trace { > + unsigned long rbs_stat_task_boost_called; > + unsigned long rbs_stat_task_boosted; > + unsigned long rbs_stat_boost_called; > + unsigned long rbs_stat_try_boost; > + unsigned long rbs_stat_boosted; > + unsigned long rbs_stat_unboost_called; > + unsigned long rbs_stat_unboosted; > + unsigned long rbs_stat_try_boost_readers; > + unsigned long rbs_stat_boost_readers; > + unsigned long rbs_stat_try_unboost_readers; > + unsigned long rbs_stat_unboost_readers; > + unsigned long rbs_stat_over_taken; > +}; > + > +#define DEFINE_PREEMPT_RCU_BOOST_MARKER_HANDLER(preempt_rcu_boost_var) \ > +void preempt_rcu_boost_var##_callback(const struct marker *mdata, \ > + void *private_data, const char *format, ...) \ > +{ \ > + va_list ap; \ > + int cpu; \ > + struct preempt_rcu_boost_trace *boost_trace; \ > + va_start(ap, format); \ > + cpu = va_arg(ap, typeof(unsigned int)); \ (sorry for late response, I just came back from vacation) Instead of passing the cpu id as a marker parameter, why don't you simply use smp_processor_id() right here ? -- Mathieu Desnoyers Computer Engineering Ph.D. Student, Ecole Polytechnique de Montreal OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/