Received-SPF: pass (google.com: domain of linux-kernel+bounces-80319-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Sun, 25 Feb 2024 23:12:54 +0100 (CET)
From: Richard Weinberger <richard@nod.at>
To: Miquel Raynal <miquel.raynal@bootlin.com>, 
	Daniel Golle <daniel@makrotopia.org>
Cc: Vignesh Raghavendra <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>, 
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, 
	linux-mtd <linux-mtd@lists.infradead.org>, 
	devicetree <devicetree@vger.kernel.org>, 
	linux-kernel <linux-kernel@vger.kernel.org>
Message-ID: <1209094181.98490.1708899174329.JavaMail.zimbra@nod.at>
In-Reply-To: <20240219120156.383a1427@xps-13>
References: <cover.1702952891.git.daniel@makrotopia.org> <82ceb13954f7e701bf47c112333e7b15a57fc360.1702952891.git.daniel@makrotopia.org> <20240219120156.383a1427@xps-13>
Subject: Re: [PATCH v7 7/7] mtd: ubi: provide NVMEM layer over UBI volumes
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Thread-Topic: provide NVMEM layer over UBI volumes
Thread-Index: LhVCT6G++U013VIiCZmvxnpZEu2GqQ==

----- Urspr=C3=BCngliche Mail -----
> Von: "Miquel Raynal" <miquel.raynal@bootlin.com>
> An: "Daniel Golle" <daniel@makrotopia.org>
> CC: "richard" <richard@nod.at>, "Vignesh Raghavendra" <vigneshr@ti.com>, =
"Rob Herring" <robh+dt@kernel.org>, "Krzysztof
> Kozlowski" <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@=
kernel.org>, "linux-mtd"
> <linux-mtd@lists.infradead.org>, "devicetree" <devicetree@vger.kernel.org=
>, "linux-kernel"
> <linux-kernel@vger.kernel.org>
> Gesendet: Montag, 19. Februar 2024 12:01:56
> Betreff: Re: [PATCH v7 7/7] mtd: ubi: provide NVMEM layer over UBI volume=
s

> Hi Daniel,
>=20
> daniel@makrotopia.org wrote on Tue, 19 Dec 2023 02:33:48 +0000:
>=20
>> In an ideal world we would like UBI to be used where ever possible on a
>> NAND chip. And with UBI support in ARM Trusted Firmware and U-Boot it
>> is possible to achieve an (almost-)all-UBI flash layout. Hence the need
>> for a way to also use UBI volumes to store board-level constants, such
>> as MAC addresses and calibration data of wireless interfaces.
>>=20
>> Add UBI volume NVMEM driver module exposing UBI volumes as NVMEM
>> providers. Allow UBI devices to have a "volumes" firmware subnode with
>> volumes which may be compatible with "nvmem-cells".
>> Access to UBI volumes via the NVMEM interface at this point is
>> read-only, and it is slow, opening and closing the UBI volume for each
>> access due to limitations of the NVMEM provider API.
>=20
> I don't feel qualified enough to review the other patches, however this
> one looks good to me.

Finally(!), I had enough time to look.
Thanks for addressing all my comments form the previous series.
Patches applied.

I have only one tiny request, can you share the lockdep spalt
you encountered in ubi_notify_add() regarding mtd_table_mutex
and ubi_devices_mutex? The solutions looks okay to me, but
if you have more details that would be great.

Thanks,
//richard