Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp167390rbb; Fri, 23 Feb 2024 16:21:17 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWC27gsiv/n/4tTHtGxcmaBJNCUx4TxOq9h/1SBIfpgZwon3RiZsYM3OCLThWT8IEEs8vMTCGHpMdQS9DCfVeCs3S2t54pAUypJCHND4g== X-Google-Smtp-Source: AGHT+IG9fIE8C4q1XLr1iVa0NDnLO43+mtz067OF9sEIN2gaLur2rF5AGB2SomocIrWQ6JnIrAtJ X-Received: by 2002:ac8:4e4d:0:b0:42c:6fef:90e with SMTP id e13-20020ac84e4d000000b0042c6fef090emr695443qtw.65.1708734077723; Fri, 23 Feb 2024 16:21:17 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708734077; cv=pass; d=google.com; s=arc-20160816; b=int/SQoEnYtwrFlGaEqQkXoK8ZXGmTy8B4QIkZ+DKnj2Qn8927aHYkEfjeAnRGJgbe eSCoN9pL/r/6zXjojYkZQ0uR26xRbIbEK/gick/E8hp8uK0hhKliOipJc+h7kU2tiZ84 9p1yYlEVycAD0+BpCK/liyM1Okm+vudO7bumR7jEOaQOH1NTGWrZodiSL6f5/hiHOb2M y0J9UQnI34jzp/G8kejLRfbhIiKZIE36Y7QkHF//vVoYZruGWX6hY2ozecV1nxvZhW3v O69dwfctdOqr1gs87qElp/4BlHRN0rJoQQGQAuR0D13DMgRGrTl0Uzs2d7g7Rbj/rtwp eCHQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=S91c9DxPwNEV7KRxnKI5f1J6lR6Nwe2PGYouTCpQ04U=; fh=ybxpw/dDGzaoQv7yHULv0sKpIWI5HwTatPwbnXJFS2Y=; b=PdtN5LjrdO82463tLLyAUhGW2ccMsihAYw9R2ogUNh//+j1uXOkpuxNp+HXLkyIRra mGjrFkgKfLn9TrKrk3IwqCw7R+S4NOmt+uY58Fh+8EhCf+/bFpPEKOtd6G/ibiALnLYw bqwbfGXlddWyUZgAIX8oL/Oejpb9sQr2EX76oDiCu+9l8QwASe2n0sDnYoYvNrW2m8d4 NreKL8iwt0+Ob3TuSqCXmUyzUntdcG+C0igvLA1mg5lfcp9EyGg6MNZxKdU+OPyzH04j q2MxOnBlDXP/2thbWZ9XPUpatVkt7/u04iIK3jMVzvvUgh1xGaV8xbot+qc/T4ZozhTe Omnw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au dmarc=pass fromdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-kernel+bounces-79354-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79354-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=QUARANTINE dis=NONE) header.from=apana.org.au Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id c16-20020a05620a11b000b007879038b456si52065qkk.196.2024.02.23.16.21.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 16:21:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-79354-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au dmarc=pass fromdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-kernel+bounces-79354-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-79354-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=QUARANTINE dis=NONE) header.from=apana.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 7B06B1C219D5 for ; Sat, 24 Feb 2024 00:21:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 805FB10F7; Sat, 24 Feb 2024 00:21:04 +0000 (UTC) Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DBCE919A; Sat, 24 Feb 2024 00:20:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708734064; cv=none; b=c/PG1GJMUFFBNLT5yHCA6Pn4L6MkaUM3Q+bIvT4k5Are2611LPkr+zFrX9QR8CzS8gMdpOo0RvGdqmSvNet/aHD9vJsvrxf1qC+kI+xjThejZkAH8Rne6H5r3rXvrtMetQH8BQ8dVt6URLvoOiT5M2b4AG1AxIdk9s1bPNNmDX8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708734064; c=relaxed/simple; bh=aKvxed/I9m8KBzl5cPZ2gMhHmhpX6/QrLsQZfD2oYvU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pyS3dK95W3kTG2AoGJu79+vciX66TgPkPMiGxxjYcXK66m7AmkaAEU3MJyb8gVkSbqXY5a981rcRopdfF7Bzk9gO0F6J6DhKBx7N8mRIevh37UX0yOwb/wMxdRoR18XO6zILamwUY3Zx9SjEBXP9iV8/WhBnC3J/+FeZ3KwRaL4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rdfmO-00HDXA-9c; Sat, 24 Feb 2024 08:20:37 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 24 Feb 2024 08:20:50 +0800 Date: Sat, 24 Feb 2024 08:20:50 +0800 From: Herbert Xu To: "Matthew Wilcox (Oracle)" Cc: linux-kernel@vger.kernel.org, Thomas Graf , netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, maple-tree@lists.infradead.org, rcu@vger.kernel.org Subject: Re: [PATCH 0/1] Rosebush, a new hash table Message-ID: References: <20240222203726.1101861-1-willy@infradead.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240222203726.1101861-1-willy@infradead.org> On Thu, Feb 22, 2024 at 08:37:23PM +0000, Matthew Wilcox (Oracle) wrote: > > Where I expect rosebush to shine is on dependent cache misses. > I've assumed an average chain length of 10 for rhashtable in the above > memory calculations. That means on average a lookup would take five cache > misses that can't be speculated. Rosebush does a linear walk of 4-byte Normally an rhashtable gets resized when it reaches 75% capacity so the average chain length should always be one. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt