Received-SPF: pass (google.com: domain of linux-kernel+bounces-79374-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Sat, 24 Feb 2024 08:50:17 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mario Limonciello <mario.limonciello@amd.com>
Cc: Tom Lendacky <thomas.lendacky@amd.com>, John Allen <john.allen@amd.com>,
	"open list:AMD CRYPTOGRAPHIC COPROCESSOR (CCP) DRIVER - DB..." <linux-crypto@vger.kernel.org>,
	open list <linux-kernel@vger.kernel.org>,
	Tim Van Patten <timvp@google.com>
Subject: Re: [PATCH v2 1/2] crypto: ccp: Avoid discarding errors in
 psp_send_platform_access_msg()
Message-ID: <Zdk9SQMV4tyxyTEU@gondor.apana.org.au>
References: <20240213173429.43748-1-mario.limonciello@amd.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240213173429.43748-1-mario.limonciello@amd.com>

On Tue, Feb 13, 2024 at 11:34:28AM -0600, Mario Limonciello wrote:
> Errors can potentially occur in the "processing" of PSP commands or
> commands can be processed successfully but still return an error code in
> the header.
> 
> This second case was being discarded because PSP communication worked but
> the command returned an error code in the payload header.
> 
> Capture both cases and return them to the caller as -EIO for the caller
> to investigate. The caller can detect the latter by looking at
> `req->header->status`.
> 
> Reported-and-tested-by: Tim Van Patten <timvp@google.com>
> Fixes: 7ccc4f4e2e50 ("crypto: ccp - Add support for an interface for platform features")
> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> ---
> v1->v2:
>  * Update tag for Tim
>  * Reword commit message
> ---
>  drivers/crypto/ccp/platform-access.c | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)

All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt