Received-SPF: pass (google.com: domain of linux-kernel+bounces-78750-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 23 Feb 2024 16:42:35 +0000
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
CC: <linux-iio@vger.kernel.org>, Rob Herring <robh@kernel.org>, Frank Rowand
	<frowand.list@gmail.com>, <linux-kernel@vger.kernel.org>, Julia Lawall
	<Julia.Lawall@inria.fr>, Peter Zijlstra <peterz@infradead.org>, "Greg
 Kroah-Hartman" <gregkh@linuxfoundation.org>, <marek.vasut@gmail.com>
Subject: Re: [PATCH v2 0/4] of: automate of_node_put() - new approach to
 loops.
Message-ID: <20240223164235.00000e46@Huawei.com>
In-Reply-To: <20240223163602.0000697a@Huawei.com>
References: <20240223124432.26443-1-Jonathan.Cameron@huawei.com>
	<Zdi_ToUofu62s5zT@smile.fi.intel.com>
	<20240223163602.0000697a@Huawei.com>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Fri, 23 Feb 2024 16:36:02 +0000
Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:

> On Fri, 23 Feb 2024 17:52:46 +0200
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> 
> > On Fri, Feb 23, 2024 at 12:44:28PM +0000, Jonathan Cameron wrote:
> > > The equivalent device_for_each_child_node_scoped() series for
> > > fwnode will be queued up in IIO for the merge window shortly as
> > > it has gathered sufficient tags. Hopefully the precdent set there
> > > for the approach will reassure people that instantiating the
> > > child variable inside the macro definition is the best approach.
> > > https://lore.kernel.org/linux-iio/20240217164249.921878-1-jic23@kernel.org/
> > > 
> > > v2: Andy suggested most of the original converted set should move to
> > >     generic fwnode / property.h handling.  Within IIO that was
> > >     a reasonable observation given we've been trying to move away from
> > >     firmware specific handling for some time. Patches making that change
> > >     to appropriate drivers posted.
> > >     As we discussed there are cases which are not suitable for such
> > >     conversion and this infrastructure still provides clear benefits
> > >     for them.  
> > 
> > >   iio: adc: rcar-gyroadc: use for_each_available_child_node_scoped()  
> > 
> > Is this the only one so far? Or do we have more outside of IIO?
> > 
> > I'm fine with the code if OF maintainers think it's useful.
> > My concern is to make as many as possible drivers to be converted to
> > use fwnode instead of OF one.
> > 
> Julia wrote a coccinelle script 
> __free() cases (53)
> https://lore.kernel.org/all/alpine.DEB.2.22.394.2401291455430.8649@hadrien/
Gah. Second time today I've hit the wrong key whilst pasting.

loop cases. (73)
https://lore.kernel.org/all/alpine.DEB.2.22.394.2401312234250.3245@hadrien/

Scattered right across the kernel.

No others submitted yet and there is just the one left in IIO after fwnode
conversions.  There are other drivers I haven't converted to fwnode for
various reasons, but this isn't useful for them as not all call of_node_put().

Some of the other cases will be suitable for fwnode conversion and that
is definitely the right first choice in many cases.

Agreed, it's down to the OF maintainers to take a call on whether they want
this infrastructure or not.  No longer matters much to me for IIO
as you can see.

Jonathan