Received-SPF: pass (google.com: domain of linux-kernel+bounces-78382-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <786185.1708694102@warthog.procyon.org.uk>
In-Reply-To: <786185.1708694102@warthog.procyon.org.uk>
From: Marc Dionne <marc.dionne@auristor.com>
Date: Fri, 23 Feb 2024 09:28:28 -0400
Message-ID: <CAB9dFdvDitrof7a4Df1ziJJHnfqNModR7ZxBD971VCZuxyiEZQ@mail.gmail.com>
Subject: Re: [PATCH] afs: Fix endless loop in directory parsing
To: David Howells <dhowells@redhat.com>
Cc: Markus Suvanto <markus.suvanto@gmail.com>, Christian Brauner <brauner@kernel.org>, 
	linux-afs@lists.infradead.org, linux-fsdevel@vger.kernel.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2024 at 9:15=E2=80=AFAM David Howells <dhowells@redhat.com>=
 wrote:
>
>
> If a directory has a block with only ".__afsXXXX" files in it (from
> uncompleted silly-rename), these .__afsXXXX files are skipped but without
> advancing the file position in the dir_context.  This leads to
> afs_dir_iterate() repeating the block again and again.
>
> Fix this by making the code that skips the .__afsXXXX file also manually
> advance the file position.
>
> The symptoms are a soft lookup:
>
>         watchdog: BUG: soft lockup - CPU#3 stuck for 52s! [check:5737]
>         ...
>         RIP: 0010:afs_dir_iterate_block+0x39/0x1fd
>         ...
>          ? watchdog_timer_fn+0x1a6/0x213
>         ...
>          ? asm_sysvec_apic_timer_interrupt+0x16/0x20
>          ? afs_dir_iterate_block+0x39/0x1fd
>          afs_dir_iterate+0x10a/0x148
>          afs_readdir+0x30/0x4a
>          iterate_dir+0x93/0xd3
>          __do_sys_getdents64+0x6b/0xd4
>
> This is almost certainly the actual fix for:
>
>         https://bugzilla.kernel.org/show_bug.cgi?id=3D218496
>
> Fixes: 57e9d49c5452 ("afs: Hide silly-rename files from userspace")
> Signed-off-by: David Howells <dhowells@redhat.com>
> cc: Marc Dionne <marc.dionne@auristor.com>
> cc: Markus Suvanto <markus.suvanto@gmail.com>
> cc: linux-afs@lists.infradead.org
> ---
>  fs/afs/dir.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/afs/dir.c b/fs/afs/dir.c
> index b5b8de521f99..8a67fc427e74 100644
> --- a/fs/afs/dir.c
> +++ b/fs/afs/dir.c
> @@ -479,8 +479,10 @@ static int afs_dir_iterate_block(struct afs_vnode *d=
vnode,
>                     dire->u.name[0] =3D=3D '.' &&
>                     ctx->actor !=3D afs_lookup_filldir &&
>                     ctx->actor !=3D afs_lookup_one_filldir &&
> -                   memcmp(dire->u.name, ".__afs", 6) =3D=3D 0)
> +                   memcmp(dire->u.name, ".__afs", 6) =3D=3D 0) {
> +                       ctx->pos =3D blkoff + next * sizeof(union afs_xdr=
_dirent);
>                         continue;
> +               }
>
>                 /* found the next entry */
>                 if (!dir_emit(ctx, dire->u.name, nlen,

Reviewed-by: Marc Dionne <marc.dionne@auristor.com>

Marc