Received-SPF: pass (google.com: domain of linux-kernel+bounces-78299-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Precedence: bulk
MIME-Version: 1.0
References: <20240223123028.288038-1-brgl@bgdev.pl>
In-Reply-To: <20240223123028.288038-1-brgl@bgdev.pl>
From: Bartosz Golaszewski <brgl@bgdev.pl>
Date: Fri, 23 Feb 2024 13:34:31 +0100
Message-ID: <CAMRc=MdQWAQHzM5ei=-pfghjSRzRFYyxHVXcLgXvjWOmRVLjqw@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: don't put the reference to GPIO device in pinctrl_pins_show()
To: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@linaro.org>, David Arcari <darcari@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Fri, Feb 23, 2024 at 1:30=E2=80=AFPM Bartosz Golaszewski <brgl@bgdev.pl>=
 wrote:
>
> From: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
>
> The call to gpiod_to_gpio_device() does not increase the reference count
> of the GPIO device struct so it must not be decreased. Remove the buggy
> __free() decorator.
>
> Reported-by: David Arcari <darcari@redhat.com>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
> ---
>  drivers/pinctrl/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
> index ee56856cb80c..bbcdece83bf4 100644
> --- a/drivers/pinctrl/core.c
> +++ b/drivers/pinctrl/core.c
> @@ -1644,7 +1644,7 @@ static int pinctrl_pins_show(struct seq_file *s, vo=
id *what)
>         const struct pinctrl_ops *ops =3D pctldev->desc->pctlops;
>         unsigned int i, pin;
>  #ifdef CONFIG_GPIOLIB
> -       struct gpio_device *gdev __free(gpio_device_put) =3D NULL;
> +       struct gpio_device *gdev =3D NULL;
>         struct pinctrl_gpio_range *range;
>         int gpio_num;
>  #endif
> --
> 2.40.1
>

Linus,

Disregard this one, it had no Fixes tag but I didn't press Ctrl-c in time.

Bart