Received-SPF: pass (google.com: domain of linux-kernel+bounces-77663-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Subject: Re: [PATCH] arm: flush: check if the folio is reserved for IMO
 addresses
To: Matthew Wilcox <willy@infradead.org>
CC: <linux-arm-kernel@lists.infradead.org>, <yanaijie@huawei.com>,
	<zhangxiaoxu5@huawei.com>, <wangkefeng.wang@huawei.com>,
	<sunnanyong@huawei.com>, <linux@armlinux.org.uk>, <rppt@linux.ibm.com>,
	<linux-kernel@vger.kernel.org>, <keescook@chromium.org>, <arnd@arndb.de>,
	<m.szyprowski@samsung.com>
References: <20240222140147.1880357-1-liuyongqiang13@huawei.com>
 <ZddUrO7i5KZn57FY@casper.infradead.org>
From: Yongqiang Liu <liuyongqiang13@huawei.com>
Message-ID: <16b0b45c-721b-2e61-65cf-306b160d713d@huawei.com>
Date: Fri, 23 Feb 2024 09:57:29 +0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Thunderbird/78.8.0
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <ZddUrO7i5KZn57FY@casper.infradead.org>
Content-Type: text/plain; charset="gbk"; format=flowed
Content-Transfer-Encoding: 8bit


?? 2024/2/22 22:05, Matthew Wilcox д??:
> On Thu, Feb 22, 2024 at 10:01:47PM +0800, Yongqiang Liu wrote:
>> @@ -296,6 +297,9 @@ void __sync_icache_dcache(pte_t pteval)
>>   		return;
>>   
>>   	folio = page_folio(pfn_to_page(pfn));
>> +	if (test_bit(PG_reserved, &folio->flags))
>> +		return;
> Why are you using PG_foo directly instead of the helpers?
>
> 	if (folio_test_reserved(folio))
> .
Sorry, I will send v2.