Received-SPF: pass (google.com: domain of linux-kernel+bounces-77858-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <5bb0b0a9-3d4c-4303-aa43-38789bee286d@wolfvision.net>
Date: Fri, 23 Feb 2024 08:03:20 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 04/14] media: dt-bindings: media: rockchip,px30-vip: allow
 for different variants
Content-Language: en-US
To: Conor Dooley <conor@kernel.org>
Cc: Mehdi Djait <mehdi.djait.k@gmail.com>,
 =?UTF-8?Q?Th=C3=A9o_Lebrun?= <theo.lebrun@bootlin.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
 Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
 Mauro Carvalho Chehab <mchehab@kernel.org>, Rob Herring
 <robh+dt@kernel.org>, Krzysztof Kozlowski
 <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>,
 Heiko Stuebner <heiko@sntech.de>, Sakari Ailus
 <sakari.ailus@linux.intel.com>, linux-media@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
 linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org
References: <20240220-v6-8-topic-rk3568-vicap-v1-0-2680a1fa640b@wolfvision.net>
 <20240220-v6-8-topic-rk3568-vicap-v1-4-2680a1fa640b@wolfvision.net>
 <20240220-catchy-cupcake-e600e5af7650@spud>
From: Michael Riesch <michael.riesch@wolfvision.net>
Organization: WolfVision GmbH
In-Reply-To: <20240220-catchy-cupcake-e600e5af7650@spud>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?bTRzSUd0S0kwTGF4WEZMYjl4bnBFMVNLZkZLRE1RUHFNVVlKVDJFdnRNWnls?=
 =?utf-8?B?OFZNSHRxcmoxMjF3djNERzhCY0Z0OVBoWTFqbmNjUlZQVDNKZFg3eUYzNFlt?=
 =?utf-8?B?bVRlb2xhQUJycGR5VmlmQVRhNWN4NjlqSTVhSUtuWmVTMjFKSUVheXN5elhT?=
 =?utf-8?B?VUpLcUJsMmx3cWZKTWlWdldPODlzVnNMVk01czExZkg5dU5OVTN1MXVlcW9P?=
 =?utf-8?B?TE1UcDZ4MG1zYVVmbDR0NXhkTmVYMDFDQXV0OHQ4Ny90ZmxxbEJHYTlVcEww?=
 =?utf-8?B?VExob0dwQXhQOE5lbFMzdVQrWEljRGRFbitqUkkwY1pYTW1BZTdTY1hTdmVl?=
 =?utf-8?B?dDJXMWltRVZNcVlPMGh0YVgwblB6ZytEOWRsOFJGNkc3Z0x1aHZzYStzWHV6?=
 =?utf-8?B?aGg5RzllNXVQT2RrMWN2VU1kUXdoR0pVSlE2cktPQlo5bDFRT1daOWp4SDdn?=
 =?utf-8?B?QXFaWWRrc2ZueG81V2piVUdBS1VIL3pDSUI3cEJ6SDREVVM4Y2tuT2EzbUFK?=
 =?utf-8?B?Uk1mSkJkRldlWjY3NnovVU96MUt2UUEreDZsVDdvSFNWYWt5MHNEOWtmczNt?=
 =?utf-8?B?RXZ2NjU3bjljeWdqVmdINURNWVhuR2ZuaFN1VVQ5STN4MmpNbzNoelMrMnc4?=
 =?utf-8?B?SmJ2ZXR6a1puTFZ5S255dTdIaUhQa3FLTnk2WmxwckxTVjIwQXJTTEg0cFRH?=
 =?utf-8?B?eHRuZkN1Mmh4YWRCWVdWQ3dDWnhoM0YvQWxaUDBWZEswYXI1aGJtS3JFRU5D?=
 =?utf-8?B?RVFtaC9tQ0w4allobE00b0xVNmVqbnhBZ2N5V3lNS0JTWkhGZEpUbXhhQ3hO?=
 =?utf-8?B?Qlk1SEZidFAvaUpvcXI3U2VqRmRaSXdsVllaTk1EbFRNd2xZUjFFTHVETEJi?=
 =?utf-8?B?TFdEYmJtdXNHQ0lxOUppenFFSWwzajAzYTIrSGlDMGRSNU1lNXpNZHhuLys4?=
 =?utf-8?B?dm15ZkNZTDE5VFkvVlFEVDRkZjUrQllsck50TVNDZFc5Zm5Lc01rMzJ2c0p0?=
 =?utf-8?B?WElLd0xZWERkRjViNWZwUHlGS2xCSTZBTEw1cE9aNXVJNGhQakp5SkRMQ3BY?=
 =?utf-8?B?ZmhQSXFocFV5eDc3bllYM1RnNDFndnAweE5JT1BySEJGNWxZdkZSdGJnZG1G?=
 =?utf-8?B?bjk0Z2xGNytPZzdGVEV0aENXYXRaa1FWc1ZFMm1sY3FhSUt5WTBWNGJTcURQ?=
 =?utf-8?B?eWlLT2JDcTVHU3FDeW51dzkrajBhbzBjM3hWMmRVTlNNazhsNXcyV1NwOVhv?=
 =?utf-8?B?dlV6QzlzWUtaQ3Irbkd2Y3p0SDYxeUxuRFFRcDdHeWhvaW8rK1pDbjAzakVp?=
 =?utf-8?B?L1paWGpZM1Z2dDBIOUV1RUxFbWYzT3NxdldFTTlxU3FHdWlkUWVEL2NFaDJV?=
 =?utf-8?B?ak1zSnRZRDJvUlMzZzdPUncvUVJlQW9USXFzMzFhOXhCS1NVeTAvMXpoanps?=
 =?utf-8?B?VDVRQ3FHRXJqN3E3YnBKdjQ2am4xcVVEK28zbUE5RkhhZm9qclpyOFQvcHRv?=
 =?utf-8?B?Ti9zVGxBamg1azhPcm5kZngzdmdmUmY0d3lGTUI3L0V1Qmd1TlV6czFzVFZz?=
 =?utf-8?B?YTVsZjZuWGNocGJsSHlpWis0M3dZK2lla050SnBKNC9FVDUyeWdEMWN1UHRv?=
 =?utf-8?B?TldmL094NlAzbmxyWVJQM2NONGRDSUlPU2pQVllHUjlxZXgxVzRCMThWUGdo?=
 =?utf-8?B?bWplZzRtRUhKRzhFMWpjcEZvdmwrVkJxekorYzJYN0tRck5pODFkQTdmZStF?=
 =?utf-8?B?Wkw3VklndTkvUzRrenBYV1kvcTNXQ3RsTDhyc2ZzMWh4RVROeDdxNXk4aHVi?=
 =?utf-8?B?Q0VHMm1aR1RRSE1MQXBkbDRQNUo4VHNKYllCR1BOU3ZGeE9KYko1cTh1MWdM?=
 =?utf-8?B?RjQ0VnN1Q1hPZzZKUXRBQUtpajF6bnhsVmxaSDRObVVJVStOTnNYRTBRemlo?=
 =?utf-8?B?RnJrUUt3d0Q4a08rMmlUVXZuaG96UytZQ3BKMXJmWXhDa3lHN2hob3JINmNi?=
 =?utf-8?B?ODVXcjR0bzI0NlU1OUVCTXNjVERUeUtPb3pRb3ZLaXhYS1ExdkpXUFJUblpr?=
 =?utf-8?B?bHNQMTQwVzZINDRDMkxBRi9SNjhEd0JhOHRmZHdQaHZXdGk1OXRDS3VTSTdK?=
 =?utf-8?B?UlA0ZkMrOUM1SzZFV0MxOEdRTW02Kzd4QXFIV3dkRTc0MUxJRmR1K2hxRE5L?=
 =?utf-8?B?R0E9PQ==?=
X-OriginatorOrg: wolfvision.net
X-MS-Exchange-CrossTenant-Network-Message-Id: df9999dc-6ad7-404c-0c37-08dc343d86b6
X-MS-Exchange-CrossTenant-AuthSource: DU0PR08MB9155.eurprd08.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Feb 2024 07:03:23.8563
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: e94ec9da-9183-471e-83b3-51baa8eb804f
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: F3085bLMR7yz2mBLgoE5AM8t4idEqGXcMzWbOr8qkFSAtK6cporGKOJJy6BZ6Gr2Ro9QBceHsm9G5AlcV9ErwU6YdUjoNnWNjGRw70c+xPU=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB9PR08MB6666

Hi Conor,

On 2/20/24 19:58, Conor Dooley wrote:
> Hey,
> 
> On Tue, Feb 20, 2024 at 10:39:14AM +0100, Michael Riesch wrote:
>> Move the documentation of clocks and resets to a allOf: structure in order
>> to allow for different variants of the IP block.
>>
>> Signed-off-by: Michael Riesch <michael.riesch@wolfvision.net>
>> ---
>>  .../bindings/media/rockchip,px30-vip.yaml          | 58 ++++++++++++++--------
>>  1 file changed, 37 insertions(+), 21 deletions(-)
>>
>> diff --git a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> index 675a1ea47210..7168f166798c 100644
>> --- a/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> +++ b/Documentation/devicetree/bindings/media/rockchip,px30-vip.yaml
>> @@ -24,32 +24,16 @@ properties:
>>    interrupts:
>>      maxItems: 1
>>  
>> -  clocks:
>> -    items:
>> -      - description: ACLK
>> -      - description: HCLK
>> -      - description: PCLK
>> -
>> -  clock-names:
>> -    items:
>> -      - const: aclk
>> -      - const: hclk
>> -      - const: pclk
>> +  clocks: true
>> +
>> +  clock-names: true
> 
> This is, unfortunately, not how we like multiple soc support to be
> handled. Instead, the widest constraints are added at the top level
> and constrained by the allOf. If none of the names etc are shared, at
> least the widest constraints for minItems and maxItems should be able to
> be here.

Just to make sure I got it right:

clocks:
  minItems: 3
  maxItems: 4
  items:
    - const: aclk
    - const: hclk

..

allOf:
..
  - if:
      properties:
        compatible:
          contains:
            const: rockchip,rk3568-vicap
    then:
      properties:
        clocks:
          - const: aclk
          - const: hclk
          - const: dclk
          - const: iclk

Is this the desired way?

> That said, this patch should be squashed with the patch that actually
> adds the other device to the binding.

That can be arranged.

Best regards,
Michael

> 
> Cheers,
> Conor.
> 
>>  
>>    iommus:
>>      maxItems: 1
>>  
>> -  resets:
>> -    items:
>> -      - description: AXI
>> -      - description: AHB
>> -      - description: PCLK IN
>> +  resets: true
>>  
>> -  reset-names:
>> -    items:
>> -      - const: axi
>> -      - const: ahb
>> -      - const: pclkin
>> +  reset-names: true
>>  
>>    power-domains:
>>      maxItems: 1
>> @@ -85,6 +69,38 @@ required:
>>    - clocks
>>    - ports
>>  
>> +allOf:
>> +  - if:
>> +      properties:
>> +        compatible:
>> +          contains:
>> +            const: rockchip,px30-vip
>> +    then:
>> +      properties:
>> +        clocks:
>> +          items:
>> +            - description: ACLK
>> +            - description: HCLK
>> +            - description: PCLK
>> +
>> +        clock-names:
>> +          items:
>> +            - const: aclk
>> +            - const: hclk
>> +            - const: pclk
>> +
>> +        resets:
>> +          items:
>> +            - description: AXI
>> +            - description: AHB
>> +            - description: PCLK IN
>> +
>> +        reset-names:
>> +          items:
>> +            - const: axi
>> +            - const: ahb
>> +            - const: pclkin
>> +
>>  additionalProperties: false
>>  
>>  examples:
>>
>> -- 
>> 2.30.2
>>