Received-SPF: pass (google.com: domain of linux-kernel+bounces-77541-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240222221814.3572215-1-rmoar@google.com>
In-Reply-To: <20240222221814.3572215-1-rmoar@google.com>
From: Daniel Latypov <dlatypov@google.com>
Date: Thu, 22 Feb 2024 15:37:35 -0800
Message-ID: <CAGS_qxqQ09wUppF9s1BgNoj5T2yo8+Yd0RLRBisj5th7Yw97eQ@mail.gmail.com>
Subject: Re: [PATCH] kunit: tool: add parsing of all files in directory
To: Rae Moar <rmoar@google.com>
Cc: shuah@kernel.org, davidgow@google.com, brendan.higgins@linux.dev, 
	kevko@google.com, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 22, 2024 at 2:18=E2=80=AFPM Rae Moar <rmoar@google.com> wrote:
>
> Add ability to parse all files within a directory. Additionally add the
> ability to parse all results in the KUnit debugfs repository.

Nice, I'd been hoping for this.
It's enough to pull me back in for a bit :)

<snip>

>  tools/testing/kunit/kunit.py | 45 ++++++++++++++++++++++++++----------
>  1 file changed, 33 insertions(+), 12 deletions(-)
>
> diff --git a/tools/testing/kunit/kunit.py b/tools/testing/kunit/kunit.py
> index bc74088c458a..827e6dac40ae 100755
> --- a/tools/testing/kunit/kunit.py
> +++ b/tools/testing/kunit/kunit.py
> @@ -511,19 +511,40 @@ def exec_handler(cli_args: argparse.Namespace) -> N=
one:
>
>
>  def parse_handler(cli_args: argparse.Namespace) -> None:
> -       if cli_args.file is None:
> +       parsed_files =3D []

optional: can we annotate the type?
  parsed_files =3D []  # type: List[str]

> +       total_test =3D kunit_parser.Test()
> +       total_test.status =3D kunit_parser.TestStatus.SUCCESS
> +       if cli_args.file_path is None:
>                 sys.stdin.reconfigure(errors=3D'backslashreplace')  # typ=
e: ignore
>                 kunit_output =3D sys.stdin  # type: Iterable[str]

This branch no longer does anything, since we only parse what's in
`parsed_files`

E.g. if you try
$ kunit.py parse $FILENAME
it'll work whereas
$ kunit.py parse < $FILENAME
will do nothing

We'll need to rework the control flow somehow

> -       else:
> -               with open(cli_args.file, 'r', errors=3D'backslashreplace'=
) as f:
> +       elif cli_args.file_path =3D=3D "debugfs":
> +               for (root, _, files) in os.walk("/sys/kernel/debug/kunit"=
):
> +                       for file in files:
> +                               if file =3D=3D "results":
> +                                       parsed_files.append(os.path.join(=
root, file))
> +       elif os.path.isdir(cli_args.file_path):
> +               for (root, _, files) in os.walk(cli_args.file_path):
> +                       for file in files:
> +                               parsed_files.append(os.path.join(root, fi=
le))

just a note here, we could make this a bit terser via
  parsed_files.extend(os.path.join(root, f) for f in files)

and the debugfs branch could be rendered as
  parsed_files.extend(os.path.join(root, f) for f in files if f =3D=3D "res=
ults")

> +       elif os.path.isfile(cli_args.file_path):
> +               parsed_files.append(cli_args.file_path)

nit: should there be an `else` here that prints a warning?

Example that would trigger this case and silently do nothing
$ mkfifo /tmp/example_fifo
$ ./tools/testing/kunit/kunit.py parse /tmp/example_fifo
<no output>


<snip>

> @@ -569,8 +590,8 @@ def main(argv: Sequence[str]) -> None:
>                                             help=3D'Parses KUnit results =
from a file, '
>                                             'and parses formatted results=
')
>         add_parse_opts(parse_parser)
> -       parse_parser.add_argument('file',
> -                                 help=3D'Specifies the file to read resu=
lts from.',
> +       parse_parser.add_argument('file_path',
> +                                 help=3D'Specifies the file path to read=
 results from.',

Should this mention that the make `debugfs` string works?

>                                   type=3Dstr, nargs=3D'?', metavar=3D'inp=
ut_file')

Tangent: would it be useful to allow the user to pass in multiple
files now and set this to nargs=3D'*'?

E.g.
$ kunit.py parse /my/dir/some_prefix*

It would also let people implement their own version of the debugfs logic v=
ia
$ find /other/debugfs/dir -name 'results' | xargs kunit.py parse

That could be useful if the user has recursively copied off the
debugfs from a test machine and wants to inspect it elsewhere, for
example.

Thanks,
Daniel