Received-SPF: pass (google.com: domain of linux-kernel+bounces-76741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Thu, 22 Feb 2024 17:05:53 +0200
From: Andy Shevchenko <andy.shevchenko@gmail.com>
To: Serge Semin <fancer.lancer@gmail.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>, linux-kernel@vger.kernel.org,
	linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: 8250: Use serial8250_do_set_termios for uartclk
 updating
Message-ID: <Zddi0S0Esw-dUVIV@smile.fi.intel.com>
References: <20240222145058.28307-1-fancer.lancer@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240222145058.28307-1-fancer.lancer@gmail.com>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo

On Thu, Feb 22, 2024 at 05:50:56PM +0300, Serge Semin wrote:
> The serial8250_update_uartclk() body was created based on the several
> method calls copied from the serial8250_do_set_termios() function. Seeing
> aside with some other things the later method can update the baud rate
> based on the new reference clock let's just call it instead thus
> simplifying the code a bit.
> 
> Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Link: https://lore.kernel.org/linux-serial/ZczD7KPbeRnY4CFc@black.fi.intel.com
> Signed-off-by: Serge Semin <fancer.lancer@gmail.com>

Thank you! This looks like a good simplification and turning to "one source" of
the same flow principle.

Assuming that it's working on your hardware,
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

-- 
With Best Regards,
Andy Shevchenko