Received-SPF: pass (google.com: domain of linux-kernel+bounces-75226-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Michael Brunner <michael.brunner@kontron.com>
To: "linux@roeck-us.net" <linux@roeck-us.net>, "lee@kernel.org"
	<lee@kernel.org>
CC: "mibru@gmx.de" <mibru@gmx.de>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mfd: kempld-core: don't replace resources provided by
 ACPI
Thread-Topic: [PATCH] mfd: kempld-core: don't replace resources provided by
 ACPI
Thread-Index: AQHaZOjnqjSdKUSjjUiE5C/QNxRHxLEVDr0AgAAEVoA=
Date: Wed, 21 Feb 2024 17:50:31 +0000
Message-ID: <de6bc09c779a4b4fa2ddaa1fa3a595de323b7f5a.camel@kontron.com>
References: <09855448430a5f090dbe09cbb269959a08881ee7.camel@kontron.com>
	 <8ec638c2-93b6-48e4-8ac4-965072b1d5af@roeck-us.net>
In-Reply-To: <8ec638c2-93b6-48e4-8ac4-965072b1d5af@roeck-us.net>
Accept-Language: de-DE, en-US
Content-Language: en-US
user-agent: Evolution 3.36.5-0ubuntu1 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?iso-8859-15?Q?9Hh1W4AMSuVQbyj3FuuVaQ5wCS+S+gmqTnAjJRHq6TId4rmlCpnan2aXV?=
 =?iso-8859-15?Q?UHU/YiT9aeG68d4vkpGBjzkidV3d249teQMRpzh1pLdEzAopIyQ6Dy3Bi?=
 =?iso-8859-15?Q?L+ZlqlwQ8XHzZ5U1JzYU6Hrbm7k5d0P36KUobEB0j6ztay2vqKvcXzxLF?=
 =?iso-8859-15?Q?KfXX7xrTUWcHR634CCCI+m4sZElYnAkw4587Fci+p6ZNH50em3b6X/rLq?=
 =?iso-8859-15?Q?7l2emFg0PDTC7KHVOoJi6Pfma4ceSNcew7Odcg/qWq1rds9QXc/d90yAM?=
 =?iso-8859-15?Q?kef4kVN1HCcf73MkzNnTooda3lwfj1udY/RyqVpOwMGg8yLpEqPK4pA4Y?=
 =?iso-8859-15?Q?a6hTgf/x239YXLPTuWzYEYeegzV4N6L3kMaZ/hQ2EHMuXu6biBjd9gfIj?=
 =?iso-8859-15?Q?nDZniFZaCok6CaZuh2AMDg3sYipLZsd/ARVhF70+jU0MP7JXJiF5jnQ3G?=
 =?iso-8859-15?Q?0Q3cES6NbkP0q+grjMJLTOMB23/t7Npe+QIF4BShZfbPinz00AXbKRS9b?=
 =?iso-8859-15?Q?cZZOjMJ1CbtNJJYTXCfsRjY5cU/5axoRniRcD+lUB9i5RNekSISfB6IC3?=
 =?iso-8859-15?Q?4IZC3wvigKoA9184++RmxCh2CX9F2RjYdJ4Dcbhw8lqdYkQeGb5FYTc8x?=
 =?iso-8859-15?Q?zM+dGAXbrBUVFTI58JdEzVLLFZoB6XgYQFyk3o+XoEwvoRkZveA8DCeTY?=
 =?iso-8859-15?Q?52Qa0Bbui8tlTIUfGqmRYqEbm6tOxGZ9kgeMWbzlSMLfFZsC2RHbn8C18?=
 =?iso-8859-15?Q?E9PjD0Lr21PhmCJpJIny63mSCCyeG+d5fIWq6OnqndZJkL43VWz3UbElS?=
 =?iso-8859-15?Q?s4fdCrBrJ4qagv9zHvJDXgOGMYEtJ216FAXXeGrxcvlKM4UTIMwLpBaqx?=
 =?iso-8859-15?Q?p7Yv/mk84Pm7XM+a6wMYX8E9yOzoMPb4uNau8fnslVtNkojqNU8O2IOVU?=
 =?iso-8859-15?Q?G0tYTZ/t1N8BIjV92DKGIamYy5jCMzfWR9MiTl3DqoJcqQNWHXcoVpdsQ?=
 =?iso-8859-15?Q?gXQTQxrfSdJuB/uwEKCG71rAD0YQakgfc+3sRPAH7wX0rah6ZefhUwnM4?=
 =?iso-8859-15?Q?DCDB0K5MTrMO8hVzncTL41o1/YsOUqPtHCXIhHYxTOCHbX52TPkaXy0Mq?=
 =?iso-8859-15?Q?T168tuJ+pQiE3XxWXehBQBLMPw2Ru/eI7e060nw7LSqrvj2znDsUWtnkE?=
 =?iso-8859-15?Q?ihE3PEyWityI/+l3fk8RhtW+6SWAFdK57FMKNpLlneCWxlb+ftq7anLVQ?=
 =?iso-8859-15?Q?ICoGyfhnbTtvSDZWQUulhwAFhEQrL62qql2F/tfQIlbsCv21Ledueb/Li?=
 =?iso-8859-15?Q?I1pZ4SArNeeKB1iJwuLvOJtiNl52Aw7TaGKpQQ9enFc/ISg9j8Li1f60X?=
 =?iso-8859-15?Q?mhkpGiDQs3yHgs64dezLXcsJuzrhX/Fn+g9b26/3eYeMWZZzTjDgg3xpu?=
 =?iso-8859-15?Q?HnxN9VXjgDKOwJTVJEW0W7euyhuSP2hlt84BjT8CDELvR5VxnZNB9dLmb?=
 =?iso-8859-15?Q?iA4jFss89WDEm0RqbqrZh85ALEGYDdQQHuDhhVKBv9JPtB4moyRW5AZm5?=
 =?iso-8859-15?Q?U+3guJQKMO8cIJ2d98XhGPVTTT3s/VyHcwMyL2mfrTpjF/FWhduYrklDg?=
 =?iso-8859-15?Q?2YEVSj2SVEw6r3LFTnBedixYN96cHnx6DiaFVSKyFvote0WLGcnLI4QJE?=
 =?iso-8859-15?Q?vpl+OU7hU+VtL0DmrCyeuXdCJeAjzdnA2M652HDLTJTXNfk=3D?=
Content-Type: text/plain; charset="iso-8859-15"
Content-ID: <F7360FF35922C6458E795313BDD2F2BA@EURPRD10.PROD.OUTLOOK.COM>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: kontron.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AS2PR10MB7551.EURPRD10.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-Network-Message-Id: 7006633c-aab4-4919-4723-08dc33059952
X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Feb 2024 17:50:31.9737
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8c9d3c97-3fd9-41c8-a2b1-646f3942daf1
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: j8vrCmBoW/GqoxBcJS4DgjKn9v/RGLJ1GhMinQ+7RJt4ZA8DeRAXJ38W2XL2gJbIsCBEQ4S7UA8NDrS2U0KQN7xItS0uVRamrdmSKMraQt8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GVXPR10MB8060

Added Lee Jones again, as I erroneously used an old eMail address in
my original mail.

Thanks Guenter, for the review!

On Wed, 2024-02-21 at 09:34 -0800, Guenter Roeck wrote:
>> The current implementation to retrieve ACPI resources is faulty
>> and may cause issues that even can lead to non-booting systems.
>>
>> When adding data from an ACPI device, the resources are already
>> assigned to the platform device. Therefore there is no need to
>> retrieve the resource list from ACPI and manually assign it to
>> the platform device. Also there shouldn't be any BIOS in the wild
>> anymore, that does not have resources added to the KEMPLD ACPI
>> data.
>>
>> In particular this fixes an issue where the retrieval of the
>> resource list using /proc/ioports is disturbed and does not list
>> the assigned resource for the kempld device or even no resources
>> at all.
>> On some distributions this also leads to problems during system
>> initialization (e.g. with udev) and causes the system to not
>> boot at all.
>>
>> I have reproduced the issue with the following kernel versions:
>>      5.10.209
>>      5.15.148
>>      6.1.25
>>      6.6.17
>>      6.7.5
>>      6.8-rc5
>>
>> The patch applies to all of those versions and seems to resolve
>> the issue.
>>
>> Signed-off-by: Michael Brunner <michael.brunner@kontron.com>
>
>Reviewed-by: Guenter Roeck <linux@roeck-us.net>
>
>> ---
>>   drivers/mfd/kempld-core.c | 37 -------------------------------------
>>   1 file changed, 37 deletions(-)
>>
>> diff --git a/drivers/mfd/kempld-core.c b/drivers/mfd/kempld-core.c
>> index 67af36a38913..5557f023a173 100644
>> --- a/drivers/mfd/kempld-core.c
>> +++ b/drivers/mfd/kempld-core.c
>> @@ -428,50 +428,13 @@ static int kempld_detect_device(struct kempld_devi=
ce_data *pld)
>>   #ifdef CONFIG_ACPI
>>   static int kempld_get_acpi_data(struct platform_device *pdev)
>>   {
>> -     struct list_head resource_list;
>> -     struct resource *resources;
>> -     struct resource_entry *rentry;
>>       struct device *dev =3D &pdev->dev;
>> -     struct acpi_device *acpi_dev =3D ACPI_COMPANION(dev);
>>       const struct kempld_platform_data *pdata;
>>       int ret;
>> -     int count;
>>
>>       pdata =3D acpi_device_get_match_data(dev);
>>       ret =3D platform_device_add_data(pdev, pdata,
>>                                      sizeof(struct kempld_platform_data)=
);
>> -     if (ret)
>> -             return ret;
>> -
>> -     INIT_LIST_HEAD(&resource_list);
>> -     ret =3D acpi_dev_get_resources(acpi_dev, &resource_list, NULL, NUL=
L);
>> -     if (ret < 0)
>> -             goto out;
>> -
>> -     count =3D ret;
>> -
>> -     if (count =3D=3D 0) {
>> -             ret =3D platform_device_add_resources(pdev, pdata->ioresou=
rce, 1);
>> -             goto out;
>> -     }
>> -
>> -     resources =3D devm_kcalloc(&acpi_dev->dev, count, sizeof(*resource=
s),
>> -                              GFP_KERNEL);
>> -     if (!resources) {
>> -             ret =3D -ENOMEM;
>> -             goto out;
>> -     }
>> -
>> -     count =3D 0;
>> -     list_for_each_entry(rentry, &resource_list, node) {
>> -             memcpy(&resources[count], rentry->res,
>> -                    sizeof(*resources));
>> -             count++;
>> -     }
>> -     ret =3D platform_device_add_resources(pdev, resources, count);
>> -
>> -out:
>> -     acpi_dev_free_resource_list(&resource_list);
>>
>>       return ret;
>>   }