Received: by 2002:a05:7412:cfc7:b0:fc:a2b0:25d7 with SMTP id by7csp2300127rdb; Wed, 21 Feb 2024 03:30:27 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUNZX+FI5daToDkTJVjBDF6ghyp08ZNAw73H5fzjUYO3igARwtiKyS0bNbCoSy0DYc/BxmtWmai+8SKsmVq+kSler1VLx62js6nA0/AWA== X-Google-Smtp-Source: AGHT+IGWJ5De/a0qnFrmQ0/UxrMm/yIr3ty8fqwqfCzXQQ8VHMpyyAyAyf8quamioC5HBZ82wav/ X-Received: by 2002:a05:6870:d250:b0:21e:e1d6:bc9b with SMTP id h16-20020a056870d25000b0021ee1d6bc9bmr8798482oac.9.1708515027683; Wed, 21 Feb 2024 03:30:27 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708515027; cv=pass; d=google.com; s=arc-20160816; b=DKxz8WzpUo7LuNgKd7eWMZiaSdO5EEK+pISnnRwz4s3fmEvD24/xqiR7D70fGOV3a3 RtfqcKN/68AnTHKI5Uijq8pMBpGFOtxD5NPZV3hk+vW97ENEHoNbcR973+eq0Tt4ZHsX q7v+SGk7ic4wU+Y3EflBSMKrWt4X9+aYpieRBG6GBxXhmQ4UiwdRCYZoxFqoONADoXHe He3wiR7pv0pOr4fCP3Go09flAWD2gJ2Dd7pLvFWWYGqyroGlhqfsST+gXiabq+HXogCI Cfr/+OHZWopGQapVuLAt8INyZHnC3ijSoqgsL94p3vukTrRlpDZKu0ub0/1QImR/p7KW 4O0w== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date:dkim-signature; bh=SSVOESv1ouZkM2/5AuJNFJzVtbdBmS4tkZkGQIeQZNc=; fh=pjgagO76GDHgfjsaofa/14LBodxg9dAczVN5nVF5pUc=; b=pyTq8y1iq+Msev0mSSQXhdkMTKjiZPyCsjlSkz+X92PswhHjO9p0ENEu7s90SsKIHB CUUy06QeVzNPIGHEAb2YnjBj8pKFtGsPTtGq2abIowlEKOpa6Ip1E2bqimG9WQGfwjIk YMHW3DtDEdHlQAVxhRL/8j6Q1wygiHYS31sqj3PyjYoeZ0mqSgH7pDzwuOpqgg/yyiQd 5XzDqH18OOz1n2vkkqLreKLiVXsoOZv5Jijh9u6hFFZHrDBhXfr8DkqVAAK/3nI0CjDd ZUyZ6/2NO/Ym3QwsVwzwn/b66pXRIYZVK7zuPUH0hHAPeKbltz35kqOxasa7HLErU3hk bUog==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=PrZIPWaa; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-74615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id s20-20020a632c14000000b005dc422f07easi7541411pgs.902.2024.02.21.03.30.27 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 03:30:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-74615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=fail (test mode) header.i=@armlinux.org.uk header.s=pandora-2019 header.b=PrZIPWaa; arc=pass (i=1 dkim=pass dkdomain=armlinux.org.uk dmarc=pass fromdomain=armlinux.org.uk); spf=pass (google.com: domain of linux-kernel+bounces-74615-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-74615-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=armlinux.org.uk Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 2F2D3282EA0 for ; Wed, 21 Feb 2024 11:30:27 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A835345BF6; Wed, 21 Feb 2024 11:30:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b="PrZIPWaa" Received: from pandora.armlinux.org.uk (pandora.armlinux.org.uk [78.32.30.218]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F694405E8; Wed, 21 Feb 2024 11:29:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=78.32.30.218 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708515007; cv=none; b=N9EiA1GngQKfPHZJq0gYLzt0d/dWGTTwrg4MS7s/Y77bwklghYYUrExPYTcTC0Y61GdeOYeGzx0zXP4ozjiJmR1QAMtcTlsCDfvsedBWSAUaqbSVsxFhrRedyyh0ES0WB0bkQLjwVOhzR6HFK+4JrRYvE7wx/AWqDVpCyDt5ciM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708515007; c=relaxed/simple; bh=ucM4edUsqzv8Ls7SULOGtp/8Oxx9IEhRBg9kA4YNVu0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=p7QTkFQeDKO4td3BpADuZM1YKWBSjbACeU9sPj6G9Sp2Plk8yGOpf8eBEfw6kqbF4dsF25ABsANdFxfDEfW2b56Rag1hAmpQsmiftylw+Pn8wEsXzTfHlSNYhpzsJGZ/aNyuaxo6a/Mu2P7iCRDOxqiD/Bj6iefBtbYATUkoxLE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk; spf=none smtp.mailfrom=armlinux.org.uk; dkim=pass (2048-bit key) header.d=armlinux.org.uk header.i=@armlinux.org.uk header.b=PrZIPWaa; arc=none smtp.client-ip=78.32.30.218 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=armlinux.org.uk Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=armlinux.org.uk DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=armlinux.org.uk; s=pandora-2019; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=SSVOESv1ouZkM2/5AuJNFJzVtbdBmS4tkZkGQIeQZNc=; b=PrZIPWaa3hBql87223JXy2t5YA IM2zkmuVB5BvPuVRumwKCUNn7yRYYDJqODbZXFdk4V/o+b/JtJU5XNkshOASjkhVCsZ0n6mSFDnUO V7ztAEHqCRzhgCYaD3NHC/FhA/FDb4mfKzlKaL4h2GL4WKAah/jv+AcclDDT87ofVozSys6ZxrVG/ hN56zXktXckmIWmF3Go9MNZRmmOFADwN1NkjWmGG2xA9C6vCAay6qxrzDrb6HMHkIEJvLLP5eW3Cy 3NXrtRaCbcKZoL2/w7xPGwuFMf0fyrKWNpwEHpCcf5+Uj+gKgFYSdYsGRgI+jy/lcYnUgUL7Lj1UB lfSfUjvQ==; Received: from shell.armlinux.org.uk ([fd8f:7570:feb6:1:5054:ff:fe00:4ec]:59440) by pandora.armlinux.org.uk with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rcknF-0006oc-1S; Wed, 21 Feb 2024 11:29:41 +0000 Received: from linux by shell.armlinux.org.uk with local (Exim 4.94.2) (envelope-from ) id 1rcknC-0001jr-96; Wed, 21 Feb 2024 11:29:38 +0000 Date: Wed, 21 Feb 2024 11:29:38 +0000 From: "Russell King (Oracle)" To: Kees Cook Cc: Mark Brown , Ard Biesheuvel , Wang Kefeng , Andrew Morton , Ben Hutchings , linux-arm-kernel@lists.infradead.org, Hugh Dickins , linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH] ARM: fault: Implement copy_from_kernel_nofault_allowed() Message-ID: References: <20240123011238.work.301-kees@kernel.org> <202402202235.A77C9AD@keescook> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202402202235.A77C9AD@keescook> Sender: Russell King (Oracle) On Tue, Feb 20, 2024 at 10:39:15PM -0800, Kees Cook wrote: > On Mon, Jan 22, 2024 at 05:12:38PM -0800, Kees Cook wrote: > > Under PAN emulation when dumping backtraces from things like the > > LKDTM EXEC_USERSPACE test[1], a double fault (which would hang a CPU) > > would happen because of dump_instr() attempting to read a userspace > > address. Make sure copy_from_kernel_nofault() does not attempt this > > any more. > > > > Reported-by: Mark Brown > > Link: https://lore.kernel.org/all/202401181125.D48DCB4C@keescook/ [1] > > Suggested-by: "Russell King (Oracle)" > > Cc: Russell King > > Cc: Ard Biesheuvel > > Cc: Wang Kefeng > > Cc: Andrew Morton > > Cc: Ben Hutchings > > Cc: linux-arm-kernel@lists.infradead.org > > Signed-off-by: Kees Cook > > Russell, do you mind if I carry in my tree the 3 ARM patches I sent? > They're mostly pretty trivial, and they've been in "Incoming"[1] for 2 > weeks but haven't shown up in -next yet. I'd really like them to get > some soak time, and for them to reach the v6.9 merge window in time. They can't show up in -next at the moment because the machine that hosts my git tree is being moved between data centres. This was originally flagged as a same-day (Tuesday) move, then next day, then it'll be back online on Saturday. That's the last update that we've had. As I don't believe my GPG key has the necessary signatures on, I don't believe I can get a kernel.org account. I'm not even sure whether my gpg key is even correct for that - and at the moment I just glaze over reading the kernel.org gpg documentation. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!