Received-SPF: pass (google.com: domain of linux-kernel+bounces-71282-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <fe5d0d5c3cdebc8d637c348f3759330166604bb0.camel@iokpp.de>
Subject: Re: [PATCH v3] PCI: Increase maximum PCIe physical function number
 to 7 for non-ARI devices
From: Bean Huo <beanhuo@iokpp.de>
To: Siddharth Vadapalli <s-vadapalli@ti.com>
Cc: bhelgaas@google.com, helgaas@kernel.org, 
	sathyanarayanan.kuppuswamy@linux.intel.com, linux-pci@vger.kernel.org, 
	linux-kernel@vger.kernel.org, Bean Huo <beanhuo@micron.com>, 
	stable@vger.kernel.org
Date: Mon, 19 Feb 2024 13:09:14 +0100
In-Reply-To: <37d21806-d964-40e0-a5a5-3173996e601f@ti.com>
References: <20240219112422.54657-1-beanhuo@iokpp.de>
	 <37d21806-d964-40e0-a5a5-3173996e601f@ti.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Mon, 2024-02-19 at 17:30 +0530, Siddharth Vadapalli wrote:
> The function "next_fn()" seems to provide the next valid function.
> Therefore, if the current function is 0 (fn =3D 0), then the next valid
> function will be 1 which is returned by next_fn(). It extends
> similarly
> until the case where current function is 6 (fn =3D 6) which shall
> return
> the next valid function as 7. So all 8 PFs are still treated as valid
> and there doesn't seem to be any limitation. Only in the case where
> the
> EP doesn't support ARI (there is no function 8 (fn =3D 8)), the call to
> next_fn() with the fn parameter set to 7, will return -ENODEV which
> seems to be the expected behavior.
>=20
> Regards,
> Siddharth.

yes, you are right, the fn 7 has no next_fn, hence should return -
ENODEV.=20

ignore this patch!

kind regards,
Bean