Received-SPF: pass (google.com: domain of linux-kernel+bounces-74306-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <0fa819d1-2a0f-4243-8e5f-a098528278c3@gmail.com>
Date: Wed, 21 Feb 2024 10:29:30 +0200
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v13 1/3] dt-bindings: adc: add AD7173
To: David Lechner <dlechner@baylibre.com>
Cc: linus.walleij@linaro.org, brgl@bgdev.pl, andy@kernel.org,
 linux-gpio@vger.kernel.org, Lars-Peter Clausen <lars@metafoo.de>,
 Jonathan Cameron <jic23@kernel.org>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Michael Walle <michael@walle.cc>,
 Andy Shevchenko <andy.shevchenko@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
 ChiaEn Wu <chiaen_wu@richtek.com>, Niklas Schnelle <schnelle@linux.ibm.com>,
 =?UTF-8?Q?Leonard_G=C3=B6hrs?= <l.goehrs@pengutronix.de>,
 Mike Looijmans <mike.looijmans@topic.nl>, Haibo Chen <haibo.chen@nxp.com>,
 Hugo Villeneuve <hvilleneuve@dimonoff.com>,
 Ceclan Dumitru <dumitru.ceclan@analog.com>, linux-iio@vger.kernel.org,
 devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240220094344.17556-1-mitrutzceclan@gmail.com>
 <CAMknhBEZ7Y1Yx=wJGnfvYWGKPLas3pbCyY+sN8vrBzdkYO-A4w@mail.gmail.com>
Content-Language: en-US
From: Ceclan Dumitru <mitrutzceclan@gmail.com>
In-Reply-To: <CAMknhBEZ7Y1Yx=wJGnfvYWGKPLas3pbCyY+sN8vrBzdkYO-A4w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit


On 2/20/24 22:54, David Lechner wrote:
> On Tue, Feb 20, 2024 at 3:43 AM Dumitru Ceclan <mitrutzceclan@gmail.com> wrote:

..

>> +  clocks:
>> +    maxItems: 1
>> +    description: |
> 
> Don't need `|` here.
> 
The description contains ": ". Without '|' yaml syntax considers the
whole string before ':' as another attribute

>> +      Optional external clock source. Can include one clock source: external
>> +      clock or external crystal.
>> +

..

>> +
>> +      diff-channels:
>> +        items:
>> +          minimum: 0
>> +          maximum: 31
>> +
> 
> Are we missing `bipolar: true` here? (since we have
> unevaluatedProperties: false)
> 

No, since we are referencing the adc schema "$ref: adc.yaml"
Which contains:
"""
  bipolar:

    $ref: /schemas/types.yaml#/definitions/flag

    description: If provided, the channel is to be used in bipolar mode.
"""


..

>> +
>> +required:
>> +  - compatible
>> +  - reg
> 
> Aren't the various power supplies supposed to be required?
> 
> - avdd-supply
> - avdd2-supply
> - iovdd-supply

From my point of view, if someone uses a single supply (avdd == avdd2 ==
iovdd), and uses only the internal reference then the supplies should
not necessarily be required.