Received-SPF: pass (google.com: domain of linux-kernel+bounces-73475-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 20 Feb 2024 17:55:36 +0000
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: Vasileios Amoiridis <vassilisamir@gmail.com>
CC: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, <jic23@kernel.org>,
	<lars@metafoo.de>, <ang.iglesiasg@gmail.com>, <linus.walleij@linaro.org>,
	<semen.protsenko@linaro.org>, <linux-iio@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drivers: iio: pressure: Fixes BMP38x and BMP390 SPI
 support
Message-ID: <20240220175536.00007440@Huawei.com>
In-Reply-To: <20240220174624.GA27576@vamoiridPC>
References: <20240219191359.18367-1-vassilisamir@gmail.com>
	<ZdSyljwOyxIY7Gvb@smile.fi.intel.com>
	<20240220174624.GA27576@vamoiridPC>
Organization: Huawei Technologies Research and Development (UK) Ltd.
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

On Tue, 20 Feb 2024 18:46:24 +0100
Vasileios Amoiridis <vassilisamir@gmail.com> wrote:

> On Tue, Feb 20, 2024 at 04:09:26PM +0200, Andy Shevchenko wrote:
> > On Mon, Feb 19, 2024 at 08:13:59PM +0100, Vasileios Amoiridis wrote:  
> > > According to the datasheet of BMP38x and BMP390 devices, for an SPI
> > > read operation the first byte that is returned needs to be dropped,
> > > and the rest of the bytes are the actual data returned from the
> > > sensor.  
> > 
> > ...
> >   
> > >  #include <linux/spi/spi.h>
> > >  #include <linux/err.h>
> > >  #include <linux/regmap.h>
> > > +#include <linux/bits.h>  
> > 
> > I see that it's unsorted, but try to squeeze a new header to the better place
> > where more will be kept sorted. With given context, it should go before all
> > others, but it might be even better location.
> > 
> > ...
> >   
> 
> So you would suggest a re-ordering of the headers with a reverse
> christmas-tree? I don't see it used in the other drivers of the IIO
> subsystem but I can do it as well
Separate patch + alphabetical but in blocks.

linux/*
then
linux/iio/*
then
asm/*

First 2 can be combined though if you prefer that. Any asm definitely separate.

> 
> > > +static int bmp380_regmap_spi_read(void *context, const void *reg,
> > > +				  size_t reg_size, void *val, size_t val_size)
> > > +{
> > > +	struct spi_device *spi = to_spi_device(context);
> > > +	u8 rx_buf[4];
> > > +	ssize_t status;
> > > +
> > > +	/*
> > > +	 * Maximum number of consecutive bytes read for a temperature or
> > > +	 * pressure measurement is 3.
> > > +	 */
> > > +	if (val_size > 3)
> > > +		return -EINVAL;
> > > +	/*
> > > +	 * According to the BMP3xx datasheets, for a basic SPI read opertion,
> > > +	 * the first byte needs to be dropped and the rest are the requested
> > > +	 * data.
> > > +	 */
> > > +	status = spi_write_then_read(spi, reg, 1, rx_buf, val_size + 1);
> > > +	if (status)
> > > +		return status;  
> >   
> > > +	memcpy(val, rx_buf + 1, val_size);  
> > 
> > Okay, endianess is defined in the regmap_bus below...
> >   
> > > +	return 0;
> > > +}  
> > 
> > -- 
> > With Best Regards,
> > Andy Shevchenko
> > 
> >   
>