Received-SPF: pass (google.com: domain of linux-kernel+bounces-87925-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 1 Mar 2024 12:58:29 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Sagi Shahar <sagis@google.com>
CC: <linux-kselftest@vger.kernel.org>, Ackerley Tng <ackerleytng@google.com>,
	Ryan Afranji <afranji@google.com>, Erdem Aktas <erdemaktas@google.com>,
	"Isaku Yamahata" <isaku.yamahata@intel.com>, Sean Christopherson
	<seanjc@google.com>, Paolo Bonzini <pbonzini@redhat.com>, Shuah Khan
	<shuah@kernel.org>, "Peter Gonda" <pgonda@google.com>, Haibo Xu
	<haibo1.xu@intel.com>, Chao Peng <chao.p.peng@linux.intel.com>, Vishal
 Annapurve <vannapurve@google.com>, Roger Wang <runanwang@google.com>, Vipin
 Sharma <vipinsh@google.com>, <jmattson@google.com>, <dmatlack@google.com>,
	<linux-kernel@vger.kernel.org>, <kvm@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v5 08/29] KVM: selftests: TDX: Add TDX lifecycle test
Message-ID: <ZeFgdUdV0fAK2Cq+@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231212204647.2170650-1-sagis@google.com>
 <20231212204647.2170650-9-sagis@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231212204647.2170650-9-sagis@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?PGVJwyjN77NjhWJbSlWsWYKpdhml03xzBE5PuMhN7ViaKmm5GXzE59EbXKBT?=
 =?us-ascii?Q?dN/kp7CTXeXIh1nOSAUzYkdjhzgmTaLxDWm/Ao+ma9bHY/pyT/zFN0NFSHV/?=
 =?us-ascii?Q?Qi5Wu4IKTsBmTJ5w0AzIJqQldwyxobubayYlBA9wK/vn77aCnkvYniIBSL5e?=
 =?us-ascii?Q?z4bp/gD+YijW7fZ2KnGxujyukS2PQRmKZZtcWEfvK9ZkzKt0IcBQhyv7jRwQ?=
 =?us-ascii?Q?oFqKcKZ0Bq27bDBwe/MYgnaTGldOjzHJOR/zNV+0o8WFnbqCND2dTG1DaMDz?=
 =?us-ascii?Q?BGevYVWepov8A2hvEGjchFGV21g87amlYhl0fHKAIX9KNbnRXkhnbtiHs4iI?=
 =?us-ascii?Q?BDZ8SDGktnEAXd6Hg9hLDFgscaYCXvy2umb5e03rOePSkx+1cn9YZu53dn6d?=
 =?us-ascii?Q?4GvPGjlJWuUMv8TyDPCCaW1tjkIe+PfEeVr8adf2kzVreoXr2ojTQXXKoRWG?=
 =?us-ascii?Q?tshsut1ejDV0JtzxaDe6KI7lspWyJSri7Gj1adNh6tDB65cyGErP+DWqp5uy?=
 =?us-ascii?Q?qvCgu1iWPLYEKjt+AMzaX1tjZ3deeWk8VbszvZBBIJtrbhOd1F5AimbrC3CZ?=
 =?us-ascii?Q?YU+HTNNVDIgWpg7v8w5NkpyOYH0q4X2jw39UnOWdK6jlGZ2ZHSxNK8gAluMU?=
 =?us-ascii?Q?Zl36g01QepM3G4hbVy3UnkhKvbRAgx+XkNNuRRNby/r5kWEJO1fFdikS6Niz?=
 =?us-ascii?Q?gi7GA0666G1xuheGSkFyiiiCJLIogikbnJODT9rT1+vz+8FsB02SJwRuPwAt?=
 =?us-ascii?Q?amPm0hYK0lNjy47JRbA0QQSOeJidNXoQ4Z/w5xctmoOP4PCRkH68KdZb3GKE?=
 =?us-ascii?Q?8Cavrt98TEdxZRiQFbVySTFqmWxqLEeZ0WCige0dhPV97bm4zXrr8LVnoiYj?=
 =?us-ascii?Q?BUyjmqr+XwKKnC1OSNdGF4Wje1Mx2EM7OwB0vZsXUddXLXm939d2pori+PAM?=
 =?us-ascii?Q?rIMfbK1G+D9dNxv5JVX3UJXaLva7XM8UWF3U8QrNa6XGS2RFbJBbkVFx5gzJ?=
 =?us-ascii?Q?tx/oWnun3d4LHb0p0d+ffLTxkqPIM9oYknwoqEzVPpnyxnsWgQwrVra2b3vD?=
 =?us-ascii?Q?UJW0LmgiWlZB5TFJe24L7URTtF6u4iyK072phGqXO2+FvKu8Fz06tgWEQmNb?=
 =?us-ascii?Q?gEF0+vn2c6wYLRTw6Jp4rwqmVOI3RRGVq+zu7BhvK+YK7OfUTNTAnVhlzf7T?=
 =?us-ascii?Q?PSFfD/odcZIMQKk9svoQ+MFDTYXattgDA+gMh+tj9Up+aFlHHPvZRBDb3Am4?=
 =?us-ascii?Q?9/U6tqvPMHGS4uHL1eAyEazq9dMywxaVsYgIhudoNuykuEnkA2rT0qaJyof+?=
 =?us-ascii?Q?39BLM3SicAlcOrk3cI+T7YnQzT4FlwMB7Z+uSGEJ6TGxuBMnxkK4PnzCj8dW?=
 =?us-ascii?Q?beDtziv1dXrZl04fzJNUz4wVwhCvIwORmTx6HfbOLlo1JV+mf/obBU8LfEjH?=
 =?us-ascii?Q?bfTSDc5CbGhJKQbTRz1oM4MBV3knq8V8nSksDvxoOiIC+D0CxX2bt2XG3iW6?=
 =?us-ascii?Q?YrVwFL5/Wsj4TojEd6rjJ2N4yTaR6arUNICd4g8qlq6EZF4W5TcehjjelhKz?=
 =?us-ascii?Q?Vu7k3XdVwxyAVIu7GhLE5OWqAAZ4v9kgRSNGxdgJ?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e4f0c6b9-8149-4bfd-da3d-08dc39b06736
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 05:28:19.2524
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qLRNc9s8yk1IUD7qGbisK1TN0I4D4LR54cz9C503dd+I8WCOFTx7qck0HZOqyEadP8ax0Fbha8lVkxlT2Knydw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR11MB6925
X-OriginatorOrg: intel.com

> diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S
> new file mode 100644
> index 000000000000..df9c1ed4bb2d
> --- /dev/null
> +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S
> @@ -0,0 +1,90 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +/* Adapted from arch/x86/coco/tdx/tdcall.S */
> +
> +#define TDX_HYPERCALL_r10 0 /* offsetof(struct tdx_hypercall_args, r10) */
> +#define TDX_HYPERCALL_r11 8 /* offsetof(struct tdx_hypercall_args, r11) */
> +#define TDX_HYPERCALL_r12 16 /* offsetof(struct tdx_hypercall_args, r12) */
> +#define TDX_HYPERCALL_r13 24 /* offsetof(struct tdx_hypercall_args, r13) */
> +#define TDX_HYPERCALL_r14 32 /* offsetof(struct tdx_hypercall_args, r14) */
> +#define TDX_HYPERCALL_r15 40 /* offsetof(struct tdx_hypercall_args, r15) */
> +
> +/*
> + * Bitmasks of exposed registers (with VMM).
> + */
> +#define TDX_R10 0x400
> +#define TDX_R11 0x800
> +#define TDX_R12 0x1000
> +#define TDX_R13 0x2000
> +#define TDX_R14 0x4000
> +#define TDX_R15 0x8000
> +
> +#define TDX_HCALL_HAS_OUTPUT 0x1
> +
> +/*
> + * These registers are clobbered to hold arguments for each
> + * TDVMCALL. They are safe to expose to the VMM.
> + * Each bit in this mask represents a register ID. Bit field
> + * details can be found in TDX GHCI specification, section
> + * titled "TDCALL [TDG.VP.VMCALL] leaf".
> + */
> +#define TDVMCALL_EXPOSE_REGS_MASK	( TDX_R10 | TDX_R11 | \
> +					  TDX_R12 | TDX_R13 | \
> +					  TDX_R14 | TDX_R15 )
> +
> +.code64
> +.section .text
> +
> +.globl __tdx_hypercall
> +.type __tdx_hypercall, @function
> +__tdx_hypercall:
> +	/* Set up stack frame */
> +	push %rbp
> +	movq %rsp, %rbp
> +
> +	/* Save callee-saved GPRs as mandated by the x86_64 ABI */
> +	push %r15
> +	push %r14
> +	push %r13
> +	push %r12
> +
> +	/* Mangle function call ABI into TDCALL ABI: */
> +	/* Set TDCALL leaf ID (TDVMCALL (0)) in RAX */
> +	xor %eax, %eax
> +
> +	/* Copy hypercall registers from arg struct: */
> +	movq TDX_HYPERCALL_r10(%rdi), %r10
> +	movq TDX_HYPERCALL_r11(%rdi), %r11
> +	movq TDX_HYPERCALL_r12(%rdi), %r12
> +	movq TDX_HYPERCALL_r13(%rdi), %r13
> +	movq TDX_HYPERCALL_r14(%rdi), %r14
> +	movq TDX_HYPERCALL_r15(%rdi), %r15
> +
> +	movl $TDVMCALL_EXPOSE_REGS_MASK, %ecx
> +
> +	tdcall
Looks there's a missing of definition for tdcall, and will produce below
error:
lib/x86_64/tdx/tdcall.S:65: Error: no such instruction: `tdcall'

I pulled the code https://github.com/googleprodkernel/linux-cc.git with
branch tdx-selftests-rfc-v5.

Fixed by adding a line in tdcall.S in my side.
#define tdcall          .byte 0x66,0x0f,0x01,0xcc

> +
> +	/* TDVMCALL leaf return code is in R10 */
> +	movq %r10, %rax
> +
> +	/* Copy hypercall result registers to arg struct if needed */
> +	testq $TDX_HCALL_HAS_OUTPUT, %rsi
> +	jz .Lout
> +
> +	movq %r10, TDX_HYPERCALL_r10(%rdi)
> +	movq %r11, TDX_HYPERCALL_r11(%rdi)
> +	movq %r12, TDX_HYPERCALL_r12(%rdi)
> +	movq %r13, TDX_HYPERCALL_r13(%rdi)
> +	movq %r14, TDX_HYPERCALL_r14(%rdi)
> +	movq %r15, TDX_HYPERCALL_r15(%rdi)
> +.Lout:
> +	/* Restore callee-saved GPRs as mandated by the x86_64 ABI */
> +	pop %r12
> +	pop %r13
> +	pop %r14
> +	pop %r15
> +
> +	pop %rbp
> +	ret
> +
> +/* Disable executable stack */