Received-SPF: pass (google.com: domain of linux-kernel+bounces-87939-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Message-ID: <tencent_3F31ADAB6142D8948E5BD02B854ED2A77106@qq.com>
From: linke <lilinke99@qq.com>
Content-Type: text/plain;
	charset=us-ascii
Content-Transfer-Encoding: 7bit
Precedence: bulk
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.100.2.1.4\))
Subject: Re: [PATCH] ring-buffer: use READ_ONCE() to read
 cpu_buffer->commit_page in concurrent environment
Date: Fri, 1 Mar 2024 13:37:18 +0800
Cc: lilinke99@qq.com,
 linux-kernel@vger.kernel.org,
 linux-trace-kernel@vger.kernel.org,
 mathieu.desnoyers@efficios.com,
 mhiramat@kernel.org
To: rostedt@goodmis.org

> So basically you are worried about read-tearing?
> 
> That wasn't mentioned in the change log.

Yes. Sorry for making this confused, I am not very familiar with this and
still learning.

> Funny part is, if the above timestamp read did a tear, then this would
> definitely not match, and would return the correct value. That is, the
> buffer is not empty because the only way for this to get corrupted is if
> something is in the process of writing to it.

I agree with you here.

	commit = rb_page_commit(commit_page);

But if commit_page above is the result of a torn read, the commit field
read by rb_page_commit() may not represent a valid value. 

In this case, READ_ONCE() is only needed for the commit_page.