Received-SPF: pass (google.com: domain of linux-kernel+bounces-87959-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Thu, 29 Feb 2024 22:33:13 -0800
From: Kees Cook <keescook@chromium.org>
To: Josh Poimboeuf <jpoimboe@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, oe-kbuild-all@lists.linux.dev,
	kernel test robot <lkp@intel.com>,
	Alexander Lobakin <aleksander.lobakin@intel.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] objtool: Fix UNWIND_HINT_{SAVE,RESTORE} across basic
 blocks
Message-ID: <202402292232.2D9E913F@keescook>
References: <202402240702.zJFNmahW-lkp@intel.com>
 <202402231632.D90831AE51@keescook>
 <20240227073527.avcm5naavbv3cj5s@treble>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240227073527.avcm5naavbv3cj5s@treble>

On Mon, Feb 26, 2024 at 11:35:27PM -0800, Josh Poimboeuf wrote:
> On Fri, Feb 23, 2024 at 04:45:22PM -0800, Kees Cook wrote:
> > Josh, Peter, can you give a clue about what's happened here? For
> > added context, the referenced commit is changing a noreturn function
> > prototype[1], which I know gets some special objtool handling, but it's
> > converting a pointer arg to a u8... I can't imagine what has gone weird
> > here. :P
> 
> I think this convinced GCC to reshuffle some basic blocks, which
> uncovered an objtool bug.  Or, objtool just wasn't smart enough, as the
> warning says ;-)
> 
> This should fix it, absent any more warnings.  Kees, feel free to take
> it in your branch if that helps.

Thanks very much! I'll carry it in my tree.

-Kees

-- 
Kees Cook