Received-SPF: pass (google.com: domain of linux-kernel+bounces-87974-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID:
 <SEZPR06MB6959D0455614D656467417A9965E2@SEZPR06MB6959.apcprd06.prod.outlook.com>
Date: Fri, 1 Mar 2024 14:49:32 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH net-next v7 7/9] net: hisi_femac: remove unused compatible
 strings
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
 Yisen Zhuang <yisen.zhuang@huawei.com>, Salil Mehta
 <salil.mehta@huawei.com>, "David S. Miller" <davem@davemloft.net>,
 Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>,
 Paolo Abeni <pabeni@redhat.com>, Rob Herring <robh+dt@kernel.org>,
 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
 Conor Dooley <conor+dt@kernel.org>, Andrew Lunn <andrew@lunn.ch>,
 Heiner Kallweit <hkallweit1@gmail.com>, Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
 devicetree@vger.kernel.org
References: <20240301-net-v7-0-45823597d4d4@outlook.com>
 <20240301-net-v7-7-45823597d4d4@outlook.com>
 <a24320b7-5cf2-4a6d-af7f-d07dfd0dc29a@linaro.org>
From: Yang Xiwen <forbidden405@outlook.com>
In-Reply-To: <a24320b7-5cf2-4a6d-af7f-d07dfd0dc29a@linaro.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SEZPR06MB6959:EE_|SEYPR06MB5940:EE_
X-MS-Office365-Filtering-Correlation-Id: fbc17180-d7fb-449c-53d1-08dc39bbc365
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info:
	U+nSEz/sTIvLTMqsF1Io47GMbl473f6Mn9etkIxRRxY/2wZf5RR22c24ZTV6pU1oHvOj9mxDUjLb08W3b9HpLdaxYNQmOuAb8Uda60kvYo+Z/TLZIWjsgwoLdF8Tx5y10rsHApsF4jQxjtbLPwKbbU7cEfumi8ho1xngZA5lxpcmCd0yPTbWzHAXU5joB17DKSoOkcRc9blHvYN4XbeOIoAHx3kpX3yg418PN59m9twsKFgK6yEROSQD4OFI6W/UEvqevD2GzJTMJixKheZIUm6ewyqrCli72AkDiEK3JWyWNrTTovmMSILlVpmLiNP77PBz/Vxvzh+awavEa+CKHY2SibaP2hEAEKJVpCRVhGfGZgCyy35pDaSx1RJ61LB0J4hywe5z5nLgc7py1z4+ApT4DDcikaKfNupFGXF64GFB3Jhh/e0ravg1Dw0uI6CmwnmJBH/Gb4w33sG7sJr8CprEIcN78HG51zJcFtc3lY+bR7dmIYMqN2iNFJZHRLaWOu96SPWPREUNKVTfO8ufgXhPUsK/SAsIcsbBfsBIWMGlrD/CqQX1+vHJOIdZGaDT
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?V2pEeDlvbzZRS0tYUHR0Q0ltdGZoV3lGNHo0M0tBZlYvZXV1RllqSld5Wk1o?=
 =?utf-8?B?NFVTNEFkRFJWZmVnZWRSd0N0WjJCQ1E2ckpQMW1yYkd3dWVEVGt0OXMwZy9O?=
 =?utf-8?B?ZjVuNlQzMUxWV0xwT0dRaWJlTGdRUy94TDU1UGdkV3ZXcVFmSk04SW96QS9Y?=
 =?utf-8?B?dUJtYlZUTUlPankxek40Y1JnYWtZT2s1SlBjNFlwTzZ5NVo4SlRvUDdOdEp5?=
 =?utf-8?B?S0dLaVJJVmlLdUVRWDl6NUpyZnd2eFcvRU5lc2NSQkgvN01yNERPSmVkVkRs?=
 =?utf-8?B?SmNrbkpzQVR1OWJ3dldKZjFRQU5peTVWRkJIZVorc3BOU0JQb21KNkswQ3BS?=
 =?utf-8?B?VXhTaVZUNlV1bi9aMVQ0UkRnUkVlRnIxY3JzUTllQ1JFNEtoeUMzZU94cTNs?=
 =?utf-8?B?Um1xVGFCcVR2ZTVEMS9ZbkNHMzJROVc1Y2lPS093VGlsdGZONXRWNytrZmJW?=
 =?utf-8?B?aS8wNnk5cjcrY0p3ZERLZ3dDaTF2SWhDeUlvRVdPaVNkM1dFd1Ftck5UaFpU?=
 =?utf-8?B?QmQ1ZzZkd3k1NDFCbmVsUnJuSnd3VlB0TC8zc1ZtVWpaVEIyalZIM2R3Z1RO?=
 =?utf-8?B?alh3Zy9Td0M2UlJsOCtYOEdsMFdLY3JCdm80dnFnNTBZM1c0cHRRdDY5MWRl?=
 =?utf-8?B?dW5HbmlvY3BSWVNmZ1hGdm4vNFZ3VTVhNFR4UnExUjNTdU5adHBNSVJsaXU4?=
 =?utf-8?B?MDY2Z3JiMU9kVit5RUd0QWM2TXpyMWpCcDJqV1lrd0JwM3lVNmZoc3lGV09W?=
 =?utf-8?B?L3ZWOHArWDRiYlpzOHNsaTh6L3pEd3YwYUJQT09yUjlTcE1CKytwR3pKdWxU?=
 =?utf-8?B?ZnBuQUR1cmJVS3YxaE5NbFZZamd2OGtVaWRvOGhaazlxREFWSmZ4bm9OK3RN?=
 =?utf-8?B?RUV5UzJ2anlPNHhMK0orOXhjQTFQREt5a2NuT0htd2NWdHJhRjBLQ2tmeStj?=
 =?utf-8?B?VnJTdjZwNHlJd3QxNUFRRldNOEF6UHI2NC82QWVyVFBVcFdCOE1SSmVzcUl3?=
 =?utf-8?B?U0hLVWlWUlMwWEtRazQ5ckRpcFVDeVRZWW5TWGEyRVpQajNFaTBWUE1MZ2pY?=
 =?utf-8?B?eG9rWmRaVE4zVFhMc3ZCR1ROSys5aHFGU2I5UEVqV2NrY3pNeTVuTGZLZ2Fx?=
 =?utf-8?B?OHJ3bjNGS3JwU1dONjBlaTIzMHB3TDNUYzdxMkZ5dEcxNm1aVVlCZ1MvUVF6?=
 =?utf-8?B?Y2RGMGpWMWJqaE5JM2Fwb1BoMUV2c1B0eUxiaGtjQnNJZEdXZlIyNWJrWjhj?=
 =?utf-8?B?UytVQ1htcmpNUHc4b3F1Z0cwU1luRDEzTDFyVGorTk1wa0puRzAwZkdMR0N4?=
 =?utf-8?B?aG9oaGlRVTQ5RjFoT3dwdmdSVDdyWVBsNUtlVzdNbmxMcXhOZzlaLzFDRzN2?=
 =?utf-8?B?N2loUjBnbXIyaVNtU04wNmpyMTdIWkZESC8zTWsxNTBIU1Nzd2J0K09QWTRK?=
 =?utf-8?B?K3JjR1kzNi9IMHpKMmVvQWhzZWc4MVdTM0dTY3pUSHJxSlZSV3p6NzljUnRl?=
 =?utf-8?B?Y2pvVVpVempjVzEwdVhmRVRWbGFQOWR1L0hXZEl6V2hIUEtJMFdpVG5iU2VU?=
 =?utf-8?B?S3kzT25nV3pKRDlXUlkxVXhvaGZnbXVieElnK0RmSnpjZ3M0WXk2Tzk4NXd4?=
 =?utf-8?B?QmhPTHRaU0NqOU1xZDVwSk9tdGtMZkNJS2ZkZFpoTkZTRFhNT1FEZHRQWlBn?=
 =?utf-8?B?OWUrMkljZkgzNTlaQUdESlJDYjNkVTFZV1JCM3ovOEo3bXJVZzc2Rm1lc3hs?=
 =?utf-8?Q?CH+32YAxaYmClkS3T/6yQc7h9k9dcUJJ3yKfS3m?=
X-OriginatorOrg: outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fbc17180-d7fb-449c-53d1-08dc39bbc365
X-MS-Exchange-CrossTenant-AuthSource: SEZPR06MB6959.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 06:49:38.1356
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg:
	00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SEYPR06MB5940

On 3/1/2024 2:48 PM, Krzysztof Kozlowski wrote:
> On 01/03/2024 04:36, Yang Xiwen via B4 Relay wrote:
>> From: Yang Xiwen <forbidden405@outlook.com>
>>
>> It's hard to get the version number for each FEMAC core and it's unknown
>> how the version can be used. Remove them until it's really needed.
>>
>> While at it, remove SoC compatibles and only use fallback compatible.
>>
>> Signed-off-by: Yang Xiwen <forbidden405@outlook.com>
>> ---
>>  drivers/net/ethernet/hisilicon/hisi_femac.c | 4 +---
>>  1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/drivers/net/ethernet/hisilicon/hisi_femac.c b/drivers/net/ethernet/hisilicon/hisi_femac.c
>> index 2406263c9dd3..5a088cba7d4e 100644
>> --- a/drivers/net/ethernet/hisilicon/hisi_femac.c
>> +++ b/drivers/net/ethernet/hisilicon/hisi_femac.c
>> @@ -945,9 +945,7 @@ static int hisi_femac_drv_resume(struct platform_device *pdev)
>>  #endif
>>  
>>  static const struct of_device_id hisi_femac_match[] = {
>> -	{.compatible = "hisilicon,hisi-femac-v1",},
>> -	{.compatible = "hisilicon,hisi-femac-v2",},
>> -	{.compatible = "hisilicon,hi3516cv300-femac",},
>> +	{.compatible = "hisilicon,hisi-femac",},
> 
> 
> This breaks the ABI. I explained at least twice - use SoC compatibles. ONLY.

Sorry for the misuderstanding.

> 
> Best regards,
> Krzysztof
> 

-- 
Best regards,
Yang Xiwen