Received-SPF: pass (google.com: domain of linux-kernel+bounces-87990-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <d9b6d49e-9485-4733-a2d6-615bcc8f6ef3@amd.com>
Date: Fri, 1 Mar 2024 08:05:17 +0100
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3] clk: zynq: Prevent null pointer dereference caused by
 kmalloc failure
Content-Language: en-US
To: Duoming Zhou <duoming@zju.edu.cn>, linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org,
 mturquette@baylibre.com, sboyd@kernel.org
References: <20240301070336.13700-1-duoming@zju.edu.cn>
From: Michal Simek <michal.simek@amd.com>
Autocrypt: addr=michal.simek@amd.com; keydata=
 xsFNBFFuvDEBEAC9Amu3nk79+J+4xBOuM5XmDmljuukOc6mKB5bBYOa4SrWJZTjeGRf52VMc
 howHe8Y9nSbG92obZMqsdt+d/hmRu3fgwRYiiU97YJjUkCN5paHXyBb+3IdrLNGt8I7C9RMy
 svSoH4WcApYNqvB3rcMtJIna+HUhx8xOk+XCfyKJDnrSuKgx0Svj446qgM5fe7RyFOlGX/wF
 Ae63Hs0RkFo3I/+hLLJP6kwPnOEo3lkvzm3FMMy0D9VxT9e6Y3afe1UTQuhkg8PbABxhowzj
 SEnl0ICoqpBqqROV/w1fOlPrm4WSNlZJunYV4gTEustZf8j9FWncn3QzRhnQOSuzTPFbsbH5
 WVxwDvgHLRTmBuMw1sqvCc7CofjsD1XM9bP3HOBwCxKaTyOxbPJh3D4AdD1u+cF/lj9Fj255
 Es9aATHPvoDQmOzyyRNTQzupN8UtZ+/tB4mhgxWzorpbdItaSXWgdDPDtssJIC+d5+hskys8
 B3jbv86lyM+4jh2URpnL1gqOPwnaf1zm/7sqoN3r64cml94q68jfY4lNTwjA/SnaS1DE9XXa
 XQlkhHgjSLyRjjsMsz+2A4otRLrBbumEUtSMlPfhTi8xUsj9ZfPIUz3fji8vmxZG/Da6jx/c
 a0UQdFFCL4Ay/EMSoGbQouzhC69OQLWNH3rMQbBvrRbiMJbEZwARAQABzSlNaWNoYWwgU2lt
 ZWsgKEFNRCkgPG1pY2hhbC5zaW1la0BhbWQuY29tPsLBlAQTAQgAPgIbAwULCQgHAgYVCgkI
 CwIEFgIDAQIeAQIXgBYhBGc1DJv1zO6bU2Q1ajd8fyH+PR+RBQJkK9VOBQkWf4AXAAoJEDd8
 fyH+PR+ROzEP/1IFM7J4Y58SKuvdWDddIvc7JXcal5DpUtMdpuV+ZiHSOgBQRqvwH4CVBK7p
 ktDCWQAoWCg0KhdGyBjfyVVpm+Gw4DkZovcvMGUlvY5p5w8XxTE5Xx+cj/iDnj83+gy+0Oyz
 VFU9pew9rnT5YjSRFNOmL2dsorxoT1DWuasDUyitGy9iBegj7vtyAsvEObbGiFcKYSjvurkm
 MaJ/AwuJehZouKVfWPY/i4UNsDVbQP6iwO8jgPy3pwjt4ztZrl3qs1gV1F4Zrak1k6qoDP5h
 19Q5XBVtq4VSS4uLKjofVxrw0J+sHHeTNa3Qgk9nXJEvH2s2JpX82an7U6ccJSdNLYbogQAS
 BW60bxq6hWEY/afbT+tepEsXepa0y04NjFccFsbECQ4DA3cdA34sFGupUy5h5la/eEf3/8Kd
 BYcDd+aoxWliMVmL3DudM0Fuj9Hqt7JJAaA0Kt3pwJYwzecl/noK7kFhWiKcJULXEbi3Yf/Y
 pwCf691kBfrbbP9uDmgm4ZbWIT5WUptt3ziYOWx9SSvaZP5MExlXF4z+/KfZAeJBpZ95Gwm+
 FD8WKYjJChMtTfd1VjC4oyFLDUMTvYq77ABkPeKB/WmiAoqMbGx+xQWxW113wZikDy+6WoCS
 MPXfgMPWpkIUnvTIpF+m1Nyerqf71fiA1W8l0oFmtCF5oTMkzsFNBFFuvDEBEACXqiX5h4IA
 03fJOwh+82aQWeHVAEDpjDzK5hSSJZDE55KP8br1FZrgrjvQ9Ma7thSu1mbr+ydeIqoO1/iM
 fZA+DDPpvo6kscjep11bNhVa0JpHhwnMfHNTSHDMq9OXL9ZZpku/+OXtapISzIH336p4ZUUB
 5asad8Ux70g4gmI92eLWBzFFdlyR4g1Vis511Nn481lsDO9LZhKyWelbif7FKKv4p3FRPSbB
 vEgh71V3NDCPlJJoiHiYaS8IN3uasV/S1+cxVbwz2WcUEZCpeHcY2qsQAEqp4GM7PF2G6gtz
 IOBUMk7fjku1mzlx4zP7uj87LGJTOAxQUJ1HHlx3Li+xu2oF9Vv101/fsCmptAAUMo7KiJgP
 Lu8TsP1migoOoSbGUMR0jQpUcKF2L2jaNVS6updvNjbRmFojK2y6A/Bc6WAKhtdv8/e0/Zby
 iVA7/EN5phZ1GugMJxOLHJ1eqw7DQ5CHcSQ5bOx0Yjmhg4PT6pbW3mB1w+ClAnxhAbyMsfBn
 XxvvcjWIPnBVlB2Z0YH/gizMDdM0Sa/HIz+q7JR7XkGL4MYeAM15m6O7hkCJcoFV7LMzkNKk
 OiCZ3E0JYDsMXvmh3S4EVWAG+buA+9beElCmXDcXPI4PinMPqpwmLNcEhPVMQfvAYRqQp2fg
 1vTEyK58Ms+0a9L1k5MvvbFg9QARAQABwsF8BBgBCAAmAhsMFiEEZzUMm/XM7ptTZDVqN3x/
 If49H5EFAmQr1YsFCRZ/gFoACgkQN3x/If49H5H6BQ//TqDpfCh7Fa5v227mDISwU1VgOPFK
 eo/+4fF/KNtAtU/VYmBrwT/N6clBxjJYY1i60ekFfAEsCb+vAr1W9geYYpuA+lgR3/BOkHlJ
 eHf4Ez3D71GnqROIXsObFSFfZWGEgBtHBZ694hKwFmIVCg+lqeMV9nPQKlvfx2n+/lDkspGi
 epDwFUdfJLHOYxFZMQsFtKJX4fBiY85/U4X2xSp02DxQZj/N2lc9OFrKmFJHXJi9vQCkJdIj
 S6nuJlvWj/MZKud5QhlfZQsixT9wCeOa6Vgcd4vCzZuptx8gY9FDgb27RQxh/b1ZHalO1h3z
 kXyouA6Kf54Tv6ab7M/fhNqznnmSvWvQ4EWeh8gddpzHKk8ixw9INBWkGXzqSPOztlJbFiQ3
 YPi6o9Pw/IxdQJ9UZ8eCjvIMpXb4q9cZpRLT/BkD4ttpNxma1CUVljkF4DuGydxbQNvJFBK8
 ywyA0qgv+Mu+4r/Z2iQzoOgE1SymrNSDyC7u0RzmSnyqaQnZ3uj7OzRkq0fMmMbbrIvQYDS/
 y7RkYPOpmElF2pwWI/SXKOgMUgigedGCl1QRUio7iifBmXHkRrTgNT0PWQmeGsWTmfRit2+i
 l2dpB2lxha72cQ6MTEmL65HaoeANhtfO1se2R9dej57g+urO9V2v/UglZG1wsyaP/vOrgs+3
 3i3l5DA=
In-Reply-To: <20240301070336.13700-1-duoming@zju.edu.cn>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?cWNoWExia1ZxTVMvSE9uTjQ2WkJhZnhJVUVHaU1kZkFPMjd4eXp0Zk1kZ3ho?=
 =?utf-8?B?N1EvVHZOUDh2alhpbzJmNkNmUGJaR1dmZEFEaEVyT3o4VjIrR0J3RWV6dnc2?=
 =?utf-8?B?Mlh1OGltb29ONk5uUHd0L0twT2NZVElOb05lSkJ2NVR3SWpKeEdZNk5qM3hV?=
 =?utf-8?B?S3BFM2Z2OFU2OTA4ZVRNRFYvUkYyQ3Z4YWFhalZPVXU3TE1wNVo4ZXlJSHo3?=
 =?utf-8?B?Ujk5RHRXRkFGdDRpVTN4SE1YWDRaTU5nVzBmdnZsby9pODVLV1NtblNMUU1L?=
 =?utf-8?B?cnpha093NW5iNDBub05JbnloMG11ZWlrQjBwcE5pWU1Ka3lla2dKTFAwMHRH?=
 =?utf-8?B?MGh2cE1yOWRKOXRkOVNsOVY4cmVXb0VFNDBqTDVzajhKQjRDbEtUV1JScnBz?=
 =?utf-8?B?YlVxWXp2ZW1PZ3VEQTlmWjBac0hwek5TWUdSZ0NIWVQzTjJyMEd4dFcyZE0w?=
 =?utf-8?B?aXhITlVmYkFKMXBMNWhVb0E2RGdPdEVJREVoMzJXdUNLdTVyVFRKb2o3UCtF?=
 =?utf-8?B?OGJIVHVxZEJ3Z1AxZGNNZ1FuTFI0YmNQWU5EMzlDMTYwK0M0bkk0WGJsZEZS?=
 =?utf-8?B?bU41Y0JheFFvcDh2aGErSGFkVjc1aUZySzFqOFBxblJlMTBKMFVjV3B1Q3Bh?=
 =?utf-8?B?OXRYUmRwRVRiTi96ampxQWl0aUVNby8yTElMQ2VGSXZqNUlsMHloUjlqdGVD?=
 =?utf-8?B?aFVEUlNqNGEza0hRMUh0MTBsbmhUVmxKZ1NvZjJZNy9jWDBhaFJVbm9NM2JI?=
 =?utf-8?B?RXJnSXFhc1FtbTNubEFBT25oQ24wNlBCbnFLSGdJZnRUTU5wUDQzN3kzMDVp?=
 =?utf-8?B?ZUZNcldnVU5uQjZWUVNYQmJqMC8wUURxajF4WDdmcDZWWjE5Nm8rODkyaHZk?=
 =?utf-8?B?RjJ5eHJjSS9vQjUxeGdZQWdCdGcyTEZXalNxbWUyUTdSSFFQTjMxYXF2eXlC?=
 =?utf-8?B?cUpxZkZKT05RZ0hGUjRPUTlZUUxoeSt0YnlNL3J2dnZFSTVLRlV3aHNDWjBL?=
 =?utf-8?B?TURnTlBQcENaK05MdUVMY29yVzRWL2RBUThmVzc0TUJqSkt1Y21JS0JhQlRR?=
 =?utf-8?B?TlN6SEc3QWFBYmcvWkRPUTRzMnMwZFVGMVdkd1d1Wk1adnFkYnlpMDNxMDRu?=
 =?utf-8?B?Nm42NnFaUktVVnpxM2FQZDVuM0FzQk1EQTUzWnVwOVNQZ0d3QUhpRlZGUDNX?=
 =?utf-8?B?a1VkUjFvaEFQaWhEYTdxSTAyYTBXS2FTNlZxa1JpYzdNODlxUUM2bk41UHQ5?=
 =?utf-8?B?Vkp3VElaMlp0QWNJNVFVTkp4UVlxWE5RNjUxa3d5K2c1NWRzcEJXeWkxSDZa?=
 =?utf-8?B?aUFNeVA5RHBQOUtnWEc5SzhlcW5Wblh2STQzcnJCek9YVTZyZW1oZFpuVit4?=
 =?utf-8?B?WDR6K0J5bkFIS3V0cnIxZGlWdHVCME5aaTVFSUVSWGRDZGVoZ3ZQc3BLd21a?=
 =?utf-8?B?VDc1WWVVNytmeXZSSFdaeXJ1ZGZ4djdOUUs0YUpXa0FwenhuVmdTM2U3U0Jq?=
 =?utf-8?B?WjVaTXJ4M1MxMFZNRmZmMlBXVjluRUJiVy95bWNwL0ZuUXIvaWRxaWllS3dx?=
 =?utf-8?B?cEI5a0RDV2I4VmkzUXBiTVhTWml5QnllTFZ6bFdTMStBOW9LVGFPTlNNa2Vh?=
 =?utf-8?B?U3prbUs2THFlY095Y2dwTmYwRzRlNmdlZVl6YUpvcGNmcGI3VkZXam1vekVC?=
 =?utf-8?B?NVJLOW5qeEFTYm5oWFZ6dWVmaVB4MGFBUkdoMVZTazY2N3kwWEVRMG5mMSt4?=
 =?utf-8?B?U0JRbXRaUEFaYnhwRzJOTGhETDBka2dlaFJNZGtUMW9rU3dKQjJIR3NqajFi?=
 =?utf-8?B?MFF2WUlLYlF1TlozUG1pMXRHSFdXMFc4L0hOMFhicWgwWWFJT0EzMmU2akho?=
 =?utf-8?B?ZHdybmwvcktJTzhnaUREOTE1Yy8wUGNVQzNldkE2UjNPcHR4VEdiOEZNbnJE?=
 =?utf-8?B?aERRZDNaODRFQ3lCUzBpUVIwMHVNVnJoWWsrK0pGZTFQeVVKUS90Z0JqUE9B?=
 =?utf-8?B?elVzOEphQmc3ODI5Z2lOYnBScENCR0F1Q01Cb244dmpHT3JMSVlyeEswaUl2?=
 =?utf-8?B?SEpjNHlIUFh5anVmdlh5NUo2d2NJS1A4UkJVMHhvSUVqWlN0T2RxMmNOZWls?=
 =?utf-8?Q?T0ZU6UTw44V/bWtFTFr1RrLRA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 04c39d84-ee2e-4fb1-f21c-08dc39bdfa87
X-MS-Exchange-CrossTenant-AuthSource: SN7PR12MB8101.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Mar 2024 07:05:30.6745
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pWiYt28opzz2pEGz5sNLbJCIDeT3li8WCD9djJe9853TfueXqP6IxnLCntbhFFRD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYXPR12MB9443


On 3/1/24 08:03, Duoming Zhou wrote:
> The kmalloc() in zynq_clk_setup() will return null if the
> physical memory has run out. As a result, if we use snprintf()
> to write data to the null address, the null pointer dereference
> bug will happen.
> 
> This patch uses a stack variable to replace the kmalloc().
> 
> Fixes: 0ee52b157b8e ("clk: zynq: Add clock controller driver")
> Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
> ---
> Changes in v3:
>    - Put stack variable in the head of the function and remove variable tmp.
> 
>   drivers/clk/zynq/clkc.c | 7 ++-----
>   1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/clk/zynq/clkc.c b/drivers/clk/zynq/clkc.c
> index 7bdeaff2bfd..45479653c3b 100644
> --- a/drivers/clk/zynq/clkc.c
> +++ b/drivers/clk/zynq/clkc.c
> @@ -215,7 +215,7 @@ static void __init zynq_clk_setup(struct device_node *np)
>   	int i;
>   	u32 tmp;
>   	int ret;
> -	char *clk_name;
> +	char clk_name[16];
>   	unsigned int fclk_enable = 0;
>   	const char *clk_output_name[clk_max];
>   	const char *cpu_parents[4];
> @@ -426,12 +426,10 @@ static void __init zynq_clk_setup(struct device_node *np)
>   			"gem1_emio_mux", CLK_SET_RATE_PARENT,
>   			SLCR_GEM1_CLK_CTRL, 0, 0, &gem1clk_lock);
>   
> -	tmp = strlen("mio_clk_00x");
> -	clk_name = kmalloc(tmp, GFP_KERNEL);
>   	for (i = 0; i < NUM_MIO_PINS; i++) {
>   		int idx;
>   
> -		snprintf(clk_name, tmp, "mio_clk_%2.2d", i);
> +		snprintf(clk_name, 16, "mio_clk_%2.2d", i);

I would prefer to use macro/define if that values has to match and have connection.

Thanks,
Michal